net: lan966x: flower: validate control flags

[PATCH net-next v2 0/3] net: lan966x: flower: validate control flags

Posted by Asbjørn Sloth Tønnesen 1 week, 3 days ago

This series adds flower control flags validation to the
lan966x driver, and changes it from assuming that it handles
all control flags, to instead reject rules if they have
masked any unknown/unsupported control flags.

---
Changelog:

v2:
* Split first patch into 2 (requested by Jiri)
* Added cover letter (requested by Simon)

v1: https://lore.kernel.org/netdev/20240423102720.228728-1-ast@fiberby.net/

Asbjørn Sloth Tønnesen (3):
  net: lan966x: flower: add extack to
    lan966x_tc_flower_handler_control_usage()
  net: lan966x: flower: rename goto in
    lan966x_tc_flower_handler_control_usage()
  net: lan966x: flower: check for unsupported control flags

 .../ethernet/microchip/lan966x/lan966x_tc_flower.c | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

-- 
2.43.0

Re: [PATCH net-next v2 0/3] net: lan966x: flower: validate control flags

Posted by Horatiu Vultur 1 week, 3 days ago

The 04/24/2024 12:53, Asbjørn Sloth Tønnesen wrote:
> 
> This series adds flower control flags validation to the
> lan966x driver, and changes it from assuming that it handles
> all control flags, to instead reject rules if they have
> masked any unknown/unsupported control flags.

For the entire series:
Reviewed-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> 
> ---
> Changelog:
> 
> v2:
> * Split first patch into 2 (requested by Jiri)
> * Added cover letter (requested by Simon)
> 
> v1: https://lore.kernel.org/netdev/20240423102720.228728-1-ast@fiberby.net/
> 
> Asbjørn Sloth Tønnesen (3):
>   net: lan966x: flower: add extack to
>     lan966x_tc_flower_handler_control_usage()
>   net: lan966x: flower: rename goto in
>     lan966x_tc_flower_handler_control_usage()
>   net: lan966x: flower: check for unsupported control flags
> 
>  .../ethernet/microchip/lan966x/lan966x_tc_flower.c | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)
> 
> --
> 2.43.0
> 

-- 
/Horatiu

Re: [PATCH net-next v2 0/3] net: lan966x: flower: validate control flags

Posted by Jiri Pirko 1 week, 3 days ago

Wed, Apr 24, 2024 at 02:53:37PM CEST, ast@fiberby.net wrote:
>This series adds flower control flags validation to the
>lan966x driver, and changes it from assuming that it handles
>all control flags, to instead reject rules if they have
>masked any unknown/unsupported control flags.
>
>---
>Changelog:
>
>v2:
>* Split first patch into 2 (requested by Jiri)
>* Added cover letter (requested by Simon)

set-
Reviewed-by: Jiri Pirko <jiri@nvidia.com>