net: sparx5: flower: validate control flags

[PATCH net-next v2 0/4] net: sparx5: flower: validate control flags

Posted by Asbjørn Sloth Tønnesen 1 year, 9 months ago

This series adds flower control flags validation to the
sparx5 driver, and changes it from assuming that it handles
all control flags, to instead reject rules if they have
masked any unknown/unsupported control flags.

---

Changelog:

v2:
* Split first patch into 3 (requested by Jiri)
* Convert a missed extack usage (noticed by Daniel)
* Added cover letter (requested by Simon and Daniel)

v1: https://lore.kernel.org/netdev/20240423102728.228765-1-ast@fiberby.net/

Asbjørn Sloth Tønnesen (4):
  net: sparx5: flower: only do lookup if fragment flags are set
  net: sparx5: flower: add extack to
    sparx5_tc_flower_handler_control_usage()
  net: sparx5: flower: remove goto in
    sparx5_tc_flower_handler_control_usage()
  net: sparx5: flower: check for unsupported control flags

 .../microchip/sparx5/sparx5_tc_flower.c       | 20 +++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

-- 
2.43.0

Re: [PATCH net-next v2 0/4] net: sparx5: flower: validate control flags

Posted by Daniel Machon 1 year, 9 months ago

> This series adds flower control flags validation to the
> sparx5 driver, and changes it from assuming that it handles
> all control flags, to instead reject rules if they have
> masked any unknown/unsupported control flags.
> 
> ---
> 
> Changelog:
> 
> v2:
> * Split first patch into 3 (requested by Jiri)
> * Convert a missed extack usage (noticed by Daniel)
> * Added cover letter (requested by Simon and Daniel)
> 
> v1: https://lore.kernel.org/netdev/20240423102728.228765-1-ast@fiberby.net/
> 
> Asbjørn Sloth Tønnesen (4):
>   net: sparx5: flower: only do lookup if fragment flags are set
>   net: sparx5: flower: add extack to
>     sparx5_tc_flower_handler_control_usage()
>   net: sparx5: flower: remove goto in
>     sparx5_tc_flower_handler_control_usage()
>   net: sparx5: flower: check for unsupported control flags
> 
>  .../microchip/sparx5/sparx5_tc_flower.c       | 20 +++++++++++--------
>  1 file changed, 12 insertions(+), 8 deletions(-)
> 
> --
> 2.43.0
>

For the series:

Reviewed-by: Daniel Machon <daniel.machon@microchip.com>
Tested-by: Daniel Machon <daniel.machon@microchip.com>