b53 is now the only remaining driver that uses both PHYLIB's adjust_link
and PHYLINK's mac_ops callbacks, convert entirely to PHYLINK.

Florian Fainelli (8):
  net: dsa: b53: Stop exporting b53_phylink_* routines
  net: dsa: b53: Introduce b53_adjust_531x5_rgmii()
  net: dsa: b53: Introduce b53_adjust_5325_mii()
  net: dsa: b53: Force flow control for BCM5301X CPU port(s)
  net: dsa: b53: Configure RGMII for 531x5 and MII for 5325
  net: dsa: b53: Call b53_eee_init() from b53_mac_link_up()
  net: dsa: b53: Remove b53_adjust_link()
  net: dsa: b53: provide own phylink MAC operations

 drivers/net/dsa/b53/b53_common.c | 208 ++++++++++++++++---------------
 drivers/net/dsa/b53/b53_priv.h   |  12 --
 2 files changed, 105 insertions(+), 115 deletions(-)

-- 
2.34.1

On Tue, Apr 23, 2024 at 11:33:31AM -0700, Florian Fainelli wrote:
> b53 is now the only remaining driver that uses both PHYLIB's adjust_link
> and PHYLINK's mac_ops callbacks, convert entirely to PHYLINK.
> 
> Florian Fainelli (8):
>   net: dsa: b53: Stop exporting b53_phylink_* routines
>   net: dsa: b53: Introduce b53_adjust_531x5_rgmii()
>   net: dsa: b53: Introduce b53_adjust_5325_mii()
>   net: dsa: b53: Force flow control for BCM5301X CPU port(s)
>   net: dsa: b53: Configure RGMII for 531x5 and MII for 5325
>   net: dsa: b53: Call b53_eee_init() from b53_mac_link_up()
>   net: dsa: b53: Remove b53_adjust_link()
>   net: dsa: b53: provide own phylink MAC operations

Read through the series, nothing obvious stands out, thanks for doing
this!

For the series:

Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

On 4/23/24 12:14, Russell King (Oracle) wrote:
> On Tue, Apr 23, 2024 at 11:33:31AM -0700, Florian Fainelli wrote:
>> b53 is now the only remaining driver that uses both PHYLIB's adjust_link
>> and PHYLINK's mac_ops callbacks, convert entirely to PHYLINK.
>>
>> Florian Fainelli (8):
>>    net: dsa: b53: Stop exporting b53_phylink_* routines
>>    net: dsa: b53: Introduce b53_adjust_531x5_rgmii()
>>    net: dsa: b53: Introduce b53_adjust_5325_mii()
>>    net: dsa: b53: Force flow control for BCM5301X CPU port(s)
>>    net: dsa: b53: Configure RGMII for 531x5 and MII for 5325
>>    net: dsa: b53: Call b53_eee_init() from b53_mac_link_up()
>>    net: dsa: b53: Remove b53_adjust_link()
>>    net: dsa: b53: provide own phylink MAC operations
> 
> Read through the series, nothing obvious stands out, thanks for doing
> this!

And thank you for the reminder this needed to be done, once this lands I 
will submit the removal of the adjust_link within net/dsa/, unless you 
have that queued up already ready to go?

> 
> For the series:
> 
> Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> 

-- 
Florian

On Tue, Apr 23, 2024 at 12:15:49PM -0700, Florian Fainelli wrote:
> And thank you for the reminder this needed to be done, once this lands I
> will submit the removal of the adjust_link within net/dsa/, unless you have
> that queued up already ready to go?

I don't have that queued up, but it would be great to get that done as
well. I think it would get rid of a reasonable amount of code in
net/dsa?

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!