fs/ntfs3: Fix case when index is reused during tree transformation

[PATCH] fs/ntfs3: Fix case when index is reused during tree transformation

Posted by Konstantin Komarov 1 week, 5 days ago

Fixes: 82cae269cfa95 ("fs/ntfs3: Add initialization of super block")
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
Cc: stable@vger.kernel.org
---
 fs/ntfs3/index.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/fs/ntfs3/index.c b/fs/ntfs3/index.c
index daabaad63aaf..14284f0ed46a 100644
--- a/fs/ntfs3/index.c
+++ b/fs/ntfs3/index.c
@@ -1533,6 +1533,11 @@ static int indx_add_allocate(struct ntfs_index *indx, struct ntfs_inode *ni,
 		goto out1;
 	}
 
+	if (data_size <= le64_to_cpu(alloc->nres.data_size)) {
+		/* Reuse index. */
+		goto out;
+	}
+
 	/* Increase allocation. */
 	err = attr_set_size(ni, ATTR_ALLOC, in->name, in->name_len,
 			    &indx->alloc_run, data_size, &data_size, true,
@@ -1546,6 +1551,7 @@ static int indx_add_allocate(struct ntfs_index *indx, struct ntfs_inode *ni,
 	if (in->name == I30_NAME)
 		i_size_write(&ni->vfs_inode, data_size);
 
+out:
 	*vbn = bit << indx->idx2vbn_bits;
 
 	return 0;
-- 
2.34.1

Re: [PATCH] fs/ntfs3: Fix case when index is reused during tree transformation

Posted by Greg KH 1 week, 5 days ago

On Tue, Apr 23, 2024 at 05:41:54PM +0300, Konstantin Komarov wrote:
> Fixes: 82cae269cfa95 ("fs/ntfs3: Add initialization of super block")
> Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
> Cc: stable@vger.kernel.org
> ---
>  fs/ntfs3/index.c | 6 ++++++
>  1 file changed, 6 insertions(+)

I know I can't take patches without any changelog text, and odds are you
shouldn't either...

thanks,

greg k-h