platform/x86: ISST: Add Grand Ridge to HPM CPU list

[PATCH] platform/x86: ISST: Add Grand Ridge to HPM CPU list

Posted by Srinivas Pandruvada 1 year, 9 months ago

Add Grand Ridge (ATOM_CRESTMONT) to hpm_cpu_ids, so that MSR 0x54 can be
used.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
 drivers/platform/x86/intel/speed_select_if/isst_if_common.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
index 30951f7131cd..1accdaaf282c 100644
--- a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
+++ b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
@@ -721,6 +721,7 @@ static struct miscdevice isst_if_char_driver = {
 static const struct x86_cpu_id hpm_cpu_ids[] = {
 	X86_MATCH_INTEL_FAM6_MODEL(GRANITERAPIDS_D,	NULL),
 	X86_MATCH_INTEL_FAM6_MODEL(GRANITERAPIDS_X,	NULL),
+	X86_MATCH_INTEL_FAM6_MODEL(ATOM_CRESTMONT,	NULL),
 	X86_MATCH_INTEL_FAM6_MODEL(ATOM_CRESTMONT_X,	NULL),
 	{}
 };
-- 
2.40.1

Re: [PATCH] platform/x86: ISST: Add Grand Ridge to HPM CPU list

Posted by Hans de Goede 1 year, 9 months ago

Hi,

On 4/22/24 11:22 PM, Srinivas Pandruvada wrote:
> Add Grand Ridge (ATOM_CRESTMONT) to hpm_cpu_ids, so that MSR 0x54 can be
> used.
> 
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>

This looks like it needs to be applied on top of the fixes branch, or else
after 6.10-rc1 is out.

Ilpo, what do you think ?

Regards,

Hans

> ---
>  drivers/platform/x86/intel/speed_select_if/isst_if_common.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
> index 30951f7131cd..1accdaaf282c 100644
> --- a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
> +++ b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
> @@ -721,6 +721,7 @@ static struct miscdevice isst_if_char_driver = {
>  static const struct x86_cpu_id hpm_cpu_ids[] = {
>  	X86_MATCH_INTEL_FAM6_MODEL(GRANITERAPIDS_D,	NULL),
>  	X86_MATCH_INTEL_FAM6_MODEL(GRANITERAPIDS_X,	NULL),
> +	X86_MATCH_INTEL_FAM6_MODEL(ATOM_CRESTMONT,	NULL),
>  	X86_MATCH_INTEL_FAM6_MODEL(ATOM_CRESTMONT_X,	NULL),
>  	{}
>  };

Re: [PATCH] platform/x86: ISST: Add Grand Ridge to HPM CPU list

Posted by Ilpo Järvinen 1 year, 9 months ago

On Mon, 29 Apr 2024, Hans de Goede wrote:
> On 4/22/24 11:22 PM, Srinivas Pandruvada wrote:
> > Add Grand Ridge (ATOM_CRESTMONT) to hpm_cpu_ids, so that MSR 0x54 can be
> > used.
> > 
> > Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> 
> This looks like it needs to be applied on top of the fixes branch, or else
> after 6.10-rc1 is out.
> 
> Ilpo, what do you think ?

I've now taken this into fixes branch.

-- 
 i.