[PATCH v7 2/3] dt-bindings: sc16is7xx: Add compatible line for XR20M1172 UART

Konstantin Pugin posted 3 patches 1 year, 9 months ago
There is a newer version of this series
[PATCH v7 2/3] dt-bindings: sc16is7xx: Add compatible line for XR20M1172 UART
Posted by Konstantin Pugin 1 year, 9 months ago
Add EXAR XR20M1172 UART compatible line into devicetree documentation.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Vladimir Zapolskiy <vz@mleia.com>
Signed-off-by: Konstantin Pugin <ria.freelander@gmail.com>
---
 Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml
index 5dec15b7e7c3..c4bedf23368b 100644
--- a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml
+++ b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml
@@ -12,6 +12,7 @@ maintainers:
 properties:
   compatible:
     enum:
+      - exar,xr20m1172
       - nxp,sc16is740
       - nxp,sc16is741
       - nxp,sc16is750
-- 
2.34.1
Re: [PATCH v7 2/3] dt-bindings: sc16is7xx: Add compatible line for XR20M1172 UART
Posted by Conor Dooley 1 year, 9 months ago
On Mon, Apr 22, 2024 at 04:32:14PM +0300, Konstantin Pugin wrote:
> Add EXAR XR20M1172 UART compatible line into devicetree documentation.

I thought I had already pointed out a need for the commit message to
explain why this exar device belongs in this file. IIRC you said it was
in the driver commit and cover letter, but it needs to go here too.

Thanks,
Conor.

> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Vladimir Zapolskiy <vz@mleia.com>
> Signed-off-by: Konstantin Pugin <ria.freelander@gmail.com>
> ---
>  Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml
> index 5dec15b7e7c3..c4bedf23368b 100644
> --- a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml
> +++ b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml
> @@ -12,6 +12,7 @@ maintainers:
>  properties:
>    compatible:
>      enum:
> +      - exar,xr20m1172
>        - nxp,sc16is740
>        - nxp,sc16is741
>        - nxp,sc16is750
> -- 
> 2.34.1
> 
Re: [PATCH v7 2/3] dt-bindings: sc16is7xx: Add compatible line for XR20M1172 UART
Posted by Konstantin P. 1 year, 9 months ago
On Mon, Apr 22, 2024 at 6:28 PM Conor Dooley <conor@kernel.org> wrote:
>
> On Mon, Apr 22, 2024 at 04:32:14PM +0300, Konstantin Pugin wrote:
> > Add EXAR XR20M1172 UART compatible line into devicetree documentation.
>
> I thought I had already pointed out a need for the commit message to
> explain why this exar device belongs in this file. IIRC you said it was
> in the driver commit and cover letter, but it needs to go here too.
>
> Thanks,
> Conor.
>
> >
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Reviewed-by: Vladimir Zapolskiy <vz@mleia.com>
> > Signed-off-by: Konstantin Pugin <ria.freelander@gmail.com>
> > ---
> >  Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml
> > index 5dec15b7e7c3..c4bedf23368b 100644
> > --- a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml
> > +++ b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml
> > @@ -12,6 +12,7 @@ maintainers:
> >  properties:
> >    compatible:
> >      enum:
> > +      - exar,xr20m1172
> >        - nxp,sc16is740
> >        - nxp,sc16is741
> >        - nxp,sc16is750
> > --
> > 2.34.1
> >

Okay, will add again (another v6 missed).