From: Konstantin Pugin <ria.freelander@gmail.com>

The hardware supports both RTS_ON_SEND and RTS_AFTER_SEND modes, but
after the commit 4afeced55baa ("serial: core: fix sanitizing check for
RTS settings") we always end up with SER_RS485_RTS_AFTER_SEND set and
always write to the register field SC16IS7XX_EFCR_RTS_INVERT_BIT, which
breaks some hardware using these chips.

Fixes: 267913ecf737 ("serial: sc16is7xx: Fill in rs485_supported")
Signed-off-by: Konstantin Pugin <ria.freelander@gmail.com>
---
 drivers/tty/serial/sc16is7xx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
index 03cf30e20b75..dfcc804f558f 100644
--- a/drivers/tty/serial/sc16is7xx.c
+++ b/drivers/tty/serial/sc16is7xx.c
@@ -1449,7 +1449,7 @@ static int sc16is7xx_setup_mctrl_ports(struct sc16is7xx_port *s,
 }
 
 static const struct serial_rs485 sc16is7xx_rs485_supported = {
-	.flags = SER_RS485_ENABLED | SER_RS485_RTS_AFTER_SEND,
+	.flags = SER_RS485_ENABLED | SER_RS485_RTS_ON_SEND | SER_RS485_RTS_AFTER_SEND,
 	.delay_rts_before_send = 1,
 	.delay_rts_after_send = 1,	/* Not supported but keep returning -EINVAL */
 };
-- 
2.34.1

On Mon, Apr 22, 2024 at 03:37:55PM +0300, Konstantin Pugin wrote:
> From: Konstantin Pugin <ria.freelander@gmail.com>
> 
> The hardware supports both RTS_ON_SEND and RTS_AFTER_SEND modes, but
> after the commit 4afeced55baa ("serial: core: fix sanitizing check for
> RTS settings") we always end up with SER_RS485_RTS_AFTER_SEND set and
> always write to the register field SC16IS7XX_EFCR_RTS_INVERT_BIT, which
> breaks some hardware using these chips.

LGTM, but I leave it to Hugo for testing and other comments, if any,
as I don't have a HW.

Reviewed-by: Andy Shevchenko <andy@kernel.org>

-- 
With Best Regards,
Andy Shevchenko

On Mon, Apr 22, 2024 at 3:56 PM Andy Shevchenko <andy@kernel.org> wrote:
>
> On Mon, Apr 22, 2024 at 03:37:55PM +0300, Konstantin Pugin wrote:
> > From: Konstantin Pugin <ria.freelander@gmail.com>
> >
> > The hardware supports both RTS_ON_SEND and RTS_AFTER_SEND modes, but
> > after the commit 4afeced55baa ("serial: core: fix sanitizing check for
> > RTS settings") we always end up with SER_RS485_RTS_AFTER_SEND set and
> > always write to the register field SC16IS7XX_EFCR_RTS_INVERT_BIT, which
> > breaks some hardware using these chips.
>
> LGTM, but I leave it to Hugo for testing and other comments, if any,
> as I don't have a HW.
>
> Reviewed-by: Andy Shevchenko <andy@kernel.org>
>
> --
> With Best Regards,
> Andy Shevchenko
>
>

Andy, I need to do v7 (because there is a missed fix), but Yandex do
not allow me to send more mail( So, can it be sent next day?

On Mon, Apr 22, 2024 at 4:18 PM Konstantin P. <ria.freelander@gmail.com> wrote:
> On Mon, Apr 22, 2024 at 3:56 PM Andy Shevchenko <andy@kernel.org> wrote:

...

> Andy, I need to do v7 (because there is a missed fix), but Yandex do
> not allow me to send more mail( So, can it be sent next day?

You must wait, as it's spelled in the documentation and common sense.
Let people have time to review that. I suggest for this series the
cadence ~3 working days, so next one on Wednesday evening (European
time) or so.

-- 
With Best Regards,
Andy Shevchenko

Hi,

On 22.04.24 15:20, Konstantin P. wrote:
> On Mon, Apr 22, 2024 at 3:56 PM Andy Shevchenko <andy@kernel.org> wrote:
>>
>> On Mon, Apr 22, 2024 at 03:37:55PM +0300, Konstantin Pugin wrote:
>>> From: Konstantin Pugin <ria.freelander@gmail.com>
>>>
>>> The hardware supports both RTS_ON_SEND and RTS_AFTER_SEND modes, but
>>> after the commit 4afeced55baa ("serial: core: fix sanitizing check for
>>> RTS settings") we always end up with SER_RS485_RTS_AFTER_SEND set and
>>> always write to the register field SC16IS7XX_EFCR_RTS_INVERT_BIT, which
>>> breaks some hardware using these chips.
>>
>> LGTM, but I leave it to Hugo for testing and other comments, if any,
>> as I don't have a HW.
>>
>> Reviewed-by: Andy Shevchenko <andy@kernel.org>
>>
>> --
>> With Best Regards,
>> Andy Shevchenko
>>
>>
>
> Andy, I need to do v7 (because there is a missed fix), but Yandex do
> not allow me to send more mail( So, can it be sent next day?
>

Please add at least the linux-serial mailing list the next time. As far as I am
concerned, I was only aware of this issue because of Andys response which added
linux-serial. Furthermore shouldnt this also got to stable?

Regards,
Lino