[PATCH v8 0/3] virt: vmgenid: add devicetree bindings support

Jason A. Donenfeld posted 3 patches 2 weeks ago
.../bindings/rng/microsoft,vmgenid.yaml       |  49 ++++++
MAINTAINERS                                   |   1 +
drivers/virt/Kconfig                          |   1 -
drivers/virt/vmgenid.c                        | 150 ++++++++++++++----
4 files changed, 165 insertions(+), 36 deletions(-)
create mode 100644 Documentation/devicetree/bindings/rng/microsoft,vmgenid.yaml
[PATCH v8 0/3] virt: vmgenid: add devicetree bindings support
Posted by Jason A. Donenfeld 2 weeks ago
Changes v7->v8:
- Remove Kconfig depends statement entirely, instead of ACPI||OF.
- Check platform_get_irq() return value against < 0 rather than !0.

This is a cleanup of Sudan's OF vmgenid patches, simplified a bit, but
still with the same intent and mostly unchanged. I'll take this via my
random tree, but Krzysztof, I would appreciate having your ack/review on
it.

Sudan - if I've mangled something here, please let me know. I verified
this still works with ACPI in QEMU, but I don't know about your private
firecracker OF branch, so please pipe up if something is amiss. It's
basically the same thing, though, so I suspect it'll be fine.

Thanks,
Jason

Sudan Landge (3):
  virt: vmgenid: change implementation to use a platform driver
  dt-bindings: rng: Add vmgenid support
  virt: vmgenid: add support for devicetree bindings

 .../bindings/rng/microsoft,vmgenid.yaml       |  49 ++++++
 MAINTAINERS                                   |   1 +
 drivers/virt/Kconfig                          |   1 -
 drivers/virt/vmgenid.c                        | 150 ++++++++++++++----
 4 files changed, 165 insertions(+), 36 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/rng/microsoft,vmgenid.yaml

-- 
2.44.0
Re: [PATCH v8 0/3] virt: vmgenid: add devicetree bindings support
Posted by Babis Chalios 1 week, 4 days ago
On 4/20/24 00:39, Jason A. Donenfeld wrote:
> Changes v7->v8:
> - Remove Kconfig depends statement entirely, instead of ACPI||OF.
> - Check platform_get_irq() return value against < 0 rather than !0.
>
> This is a cleanup of Sudan's OF vmgenid patches, simplified a bit, but
> still with the same intent and mostly unchanged. I'll take this via my
> random tree, but Krzysztof, I would appreciate having your ack/review on
> it.
>
> Sudan - if I've mangled something here, please let me know. I verified
> this still works with ACPI in QEMU, but I don't know about your private
> firecracker OF branch, so please pipe up if something is amiss. It's
> basically the same thing, though, so I suspect it'll be fine.

Hi Jason,

I also verified that this still works with ACPI on Firecracker.
I also verified that the OF part of the patch works with this:
https://github.com/sudanl0/firecracker/commit/f382e09a9b1e4453d2b231232d89bcb85296ac87
patch on top of Firecracker.

Tested-by: Babis Chalios <bchalios@amazon.es>

Cheers,
Babis
Re: [PATCH v8 0/3] virt: vmgenid: add devicetree bindings support
Posted by Jason A. Donenfeld 1 week ago
Hi Babis,

On Mon, Apr 22, 2024 at 03:29:59PM +0200, Babis Chalios wrote:
> I also verified that this still works with ACPI on Firecracker.
> I also verified that the OF part of the patch works with this:
> https://github.com/sudanl0/firecracker/commit/f382e09a9b1e4453d2b231232d89bcb85296ac87
> patch on top of Firecracker.
> 
> Tested-by: Babis Chalios <bchalios@amazon.es>

Thanks for testing this. No word from the other folks who were looking
at this patchset before, so I'll move ahead and apply this to
random.git and send it up for 6.10.

- [1/3] https://git.kernel.org/crng/random/c/e07606713
- [2/3] https://git.kernel.org/crng/random/c/a4aded1ff
- [3/3] https://git.kernel.org/crng/random/c/7b1bcd6b5

Jason