mm: fix the comment error of memcontrol.h

[PATCH] mm: fix the comment error of memcontrol.h

Posted by lipeifeng@oppo.com 2 weeks ago

From: Peifeng Li <lipeifeng@oppo.com>

Signed-off-by: Peifeng Li <lipeifeng@oppo.com>
---
 include/linux/memcontrol.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
index 394fd0a887ae..07d08be706bf 100644
--- a/include/linux/memcontrol.h
+++ b/include/linux/memcontrol.h
@@ -1679,7 +1679,7 @@ static inline bool folio_matches_lruvec(struct folio *folio,
 	       lruvec_memcg(lruvec) == folio_memcg(folio);
 }
 
-/* Don't lock again iff page's lruvec locked */
+/* Don't lock again if page's lruvec locked */
 static inline struct lruvec *folio_lruvec_relock_irq(struct folio *folio,
 		struct lruvec *locked_lruvec)
 {
@@ -1693,7 +1693,7 @@ static inline struct lruvec *folio_lruvec_relock_irq(struct folio *folio,
 	return folio_lruvec_lock_irq(folio);
 }
 
-/* Don't lock again iff folio's lruvec locked */
+/* Don't lock again if folio's lruvec locked */
 static inline void folio_lruvec_relock_irqsave(struct folio *folio,
 		struct lruvec **lruvecp, unsigned long *flags)
 {
-- 
2.34.1

Re: [PATCH] mm: fix the comment error of memcontrol.h

Posted by Michal Hocko 2 weeks ago

On Wed 17-04-24 20:16:45, lipeifeng@oppo.com wrote:
> From: Peifeng Li <lipeifeng@oppo.com>
> 
> Signed-off-by: Peifeng Li <lipeifeng@oppo.com>
> ---
>  include/linux/memcontrol.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
> index 394fd0a887ae..07d08be706bf 100644
> --- a/include/linux/memcontrol.h
> +++ b/include/linux/memcontrol.h
> @@ -1679,7 +1679,7 @@ static inline bool folio_matches_lruvec(struct folio *folio,
>  	       lruvec_memcg(lruvec) == folio_memcg(folio);
>  }
>  
> -/* Don't lock again iff page's lruvec locked */
> +/* Don't lock again if page's lruvec locked */

Not a typo. iff stands for if and only if

-- 
Michal Hocko
SUSE Labs

Re: [PATCH] mm: fix the comment error of memcontrol.h

Posted by 李培锋 2 weeks ago

在 2024/4/17 20:24, Michal Hocko 写道:
> On Wed 17-04-24 20:16:45, lipeifeng@oppo.com wrote:
>> From: Peifeng Li <lipeifeng@oppo.com>
>>
>> Signed-off-by: Peifeng Li <lipeifeng@oppo.com>
>> ---
>>   include/linux/memcontrol.h | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
>> index 394fd0a887ae..07d08be706bf 100644
>> --- a/include/linux/memcontrol.h
>> +++ b/include/linux/memcontrol.h
>> @@ -1679,7 +1679,7 @@ static inline bool folio_matches_lruvec(struct folio *folio,
>>   	       lruvec_memcg(lruvec) == folio_memcg(folio);
>>   }
>>   
>> -/* Don't lock again iff page's lruvec locked */
>> +/* Don't lock again if page's lruvec locked */
> Not a typo. iff stands for if and only if
Allright, thank for your response.