drm/xe: select X86_PLATFORM_DEVICES when ACPI_WMI is selected

[PATCH] drm/xe: select X86_PLATFORM_DEVICES when ACPI_WMI is selected

Posted by Lu Yao 1 year, 10 months ago

ACPI_WMI is a subitem of X86_PLATFORM_DEVICES. And X86_PLATFORM_DEVICES
is not selected in the current Kconfig, and may cause Kconfig warnings:

WARNING: unmet direct dependencies detected for ACPI_WMI
  Depends on [n]: X86_PLATFORM_DEVICES [=n] && ACPI [=y]
  Selected by [m]:
  - DRM_XE [=m] && HAS_IOMEM [=y] && DRM [=m] && PCI [=y] && MMU [=y] &&
    (m && MODULES [=y] || y && KUNIT [=y]=y) && X86 [=y] && ACPI [=y]

Signed-off-by: Lu Yao <yaolu@kylinos.cn>
---
 drivers/gpu/drm/xe/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig
index 1a556d087e63..f483e69a5d0f 100644
--- a/drivers/gpu/drm/xe/Kconfig
+++ b/drivers/gpu/drm/xe/Kconfig
@@ -26,6 +26,7 @@ config DRM_XE
 	select INPUT if ACPI
 	select ACPI_VIDEO if X86 && ACPI
 	select ACPI_BUTTON if ACPI
+	select X86_PLATFORM_DEVICES if X86 && ACPI
 	select ACPI_WMI if X86 && ACPI
 	select SYNC_FILE
 	select IOSF_MBI
-- 
2.25.1

Re: [PATCH] drm/xe: select X86_PLATFORM_DEVICES when ACPI_WMI is selected

Posted by Lucas De Marchi 1 year, 10 months ago

On Mon, Apr 15, 2024 at 10:52:15AM GMT, Lu Yao wrote:
>ACPI_WMI is a subitem of X86_PLATFORM_DEVICES. And X86_PLATFORM_DEVICES
>is not selected in the current Kconfig, and may cause Kconfig warnings:
>
>WARNING: unmet direct dependencies detected for ACPI_WMI
>  Depends on [n]: X86_PLATFORM_DEVICES [=n] && ACPI [=y]
>  Selected by [m]:
>  - DRM_XE [=m] && HAS_IOMEM [=y] && DRM [=m] && PCI [=y] && MMU [=y] &&
>    (m && MODULES [=y] || y && KUNIT [=y]=y) && X86 [=y] && ACPI [=y]
>
>Signed-off-by: Lu Yao <yaolu@kylinos.cn>


Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>

and pushed to drm-xe-next, thanks.

Lucas De Marchi

>---
> drivers/gpu/drm/xe/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig
>index 1a556d087e63..f483e69a5d0f 100644
>--- a/drivers/gpu/drm/xe/Kconfig
>+++ b/drivers/gpu/drm/xe/Kconfig
>@@ -26,6 +26,7 @@ config DRM_XE
> 	select INPUT if ACPI
> 	select ACPI_VIDEO if X86 && ACPI
> 	select ACPI_BUTTON if ACPI
>+	select X86_PLATFORM_DEVICES if X86 && ACPI
> 	select ACPI_WMI if X86 && ACPI
> 	select SYNC_FILE
> 	select IOSF_MBI
>-- 
>2.25.1
>