[PATCH] bcachefs: remove unneeded semicolon

Jiapeng Chong posted 1 patch 1 year, 10 months ago
There is a newer version of this series
fs/bcachefs/super.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] bcachefs: remove unneeded semicolon
Posted by Jiapeng Chong 1 year, 10 months ago
No functional modification involved.

./fs/bcachefs/super.c:1128:59-60: Unneeded semicolon.
./fs/bcachefs/super.c:1133:59-60: Unneeded semicolon.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8755
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 fs/bcachefs/super.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/bcachefs/super.c b/fs/bcachefs/super.c
index 8daf80a38d60..234f19ea8f30 100644
--- a/fs/bcachefs/super.c
+++ b/fs/bcachefs/super.c
@@ -1125,12 +1125,12 @@ static int bch2_dev_in_fs(struct bch_sb_handle *fs,
 
 		prt_bdevname(&buf, fs->bdev);
 		prt_char(&buf, ' ');
-		bch2_prt_datetime(&buf, le64_to_cpu(fs->sb->write_time));;
+		bch2_prt_datetime(&buf, le64_to_cpu(fs->sb->write_time));
 		prt_newline(&buf);
 
 		prt_bdevname(&buf, sb->bdev);
 		prt_char(&buf, ' ');
-		bch2_prt_datetime(&buf, le64_to_cpu(sb->sb->write_time));;
+		bch2_prt_datetime(&buf, le64_to_cpu(sb->sb->write_time));
 		prt_newline(&buf);
 
 		if (!opts->no_splitbrain_check)
-- 
2.20.1.7.g153144c
Re: [PATCH] bcachefs: remove unneeded semicolon
Posted by Hongbo Li 1 year, 10 months ago
I remember other people also submit this likely patch:

https://lore.kernel.org/linux-bcachefs/20240103010720.39784-1-yang.lee@linux.alibaba.com/

https://lore.kernel.org/linux-bcachefs/20240103095942.3982021-1-lihongbo22@huawei.com/

On 2024/4/15 10:35, Jiapeng Chong wrote:
> No functional modification involved.
> 
> ./fs/bcachefs/super.c:1128:59-60: Unneeded semicolon.
> ./fs/bcachefs/super.c:1133:59-60: Unneeded semicolon.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8755
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>   fs/bcachefs/super.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/bcachefs/super.c b/fs/bcachefs/super.c
> index 8daf80a38d60..234f19ea8f30 100644
> --- a/fs/bcachefs/super.c
> +++ b/fs/bcachefs/super.c
> @@ -1125,12 +1125,12 @@ static int bch2_dev_in_fs(struct bch_sb_handle *fs,
>   
>   		prt_bdevname(&buf, fs->bdev);
>   		prt_char(&buf, ' ');
> -		bch2_prt_datetime(&buf, le64_to_cpu(fs->sb->write_time));;
> +		bch2_prt_datetime(&buf, le64_to_cpu(fs->sb->write_time));
>   		prt_newline(&buf);
>   
>   		prt_bdevname(&buf, sb->bdev);
>   		prt_char(&buf, ' ');
> -		bch2_prt_datetime(&buf, le64_to_cpu(sb->sb->write_time));;
> +		bch2_prt_datetime(&buf, le64_to_cpu(sb->sb->write_time));
>   		prt_newline(&buf);
>   
>   		if (!opts->no_splitbrain_check)
Re: [PATCH] bcachefs: remove unneeded semicolon
Posted by Hongbo Li 1 year, 10 months ago
Maybe it is not enough, you can use "grep -rn ');;' fs/bcachefs/" to 
find out all the same format.

On 2024/4/15 10:35, Jiapeng Chong wrote:
> No functional modification involved.
> 
> ./fs/bcachefs/super.c:1128:59-60: Unneeded semicolon.
> ./fs/bcachefs/super.c:1133:59-60: Unneeded semicolon.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8755
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>   fs/bcachefs/super.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/bcachefs/super.c b/fs/bcachefs/super.c
> index 8daf80a38d60..234f19ea8f30 100644
> --- a/fs/bcachefs/super.c
> +++ b/fs/bcachefs/super.c
> @@ -1125,12 +1125,12 @@ static int bch2_dev_in_fs(struct bch_sb_handle *fs,
>   
>   		prt_bdevname(&buf, fs->bdev);
>   		prt_char(&buf, ' ');
> -		bch2_prt_datetime(&buf, le64_to_cpu(fs->sb->write_time));;
> +		bch2_prt_datetime(&buf, le64_to_cpu(fs->sb->write_time));
>   		prt_newline(&buf);
>   
>   		prt_bdevname(&buf, sb->bdev);
>   		prt_char(&buf, ' ');
> -		bch2_prt_datetime(&buf, le64_to_cpu(sb->sb->write_time));;
> +		bch2_prt_datetime(&buf, le64_to_cpu(sb->sb->write_time));
>   		prt_newline(&buf);
>   
>   		if (!opts->no_splitbrain_check)