[PATCH 01/14] ASoC: SOF: debug: Constify local snd_sof_dsp_ops

Krzysztof Kozlowski posted 14 patches 5 months, 1 week ago
There is a newer version of this series
[PATCH 01/14] ASoC: SOF: debug: Constify local snd_sof_dsp_ops
Posted by Krzysztof Kozlowski 5 months, 1 week ago
Constify the pointer to 'struct snd_sof_dsp_ops' to annotate that
functioon does not modify pointed data.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 sound/soc/sof/debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/sof/debug.c b/sound/soc/sof/debug.c
index cf282c8b18af..884d85770426 100644
--- a/sound/soc/sof/debug.c
+++ b/sound/soc/sof/debug.c
@@ -311,8 +311,8 @@ EXPORT_SYMBOL_GPL(snd_sof_dbg_memory_info_init);
 
 int snd_sof_dbg_init(struct snd_sof_dev *sdev)
 {
+	const struct snd_sof_dsp_ops *ops = sof_ops(sdev);
 	struct snd_sof_pdata *plat_data = sdev->pdata;
-	struct snd_sof_dsp_ops *ops = sof_ops(sdev);
 	const struct snd_sof_debugfs_map *map;
 	struct dentry *fw_profile;
 	int i;

-- 
2.34.1
Re: [PATCH 01/14] ASoC: SOF: debug: Constify local snd_sof_dsp_ops
Posted by Mark Brown 4 months, 3 weeks ago
On Sun, Apr 14, 2024 at 08:47:26PM +0200, Krzysztof Kozlowski wrote:
> Constify the pointer to 'struct snd_sof_dsp_ops' to annotate that
> functioon does not modify pointed data.

This doesn't apply against current code, please check and resend.
Re: [PATCH 01/14] ASoC: SOF: debug: Constify local snd_sof_dsp_ops
Posted by Krzysztof Kozlowski 4 months, 3 weeks ago
On 26/04/2024 04:09, Mark Brown wrote:
> On Sun, Apr 14, 2024 at 08:47:26PM +0200, Krzysztof Kozlowski wrote:
>> Constify the pointer to 'struct snd_sof_dsp_ops' to annotate that
>> functioon does not modify pointed data.
> 
> This doesn't apply against current code, please check and resend.

Maybe I am basing on wrong tree. I applied now on for-next of your
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/ and
b4 did not complain - no hunk rejects.

I will resend based on that tree, but I expect same result. Let me know
if I should use different tree.


Best regards,
Krzysztof
Re: [PATCH 01/14] ASoC: SOF: debug: Constify local snd_sof_dsp_ops
Posted by Krzysztof Kozlowski 4 months, 3 weeks ago
On 26/04/2024 09:58, Krzysztof Kozlowski wrote:
> On 26/04/2024 04:09, Mark Brown wrote:
>> On Sun, Apr 14, 2024 at 08:47:26PM +0200, Krzysztof Kozlowski wrote:
>>> Constify the pointer to 'struct snd_sof_dsp_ops' to annotate that
>>> functioon does not modify pointed data.
>>
>> This doesn't apply against current code, please check and resend.
> 
> Maybe I am basing on wrong tree. I applied now on for-next of your
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/ and
> b4 did not complain - no hunk rejects.
> 
> I will resend based on that tree, but I expect same result. Let me know
> if I should use different tree.

Never mind, my bad, the base commit was not public, but a commit from my
development tree, so b4 properly figured out any conflicts transparently
in my case.

Best regards,
Krzysztof