[PATCH 2/4] ARM: dts: BCM5301X: provide address for SoC MACs on ASUS RT-AC3100 & AC88U

Arınç ÜNAL via B4 Relay posted 4 patches 1 year, 10 months ago
[PATCH 2/4] ARM: dts: BCM5301X: provide address for SoC MACs on ASUS RT-AC3100 & AC88U
Posted by Arınç ÜNAL via B4 Relay 1 year, 10 months ago
From: Arınç ÜNAL <arinc.unal@arinc9.com>

Do not leave the providing of a MAC address for an SoC MAC to a driver.
Describe it on the bindings. Provide a distinct MAC address for each SoC
MAC.

Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
---
 arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac3100.dts | 13 ++++++++++++-
 arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac88u.dts  |  8 +++++++-
 2 files changed, 19 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac3100.dts b/arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac3100.dts
index 5f089307cd8c..1655ac95769c 100644
--- a/arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac3100.dts
+++ b/arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac3100.dts
@@ -13,11 +13,22 @@ / {
 
 	nvram@1c080000 {
 		et0macaddr: et0macaddr {
+			#nvmem-cell-cells = <1>;
 		};
 	};
 };
 
 &gmac0 {
-	nvmem-cells = <&et0macaddr>;
+	nvmem-cells = <&et0macaddr 0>;
+	nvmem-cell-names = "mac-address";
+};
+
+&gmac1 {
+	nvmem-cells = <&et0macaddr 1>;
+	nvmem-cell-names = "mac-address";
+};
+
+&gmac2 {
+	nvmem-cells = <&et0macaddr 2>;
 	nvmem-cell-names = "mac-address";
 };
diff --git a/arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac88u.dts b/arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac88u.dts
index fd344b55087e..c78f0c7b137d 100644
--- a/arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac88u.dts
+++ b/arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac88u.dts
@@ -13,6 +13,7 @@ / {
 
 	nvram@1c080000 {
 		et1macaddr: et1macaddr {
+			#nvmem-cell-cells = <1>;
 		};
 	};
 
@@ -117,6 +118,11 @@ &gmac0 {
 };
 
 &gmac1 {
-	nvmem-cells = <&et1macaddr>;
+	nvmem-cells = <&et1macaddr 0>;
+	nvmem-cell-names = "mac-address";
+};
+
+&gmac2 {
+	nvmem-cells = <&et1macaddr 1>;
 	nvmem-cell-names = "mac-address";
 };

-- 
2.40.1


Re: [PATCH 2/4] ARM: dts: BCM5301X: provide address for SoC MACs on ASUS RT-AC3100 & AC88U
Posted by Florian Fainelli 1 year, 9 months ago
From: Florian Fainelli <f.fainelli@gmail.com>

On Sun, 14 Apr 2024 20:01:22 +0300, Arınç ÜNAL via B4 Relay <devnull+arinc.unal.arinc9.com@kernel.org> wrote:
> From: Arınç ÜNAL <arinc.unal@arinc9.com>
> 
> Do not leave the providing of a MAC address for an SoC MAC to a driver.
> Describe it on the bindings. Provide a distinct MAC address for each SoC
> MAC.
> 
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> ---

Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks!
--
Florian