rust: helpers: Fix grammar in comment

[PATCH] rust: helpers: Fix grammar in comment

Posted by Thorsten Blum 1 year, 10 months ago

s/directly the bindings/the bindings directly/

Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
---
 rust/helpers.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rust/helpers.c b/rust/helpers.c
index 70e59efd92bc..4c8b7b92a4f4 100644
--- a/rust/helpers.c
+++ b/rust/helpers.c
@@ -4,7 +4,7 @@
  * cannot be called either. This file explicitly creates functions ("helpers")
  * that wrap those so that they can be called from Rust.
  *
- * Even though Rust kernel modules should never use directly the bindings, some
+ * Even though Rust kernel modules should never use the bindings directly, some
  * of these helpers need to be exported because Rust generics and inlined
  * functions may not get their code generated in the crate where they are
  * defined. Other helpers, called from non-inline functions, may not be
-- 
2.44.0

Re: [PATCH] rust: helpers: Fix grammar in comment

Posted by Miguel Ojeda 1 year, 9 months ago

On Thu, Apr 11, 2024 at 10:55 PM Thorsten Blum <thorsten.blum@toblux.com> wrote:
>
> s/directly the bindings/the bindings directly/
>
> Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>

Applied to `rust-next` -- thanks everyone!

Cheers,
Miguel

Re: [PATCH] rust: helpers: Fix grammar in comment

Posted by Trevor Gross 1 year, 9 months ago

On Thu, Apr 11, 2024 at 4:55 PM Thorsten Blum <thorsten.blum@toblux.com> wrote:
>
> s/directly the bindings/the bindings directly/
>
> Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>

Reviewed-by: Trevor Gross <tmgross@umich.edu>

Re: [PATCH] rust: helpers: Fix grammar in comment

Posted by Alice Ryhl 1 year, 10 months ago

On Thu, Apr 11, 2024 at 10:55 PM Thorsten Blum <thorsten.blum@toblux.com> wrote:
>
> s/directly the bindings/the bindings directly/
>
> Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
> ---
>  rust/helpers.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rust/helpers.c b/rust/helpers.c
> index 70e59efd92bc..4c8b7b92a4f4 100644
> --- a/rust/helpers.c
> +++ b/rust/helpers.c
> @@ -4,7 +4,7 @@
>   * cannot be called either. This file explicitly creates functions ("helpers")
>   * that wrap those so that they can be called from Rust.
>   *
> - * Even though Rust kernel modules should never use directly the bindings, some
> + * Even though Rust kernel modules should never use the bindings directly, some
>   * of these helpers need to be exported because Rust generics and inlined
>   * functions may not get their code generated in the crate where they are
>   * defined. Other helpers, called from non-inline functions, may not be

Reviewed-by: Alice Ryhl <aliceryhl@google.com>