media: dt-bindings: media: add access-controllers to STM32MP25 video codecs

[PATCH] media: dt-bindings: media: add access-controllers to STM32MP25 video codecs

Posted by Hugues Fruchet 1 year, 10 months ago

access-controllers is an optional property that allows a peripheral to
refer to one or more domain access controller(s).

Signed-off-by: Hugues Fruchet <hugues.fruchet@foss.st.com>
---
 .../devicetree/bindings/media/st,stm32mp25-video-codec.yaml   | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/media/st,stm32mp25-video-codec.yaml b/Documentation/devicetree/bindings/media/st,stm32mp25-video-codec.yaml
index b8611bc8756c..73726c65cfb9 100644
--- a/Documentation/devicetree/bindings/media/st,stm32mp25-video-codec.yaml
+++ b/Documentation/devicetree/bindings/media/st,stm32mp25-video-codec.yaml
@@ -30,6 +30,10 @@ properties:
   clocks:
     maxItems: 1
 
+  access-controllers:
+    minItems: 1
+    maxItems: 2
+
 required:
   - compatible
   - reg
-- 
2.25.1

Re: [PATCH] media: dt-bindings: media: add access-controllers to STM32MP25 video codecs

Posted by Rob Herring 1 year, 10 months ago

On Wed, 10 Apr 2024 16:42:22 +0200, Hugues Fruchet wrote:
> access-controllers is an optional property that allows a peripheral to
> refer to one or more domain access controller(s).
> 
> Signed-off-by: Hugues Fruchet <hugues.fruchet@foss.st.com>
> ---
>  .../devicetree/bindings/media/st,stm32mp25-video-codec.yaml   | 4 ++++
>  1 file changed, 4 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>

Re: [PATCH] media: dt-bindings: media: add access-controllers to STM32MP25 video codecs

Posted by Rob Herring 1 year, 10 months ago

On Wed, 10 Apr 2024 16:42:22 +0200, Hugues Fruchet wrote:
> access-controllers is an optional property that allows a peripheral to
> refer to one or more domain access controller(s).
> 
> Signed-off-by: Hugues Fruchet <hugues.fruchet@foss.st.com>
> ---
>  .../devicetree/bindings/media/st,stm32mp25-video-codec.yaml   | 4 ++++
>  1 file changed, 4 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/st,stm32mp25-video-codec.yaml: access-controllers: missing type definition

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240410144222.714172-1-hugues.fruchet@foss.st.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

Re: [PATCH] media: dt-bindings: media: add access-controllers to STM32MP25 video codecs

Posted by Alexandre TORGUE 1 year, 10 months ago

Hi Rob

On 4/10/24 18:31, Rob Herring wrote:
> 
> On Wed, 10 Apr 2024 16:42:22 +0200, Hugues Fruchet wrote:
>> access-controllers is an optional property that allows a peripheral to
>> refer to one or more domain access controller(s).
>>
>> Signed-off-by: Hugues Fruchet <hugues.fruchet@foss.st.com>
>> ---
>>   .../devicetree/bindings/media/st,stm32mp25-video-codec.yaml   | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/st,stm32mp25-video-codec.yaml: access-controllers: missing type definition
> 
> doc reference errors (make refcheckdocs):
> 
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240410144222.714172-1-hugues.fruchet@foss.st.com
> 
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
> 

This patch depends on STM32 firewall bus YAML which has been recently 
added in stm32-next branch. I tested it on top of stm32-next and there 
is no YAML issues (neiter dt-bindings checks nor dtbs_check). If you 
agree to ack it, I could merge it on stm32-next.

Thanks
Alex

Re: [PATCH] media: dt-bindings: media: add access-controllers to STM32MP25 video codecs

Posted by Krzysztof Kozlowski 1 year, 10 months ago

On 11/04/2024 14:57, Alexandre TORGUE wrote:
> Hi Rob
> 
> On 4/10/24 18:31, Rob Herring wrote:
>>
>> On Wed, 10 Apr 2024 16:42:22 +0200, Hugues Fruchet wrote:
>>> access-controllers is an optional property that allows a peripheral to
>>> refer to one or more domain access controller(s).
>>>
>>> Signed-off-by: Hugues Fruchet <hugues.fruchet@foss.st.com>
>>> ---
>>>   .../devicetree/bindings/media/st,stm32mp25-video-codec.yaml   | 4 ++++
>>>   1 file changed, 4 insertions(+)
>>>
>>
>> My bot found errors running 'make dt_binding_check' on your patch:
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/st,stm32mp25-video-codec.yaml: access-controllers: missing type definition
>>
>> doc reference errors (make refcheckdocs):
>>
>> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240410144222.714172-1-hugues.fruchet@foss.st.com
>>
>> The base for the series is generally the latest rc1. A different dependency
>> should be noted in *this* patch.
>>
>> If you already ran 'make dt_binding_check' and didn't see the above
>> error(s), then make sure 'yamllint' is installed and dt-schema is up to
>> date:
>>
>> pip3 install dtschema --upgrade
>>
>> Please check and re-submit after running the above command yourself. Note
>> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
>> your schema. However, it must be unset to test all examples with your schema.
>>
> 
> This patch depends on STM32 firewall bus YAML which has been recently 
> added in stm32-next branch. I tested it on top of stm32-next and there 

Where is it expressed in the patch? How maintainers are supposed to know
if this patch should be applied or not?

> is no YAML issues (neiter dt-bindings checks nor dtbs_check). If you 
> agree to ack it, I could merge it on stm32-next.

Drop redundant second "media" from the subject. One media is enough.

With the subject fixed:

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof