[PATCH 08/18] i2c: ismt: remove printout on handled timeouts

Wolfram Sang posted 18 patches 1 year, 10 months ago
[PATCH 08/18] i2c: ismt: remove printout on handled timeouts
Posted by Wolfram Sang 1 year, 10 months ago
I2C and SMBus timeouts are not something the user needs to be informed
about on controller level. The client driver may know if that really is
a problem and give more detailed information to the user. The controller
should just pass this information upwards. Remove the printout.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/i2c/busses/i2c-ismt.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-ismt.c
index c74985d77b0e..655b5d851c48 100644
--- a/drivers/i2c/busses/i2c-ismt.c
+++ b/drivers/i2c/busses/i2c-ismt.c
@@ -623,7 +623,6 @@ static int ismt_access(struct i2c_adapter *adap, u16 addr,
 		dma_unmap_single(dev, dma_addr, dma_size, dma_direction);
 
 	if (unlikely(!time_left)) {
-		dev_err(dev, "completion wait timed out\n");
 		ret = -ETIMEDOUT;
 		goto out;
 	}
-- 
2.43.0
Re: [PATCH 08/18] i2c: ismt: remove printout on handled timeouts
Posted by Andy Shevchenko 1 year, 9 months ago
Wed, Apr 10, 2024 at 01:24:22PM +0200, Wolfram Sang kirjoitti:
> I2C and SMBus timeouts are not something the user needs to be informed
> about on controller level. The client driver may know if that really is
> a problem and give more detailed information to the user. The controller
> should just pass this information upwards. Remove the printout.

Neither this.

-- 
With Best Regards,
Andy Shevchenko