[PATCH v1 1/2] auxdisplay: charlcd: Add missing MODULE_DESCRIPTION()

Andy Shevchenko posted 2 patches 1 year, 10 months ago
[PATCH v1 1/2] auxdisplay: charlcd: Add missing MODULE_DESCRIPTION()
Posted by Andy Shevchenko 1 year, 10 months ago
The modpost script is not happy

  WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/auxdisplay/charlcd.o

because there is a missing module description.

Add it to the module.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/auxdisplay/charlcd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/auxdisplay/charlcd.c b/drivers/auxdisplay/charlcd.c
index 6d309e4971b6..5df019720c56 100644
--- a/drivers/auxdisplay/charlcd.c
+++ b/drivers/auxdisplay/charlcd.c
@@ -678,4 +678,5 @@ int charlcd_unregister(struct charlcd *lcd)
 }
 EXPORT_SYMBOL_GPL(charlcd_unregister);
 
+MODULE_DESCRIPTION("Character LCD core support");
 MODULE_LICENSE("GPL");
-- 
2.43.0.rc1.1.gbec44491f096
Re: [PATCH v1 1/2] auxdisplay: charlcd: Add missing MODULE_DESCRIPTION()
Posted by Geert Uytterhoeven 1 year, 10 months ago
On Tue, Apr 9, 2024 at 6:15 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> The modpost script is not happy
>
>   WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/auxdisplay/charlcd.o
>
> because there is a missing module description.
>
> Add it to the module.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Re: [PATCH v1 1/2] auxdisplay: charlcd: Add missing MODULE_DESCRIPTION()
Posted by Andy Shevchenko 1 year, 10 months ago
On Thu, Apr 11, 2024 at 09:31:32AM +0200, Geert Uytterhoeven wrote:
> On Tue, Apr 9, 2024 at 6:15 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > The modpost script is not happy
> >
> >   WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/auxdisplay/charlcd.o
> >
> > because there is a missing module description.
> >
> > Add it to the module.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>

Pushed to my review and testing queue, thanks!

-- 
With Best Regards,
Andy Shevchenko