[PATCH v1 0/4] Add shellcheck beyond perf/tests

Ian Rogers posted 4 patches 1 year, 10 months ago
tools/perf/Build                              | 14 +++++++++++
tools/perf/arch/x86/Build                     | 14 +++++++++++
tools/perf/arch/x86/tests/Build               | 14 +++++++++++
tools/perf/arch/x86/tests/gen-insn-x86-dat.sh |  2 +-
tools/perf/perf-archive.sh                    |  2 +-
tools/perf/perf-completion.sh                 | 23 +++++++++++++------
tools/perf/trace/beauty/Build                 | 14 +++++++++++
tools/perf/trace/beauty/arch_errno_names.sh   |  8 ++++---
tools/perf/util/Build                         | 14 +++++++++++
9 files changed, 93 insertions(+), 12 deletions(-)
[PATCH v1 0/4] Add shellcheck beyond perf/tests
Posted by Ian Rogers 1 year, 10 months ago
Add shellcheck to other locations of shell scripts, not just
tools/perf/tests. Fix issues detected by shellcheck.

Ian Rogers (4):
  perf build: Add shellcheck to tools/perf scripts
  perf arch x86: Add shellcheck to build
  perf util: Add shellcheck to generate-cmdlist.sh
  perf trace beauty: Add shellcheck to scripts

 tools/perf/Build                              | 14 +++++++++++
 tools/perf/arch/x86/Build                     | 14 +++++++++++
 tools/perf/arch/x86/tests/Build               | 14 +++++++++++
 tools/perf/arch/x86/tests/gen-insn-x86-dat.sh |  2 +-
 tools/perf/perf-archive.sh                    |  2 +-
 tools/perf/perf-completion.sh                 | 23 +++++++++++++------
 tools/perf/trace/beauty/Build                 | 14 +++++++++++
 tools/perf/trace/beauty/arch_errno_names.sh   |  8 ++++---
 tools/perf/util/Build                         | 14 +++++++++++
 9 files changed, 93 insertions(+), 12 deletions(-)

-- 
2.44.0.478.gd926399ef9-goog
Re: [PATCH v1 0/4] Add shellcheck beyond perf/tests
Posted by James Clark 1 year, 10 months ago

On 09/04/2024 03:32, Ian Rogers wrote:
> Add shellcheck to other locations of shell scripts, not just
> tools/perf/tests. Fix issues detected by shellcheck.
> 
> Ian Rogers (4):
>   perf build: Add shellcheck to tools/perf scripts
>   perf arch x86: Add shellcheck to build
>   perf util: Add shellcheck to generate-cmdlist.sh
>   perf trace beauty: Add shellcheck to scripts
> 
>  tools/perf/Build                              | 14 +++++++++++
>  tools/perf/arch/x86/Build                     | 14 +++++++++++
>  tools/perf/arch/x86/tests/Build               | 14 +++++++++++
>  tools/perf/arch/x86/tests/gen-insn-x86-dat.sh |  2 +-
>  tools/perf/perf-archive.sh                    |  2 +-
>  tools/perf/perf-completion.sh                 | 23 +++++++++++++------
>  tools/perf/trace/beauty/Build                 | 14 +++++++++++
>  tools/perf/trace/beauty/arch_errno_names.sh   |  8 ++++---
>  tools/perf/util/Build                         | 14 +++++++++++
>  9 files changed, 93 insertions(+), 12 deletions(-)
> 

Reviewed-by: James Clark <james.clark@arm.com>
Re: [PATCH v1 0/4] Add shellcheck beyond perf/tests
Posted by Arnaldo Carvalho de Melo 1 year, 10 months ago
On Tue, Apr 09, 2024 at 11:02:58AM +0100, James Clark wrote:
> 
> 
> On 09/04/2024 03:32, Ian Rogers wrote:
> > Add shellcheck to other locations of shell scripts, not just
> > tools/perf/tests. Fix issues detected by shellcheck.
> > 
> > Ian Rogers (4):
> >   perf build: Add shellcheck to tools/perf scripts
> >   perf arch x86: Add shellcheck to build
> >   perf util: Add shellcheck to generate-cmdlist.sh
> >   perf trace beauty: Add shellcheck to scripts
> > 
> >  tools/perf/Build                              | 14 +++++++++++
> >  tools/perf/arch/x86/Build                     | 14 +++++++++++
> >  tools/perf/arch/x86/tests/Build               | 14 +++++++++++
> >  tools/perf/arch/x86/tests/gen-insn-x86-dat.sh |  2 +-
> >  tools/perf/perf-archive.sh                    |  2 +-
> >  tools/perf/perf-completion.sh                 | 23 +++++++++++++------
> >  tools/perf/trace/beauty/Build                 | 14 +++++++++++
> >  tools/perf/trace/beauty/arch_errno_names.sh   |  8 ++++---
> >  tools/perf/util/Build                         | 14 +++++++++++
> >  9 files changed, 93 insertions(+), 12 deletions(-)
> > 
> 
> Reviewed-by: James Clark <james.clark@arm.com>

Thanks, applied to perf-tools-next.

- Arnaldo