[PATCH v2] Bluetooth: btintel: Add devices to HCI_QUIRK_BROKEN_LE_CODED

Werner Sembach posted 1 patch 1 year, 10 months ago
drivers/bluetooth/btintel.c | 3 +++
1 file changed, 3 insertions(+)
[PATCH v2] Bluetooth: btintel: Add devices to HCI_QUIRK_BROKEN_LE_CODED
Posted by Werner Sembach 1 year, 10 months ago
From: Christoffer Sandberg <cs@tuxedo.de>

For HW variants 0x17, 0x18 and 0x19 LE Coded PHY causes scan and
connection issues when enabled. This patch disables it through
the existing quirk.

Signed-off-by: Christoffer Sandberg <cs@tuxedo.de>
Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
Cc: <stable@vger.kernel.org>
---
 drivers/bluetooth/btintel.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
index cdc5c08824a0a..9f9c4696d082a 100644
--- a/drivers/bluetooth/btintel.c
+++ b/drivers/bluetooth/btintel.c
@@ -2881,6 +2881,9 @@ static int btintel_setup_combined(struct hci_dev *hdev)
 	case 0x17:
 	case 0x18:
 	case 0x19:
+		/* 0x17, 0x18 and 0x19 have issues when LE Coded PHY is enabled */
+		set_bit(HCI_QUIRK_BROKEN_LE_CODED, &hdev->quirks);
+		fallthrough;
 	case 0x1b:
 	case 0x1c:
 		/* Display version information of TLV type */
-- 
2.34.1
Re: [PATCH v2] Bluetooth: btintel: Add devices to HCI_QUIRK_BROKEN_LE_CODED
Posted by Luiz Augusto von Dentz 1 year, 10 months ago
Hi Werner,

On Mon, Apr 8, 2024 at 8:35 AM Werner Sembach <wse@tuxedocomputers.com> wrote:
>
> From: Christoffer Sandberg <cs@tuxedo.de>
>
> For HW variants 0x17, 0x18 and 0x19 LE Coded PHY causes scan and
> connection issues when enabled. This patch disables it through
> the existing quirk.

Perhaps the following could be a proper fix for that:

https://patchwork.kernel.org/project/bluetooth/patch/20240405204037.3451091-1-luiz.dentz@gmail.com/

If you manage to test it please reply and add Tested-by to its thread.

> Signed-off-by: Christoffer Sandberg <cs@tuxedo.de>
> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
> Cc: <stable@vger.kernel.org>
> ---
>  drivers/bluetooth/btintel.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
> index cdc5c08824a0a..9f9c4696d082a 100644
> --- a/drivers/bluetooth/btintel.c
> +++ b/drivers/bluetooth/btintel.c
> @@ -2881,6 +2881,9 @@ static int btintel_setup_combined(struct hci_dev *hdev)
>         case 0x17:
>         case 0x18:
>         case 0x19:
> +               /* 0x17, 0x18 and 0x19 have issues when LE Coded PHY is enabled */
> +               set_bit(HCI_QUIRK_BROKEN_LE_CODED, &hdev->quirks);
> +               fallthrough;
>         case 0x1b:
>         case 0x1c:
>                 /* Display version information of TLV type */
> --
> 2.34.1
>


-- 
Luiz Augusto von Dentz
Re: [PATCH v2] Bluetooth: btintel: Add devices to HCI_QUIRK_BROKEN_LE_CODED
Posted by Werner Sembach 1 year, 6 months ago
> Hi Werner,
>
> On Mon, Apr 8, 2024 at 8:35=E2=80=AFAM Werner Sembach <wse@tuxedocomputers.com>  wrote:
>
> > From: Christoffer Sandberg <cs@tuxedo.de>
> >
> > For HW variants 0x17, 0x18 and 0x19 LE Coded PHY causes scan and
> > connection issues when enabled. This patch disables it through
> > the existing quirk.
>
> Perhaps the following could be a proper fix for that:
>
> https://patchwork.kernel.org/project/bluetooth/patch/20240405204037.3451091-1-luiz.dentz@gmail.com/
> 
> If you manage to test it please reply and add Tested-by to its thread.

Sorry I never answered, but the problem seems to be gone with the current kernel version, don't know which patch fixed it exactly though.