perf annotate-data: small random fixes and updates

[PATCH 0/4] perf annotate-data: small random fixes and updates

Posted by Namhyung Kim 1 year, 10 months ago

Hello,

I found some problems in the data type profiling with perf annotate.
The patch 1 should go to perf-tools and others can go to perf-tools-next.

Thanks,
Namhyung


Namhyung Kim (4):
  perf annotate: Make sure to call symbol__annotate2() in TUI
  perf annotate-data: Fix global variable lookup
  perf annotate-data: Do not delete non-asm lines
  perf annotate: Get rid of symbol__ensure_annotate()

 tools/perf/ui/browsers/annotate.c |   2 +-
 tools/perf/util/annotate-data.c   |  10 ++-
 tools/perf/util/annotate.c        | 104 ++++++++++++++++++++----------
 3 files changed, 80 insertions(+), 36 deletions(-)


base-commit: b6347cb5e04e9c1d17342ab46e2ace2d448de727
-- 
2.44.0.478.gd926399ef9-goog

Re: [PATCH 0/4] perf annotate-data: small random fixes and updates

Posted by Ian Rogers 1 year, 10 months ago

On Fri, Apr 5, 2024 at 2:18 PM Namhyung Kim <namhyung@kernel.org> wrote:
>
> Hello,
>
> I found some problems in the data type profiling with perf annotate.
> The patch 1 should go to perf-tools and others can go to perf-tools-next.
>
> Thanks,
> Namhyung
>
>
> Namhyung Kim (4):
>   perf annotate: Make sure to call symbol__annotate2() in TUI
>   perf annotate-data: Fix global variable lookup
>   perf annotate-data: Do not delete non-asm lines
>   perf annotate: Get rid of symbol__ensure_annotate()

Reviewed-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

>  tools/perf/ui/browsers/annotate.c |   2 +-
>  tools/perf/util/annotate-data.c   |  10 ++-
>  tools/perf/util/annotate.c        | 104 ++++++++++++++++++++----------
>  3 files changed, 80 insertions(+), 36 deletions(-)
>
>
> base-commit: b6347cb5e04e9c1d17342ab46e2ace2d448de727
> --
> 2.44.0.478.gd926399ef9-goog
>

Re: [PATCH 0/4] perf annotate-data: small random fixes and updates

Posted by Arnaldo Carvalho de Melo 1 year, 10 months ago

On Fri, Apr 05, 2024 at 05:02:20PM -0700, Ian Rogers wrote:
> On Fri, Apr 5, 2024 at 2:18 PM Namhyung Kim <namhyung@kernel.org> wrote:
> > I found some problems in the data type profiling with perf annotate.
> > The patch 1 should go to perf-tools and others can go to perf-tools-next.

> > Namhyung Kim (4):
> >   perf annotate: Make sure to call symbol__annotate2() in TUI
> >   perf annotate-data: Fix global variable lookup
> >   perf annotate-data: Do not delete non-asm lines
> >   perf annotate: Get rid of symbol__ensure_annotate()
> 
> Reviewed-by: Ian Rogers <irogers@google.com>

Applied 2-4 to perf-tools-next,

Thanks,

- Arnaldo