[v2] soc: qcom: pmic_glink: fix client handling

[PATCH v2 0/2] soc: qcom: pmic_glink: fix client handling

Posted by Dmitry Baryshkov 1 year, 10 months ago

Fix two issues with the way the pmic_glink driver handles its clients.
First issue is mostly theoretical, while the second issue can easily be
reproduced if the drivers are built as modules.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
Changes in v2:
- Also take a lock at pmic_glink_rpmsg_callback() (Andrew Halaney)
- Link to v1: https://lore.kernel.org/r/20240402-pmic-glink-fix-clients-v1-0-885440b81c65@linaro.org

---
Dmitry Baryshkov (2):
      soc: qcom: pmic_glink: don't traverse clients list without a lock
      soc: qcom: pmic_glink: notify clients about the current state

 drivers/soc/qcom/pmic_glink.c | 9 +++++++++
 1 file changed, 9 insertions(+)
---
base-commit: a6bd6c9333397f5a0e2667d4d82fef8c970108f2
change-id: 20240402-pmic-glink-fix-clients-5df0bab3e871

Best regards,
-- 
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

Re: [PATCH v2 0/2] soc: qcom: pmic_glink: fix client handling

Posted by Bjorn Andersson 1 year, 9 months ago

On Wed, 03 Apr 2024 06:10:56 +0300, Dmitry Baryshkov wrote:
> Fix two issues with the way the pmic_glink driver handles its clients.
> First issue is mostly theoretical, while the second issue can easily be
> reproduced if the drivers are built as modules.
> 
> 

Applied, thanks!

[1/2] soc: qcom: pmic_glink: don't traverse clients list without a lock
      commit: 635ce0db89567ba62f64b79e8c6664ba3eff6516
[2/2] soc: qcom: pmic_glink: notify clients about the current state
      commit: d6cbce2cd354c9a37a558f290a8f1dfd20584f99

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH v2 0/2] soc: qcom: pmic_glink: fix client handling

Posted by Xilin Wu 1 year, 10 months ago

On 2024/4/3 11:10, Dmitry Baryshkov wrote:
> Fix two issues with the way the pmic_glink driver handles its clients.
> First issue is mostly theoretical, while the second issue can easily be
> reproduced if the drivers are built as modules.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> Changes in v2:
> - Also take a lock at pmic_glink_rpmsg_callback() (Andrew Halaney)
> - Link to v1: https://lore.kernel.org/r/20240402-pmic-glink-fix-clients-v1-0-885440b81c65@linaro.org
>
> ---
> Dmitry Baryshkov (2):
>        soc: qcom: pmic_glink: don't traverse clients list without a lock
>        soc: qcom: pmic_glink: notify clients about the current state
>
>   drivers/soc/qcom/pmic_glink.c | 9 +++++++++
>   1 file changed, 9 insertions(+)
> ---
> base-commit: a6bd6c9333397f5a0e2667d4d82fef8c970108f2
> change-id: 20240402-pmic-glink-fix-clients-5df0bab3e871
>
> Best regards,

Tested-by: Xilin Wu <wuxilin123@gmail.com> # on QCS8550 AYN Odin 2
Fixes: 
https://lore.kernel.org/all/20240311-qcom-pd-mapper-v4-0-24679cca5c24@linaro.org/


Thanks,
Xilin