[v1] ALSA: hda/tas2781: correct the register for pow calibrated data

[PATCH v1] ALSA: hda/tas2781: correct the register for pow calibrated data

Shenghao Ding posted 1 patch 1 year, 10 months ago

Diff against v2 v3
Download mbox

There is a newer version of this series

sound/pci/hda/tas2781_hda_i2c.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Expand all Fold all

[PATCH v1] ALSA: hda/tas2781: correct the register for pow calibrated data

Posted by Shenghao Ding 1 year, 10 months ago

fixed tas2781 calibrated data - pow was written into a wrong register.

Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>
---
 sound/pci/hda/tas2781_hda_i2c.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/pci/hda/tas2781_hda_i2c.c b/sound/pci/hda/tas2781_hda_i2c.c
index 48dae3339305..116821ae3cb3 100644
--- a/sound/pci/hda/tas2781_hda_i2c.c
+++ b/sound/pci/hda/tas2781_hda_i2c.c
@@ -514,10 +514,10 @@ static int tas2563_save_calibration(struct tasdevice_priv *tas_priv)
 static void tas2781_apply_calib(struct tasdevice_priv *tas_priv)
 {
 	static const unsigned char page_array[CALIB_MAX] = {
-		0x17, 0x18, 0x18, 0x0d, 0x18
+		0x17, 0x18, 0x18, 0x13, 0x18
 	};
 	static const unsigned char rgno_array[CALIB_MAX] = {
-		0x74, 0x0c, 0x14, 0x3c, 0x7c
+		0x74, 0x0c, 0x14, 0x70, 0x7c
 	};
 	unsigned char *data;
 	int i, j, rc;
-- 
2.34.1

Re: [PATCH v1] ALSA: hda/tas2781: correct the register for pow calibrated data

Posted by Andy Shevchenko 1 year, 10 months ago

On Wed, Apr 03, 2024 at 07:12:59AM +0800, Shenghao Ding wrote:
> fixed tas2781 calibrated data - pow was written into a wrong register.

fixed --> Fix

Fixes tag?

> Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>

...

> +		0x17, 0x18, 0x18, 0x13, 0x18
> +		0x74, 0x0c, 0x14, 0x70, 0x7c

While at it, can you add a trailing comma?
It will help in case of extending this in the future.

-- 
With Best Regards,
Andy Shevchenko