[v1] netlink: fix typo in coalesce_reply_cb()

[PATCH ethtool-next] netlink: fix typo in coalesce_reply_cb()

Posted by gaoxingwang 1 year, 10 months ago

Add missing colon in coalesce_reply_cb()

Fixes: ec573f209dfd (netlink: settings: add netlink support for coalesce tx aggr params)
Signed-off-by: Gao Xingwang <gaoxingwang1@huawei.com>
---
 netlink/coalesce.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/netlink/coalesce.c b/netlink/coalesce.c
index bc34d3d..bb93f9b 100644
--- a/netlink/coalesce.c
+++ b/netlink/coalesce.c
@@ -93,7 +93,7 @@ int coalesce_reply_cb(const struct nlmsghdr *nlhdr, void *data)
 		 tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_BYTES]);
 	show_u32("tx-aggr-max-frames", "tx-aggr-max-frames:\t",
 		 tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_FRAMES]);
-	show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs\t",
+	show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs:\t",
 		 tb[ETHTOOL_A_COALESCE_TX_AGGR_TIME_USECS]);
 	show_cr();
 
-- 
2.27.0

Re: [PATCH ethtool-next] netlink: fix typo in coalesce_reply_cb()

Posted by Heng Qi 1 year, 10 months ago


在 2024/4/2 下午8:16, gaoxingwang 写道:
> Add missing colon in coalesce_reply_cb()
>
> Fixes: ec573f209dfd (netlink: settings: add netlink support for coalesce tx aggr params)
> Signed-off-by: Gao Xingwang <gaoxingwang1@huawei.com>
> ---
>   netlink/coalesce.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/netlink/coalesce.c b/netlink/coalesce.c
> index bc34d3d..bb93f9b 100644
> --- a/netlink/coalesce.c
> +++ b/netlink/coalesce.c
> @@ -93,7 +93,7 @@ int coalesce_reply_cb(const struct nlmsghdr *nlhdr, void *data)
>   		 tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_BYTES]);
>   	show_u32("tx-aggr-max-frames", "tx-aggr-max-frames:\t",
>   		 tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_FRAMES]);
> -	show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs\t",
> +	show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs:\t",
>   		 tb[ETHTOOL_A_COALESCE_TX_AGGR_TIME_USECS]);
>   	show_cr();
>   

Reviewed-by: Heng Qi <hengqi@linux.alibaba.com>