Drivers init functions usually use either "ret" or "rc" naming their
return variable.

Signed-off-by: Shahar Avidar <ikobh7@gmail.com>
---
 drivers/staging/pi433/pi433_if.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index 47e0c51ffe2e..b0407d5c6be8 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -1384,7 +1384,7 @@ static struct spi_driver pi433_spi_driver = {
 
 static int __init pi433_init(void)
 {
-	int status;
+	int ret;
 
 	/*
 	 * If MAX_MSG_SIZE is smaller then FIFO_SIZE, the driver won't
@@ -1398,21 +1398,21 @@ static int __init pi433_init(void)
 	 * that will key udev/mdev to add/remove /dev nodes.
 	 * Last, register the driver which manages those device numbers.
 	 */
-	status = alloc_chrdev_region(&pi433_devt, 0, N_PI433_MINORS, "pi433");
-	if (status)
-		return status;
+	ret = alloc_chrdev_region(&pi433_devt, 0, N_PI433_MINORS, "pi433");
+	if (ret)
+		return ret;
 
-	status = class_register(&pi433_class);
-	if (status)
+	ret = class_register(&pi433_class);
+	if (ret)
 		goto unreg_chrdev;
 
-	status = spi_register_driver(&pi433_spi_driver);
-	if (status)
+	ret = spi_register_driver(&pi433_spi_driver);
+	if (ret)
 		goto unreg_class;
 
 	root_dir = debugfs_create_dir(KBUILD_MODNAME, NULL);
 	if (IS_ERR(root_dir)) {
-		status = PTR_ERR(root_dir);
+		ret = PTR_ERR(root_dir);
 		goto unreg_spi_drv;
 	}
 
@@ -1425,7 +1425,7 @@ static int __init pi433_init(void)
 unreg_chrdev:
 	unregister_chrdev(MAJOR(pi433_devt), pi433_spi_driver.driver.name);
 
-	return status;
+	return ret;
 }
 
 module_init(pi433_init);
-- 
2.34.1

On Tue, Apr 02, 2024 at 02:14:14PM +0300, Shahar Avidar wrote:
> Drivers init functions usually use either "ret" or "rc" naming their
> return variable.
> 

status is also fine.  Just leave this as-is probably.

regards,
dan carpenter

On 02/04/2024 19:50, Dan Carpenter wrote:
> On Tue, Apr 02, 2024 at 02:14:14PM +0300, Shahar Avidar wrote:
>> Drivers init functions usually use either "ret" or "rc" naming their
>> return variable.
>>
> 
> status is also fine.  Just leave this as-is probably.
> 
Patch dropped.

> regards,
> dan carpenter
> 
-- 
Regards,

Shahar