drm/etnaviv: drop driver owner assignment

[PATCH] drm/etnaviv: drop driver owner assignment

Posted by Krzysztof Kozlowski 1 year, 10 months ago

Core in platform_driver_register() already sets the .owner, so driver
does not need to.  Whatever is set here will be anyway overwritten by
main driver calling platform_driver_register().

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
index 734412aae94d..87b31cfee41d 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
@@ -1995,7 +1995,6 @@ static const struct dev_pm_ops etnaviv_gpu_pm_ops = {
 struct platform_driver etnaviv_gpu_driver = {
 	.driver = {
 		.name = "etnaviv-gpu",
-		.owner = THIS_MODULE,
 		.pm = pm_ptr(&etnaviv_gpu_pm_ops),
 		.of_match_table = etnaviv_gpu_match,
 	},
-- 
2.34.1

Re: [PATCH] drm/etnaviv: drop driver owner assignment

Posted by Christian Gmeiner 1 year, 10 months ago

>
> Core in platform_driver_register() already sets the .owner, so driver
> does not need to.  Whatever is set here will be anyway overwritten by
> main driver calling platform_driver_register().
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>

> ---
>  drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> index 734412aae94d..87b31cfee41d 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> @@ -1995,7 +1995,6 @@ static const struct dev_pm_ops etnaviv_gpu_pm_ops = {
>  struct platform_driver etnaviv_gpu_driver = {
>         .driver = {
>                 .name = "etnaviv-gpu",
> -               .owner = THIS_MODULE,
>                 .pm = pm_ptr(&etnaviv_gpu_pm_ops),
>                 .of_match_table = etnaviv_gpu_match,
>         },
> --
> 2.34.1
>


-- 
greets
--
Christian Gmeiner, MSc

https://christian-gmeiner.info/privacypolicy

Re: [PATCH] drm/etnaviv: drop driver owner assignment

Posted by Lucas Stach 1 year, 8 months ago

Am Montag, dem 01.04.2024 um 12:26 +0200 schrieb Christian Gmeiner:
> > 
> > Core in platform_driver_register() already sets the .owner, so driver
> > does not need to.  Whatever is set here will be anyway overwritten by
> > main driver calling platform_driver_register().
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>

Applied to the etnaviv/next branch.

Regards,
Lucas

> 
> > ---
> >  drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> > index 734412aae94d..87b31cfee41d 100644
> > --- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> > +++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> > @@ -1995,7 +1995,6 @@ static const struct dev_pm_ops etnaviv_gpu_pm_ops = {
> >  struct platform_driver etnaviv_gpu_driver = {
> >         .driver = {
> >                 .name = "etnaviv-gpu",
> > -               .owner = THIS_MODULE,
> >                 .pm = pm_ptr(&etnaviv_gpu_pm_ops),
> >                 .of_match_table = etnaviv_gpu_match,
> >         },
> > --
> > 2.34.1
> > 
> 
>

Re: [PATCH] drm/etnaviv: drop driver owner assignment

Posted by Krzysztof Kozlowski 1 year, 9 months ago

On 01/04/2024 12:26, Christian Gmeiner wrote:
>>
>> Core in platform_driver_register() already sets the .owner, so driver
>> does not need to.  Whatever is set here will be anyway overwritten by
>> main driver calling platform_driver_register().
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>

Thanks.

It has been almost a month. Any further comments on this patchset from
maintainers? Can anyone pick it up?

Best regards,
Krzysztof