crypto: jitter - Use kvfree_sensitive() to fix Coccinelle warning

[PATCH] crypto: jitter - Use kvfree_sensitive() to fix Coccinelle warning

Posted by Thorsten Blum 1 year, 10 months ago

Replace memzero_explicit() and kvfree() with kvfree_sensitive() to fix
the following Coccinelle/coccicheck warning reported by
kfree_sensitive.cocci:

	WARNING opportunity for kfree_sensitive/kvfree_sensitive

Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
---
 crypto/jitterentropy-kcapi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/crypto/jitterentropy-kcapi.c b/crypto/jitterentropy-kcapi.c
index 76edbf8af0ac..c24d4ff2b4a8 100644
--- a/crypto/jitterentropy-kcapi.c
+++ b/crypto/jitterentropy-kcapi.c
@@ -61,8 +61,7 @@ void *jent_kvzalloc(unsigned int len)
 
 void jent_kvzfree(void *ptr, unsigned int len)
 {
-	memzero_explicit(ptr, len);
-	kvfree(ptr);
+	kvfree_sensitive(ptr, len);
 }
 
 void *jent_zalloc(unsigned int len)
-- 
2.44.0

Re: [PATCH] crypto: jitter - Use kvfree_sensitive() to fix Coccinelle warning

Posted by Herbert Xu 1 year, 10 months ago

On Wed, Mar 27, 2024 at 11:25:09PM +0100, Thorsten Blum wrote:
> Replace memzero_explicit() and kvfree() with kvfree_sensitive() to fix
> the following Coccinelle/coccicheck warning reported by
> kfree_sensitive.cocci:
> 
> 	WARNING opportunity for kfree_sensitive/kvfree_sensitive
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
> ---
>  crypto/jitterentropy-kcapi.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt