[PATCH v5 4/7] dt-bindings: iio: accel: adxl345: Add spi-3wire

Lothar Rubusch posted 7 patches 1 year, 10 months ago
There is a newer version of this series
[PATCH v5 4/7] dt-bindings: iio: accel: adxl345: Add spi-3wire
Posted by Lothar Rubusch 1 year, 10 months ago
Add spi-3wire because the device allows to be configured for spi 3-wire
communication.

Signed-off-by: Lothar Rubusch <l.rubusch@gmail.com>
---
 Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
index 07cacc3f6..280ed479e 100644
--- a/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
+++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
@@ -32,6 +32,8 @@ properties:
 
   spi-cpol: true
 
+  spi-3wire: true
+
   interrupts:
     maxItems: 1
 
-- 
2.25.1
Re: [PATCH v5 4/7] dt-bindings: iio: accel: adxl345: Add spi-3wire
Posted by Krzysztof Kozlowski 1 year, 10 months ago
On 27/03/2024 23:03, Lothar Rubusch wrote:
> Add spi-3wire because the device allows to be configured for spi 3-wire
> communication.
> 
> Signed-off-by: Lothar Rubusch <l.rubusch@gmail.com>

I don't understand why after my last message you still ignore my
feedback, but fine. I'll ignore this patchset.

Best regards,
Krzysztof
Re: [PATCH v5 4/7] dt-bindings: iio: accel: adxl345: Add spi-3wire
Posted by Lothar Rubusch 1 year, 10 months ago
On Thu, Mar 28, 2024 at 10:22 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 27/03/2024 23:03, Lothar Rubusch wrote:
> > Add spi-3wire because the device allows to be configured for spi 3-wire
> > communication.
> >
> > Signed-off-by: Lothar Rubusch <l.rubusch@gmail.com>
>
> I don't understand why after my last message you still ignore my
> feedback, but fine. I'll ignore this patchset.
>

I'm sorry. I found it now. Please ignore my last v5. I'll repatch an
adjusted v6.

> Best regards,
> Krzysztof
>
Re: [PATCH v5 4/7] dt-bindings: iio: accel: adxl345: Add spi-3wire
Posted by Lothar Rubusch 1 year, 10 months ago
On Thu, Mar 28, 2024 at 10:22 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 27/03/2024 23:03, Lothar Rubusch wrote:
> > Add spi-3wire because the device allows to be configured for spi 3-wire
> > communication.
> >
> > Signed-off-by: Lothar Rubusch <l.rubusch@gmail.com>
>
> I don't understand why after my last message you still ignore my
> feedback, but fine. I'll ignore this patchset.

This is sad. I refrased the comment to the patch and tried to stress
more on the device instead of the driver. Wasn't this the point of
your criticism to the patch?

So, instead of answering to your last email, I posted the modified
patch as answer. I think I considered your feedback to the best of my
understanding. I'm sorry, it is certainly not my intention to ignore
you. I appreciate your direct feedback.

I'll write an answer to the last email right away.

> Best regards,
> Krzysztof
>