mmc: sdhci-pci-gli: Remove unnecessary device-dependent code

[PATCH 0/2] mmc: sdhci-pci-gli: Remove unnecessary device-dependent code

Posted by Bjorn Helgaas 1 year, 10 months ago

From: Bjorn Helgaas <bhelgaas@google.com>

Previously the driver hard-coded the config space locations of the Power
Management and the AER Capabilities and included device-specific #defines
for bits defined by the PCI spec.  This replaces those with the equivalents
from the PCI core.

This also replace hard-coded power state changes (to D3hot and back to D0)
with the pci_set_power_state() interface, which takes care of the required
delays after these transitions.

Bjorn Helgaas (2):
  mmc: sdhci-pci-gli: Use PCI AER definitions, not hard-coded values
  mmc: sdhci-pci-gli: Use pci_set_power_state(), not direct PMCSR writes

 drivers/mmc/host/sdhci-pci-gli.c | 46 +++++++++++++-------------------
 1 file changed, 18 insertions(+), 28 deletions(-)

-- 
2.34.1

Re: [PATCH 0/2] mmc: sdhci-pci-gli: Remove unnecessary device-dependent code

Posted by Ulf Hansson 1 year, 10 months ago

On Wed, 27 Mar 2024 at 22:48, Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> Previously the driver hard-coded the config space locations of the Power
> Management and the AER Capabilities and included device-specific #defines
> for bits defined by the PCI spec.  This replaces those with the equivalents
> from the PCI core.
>
> This also replace hard-coded power state changes (to D3hot and back to D0)
> with the pci_set_power_state() interface, which takes care of the required
> delays after these transitions.
>
> Bjorn Helgaas (2):
>   mmc: sdhci-pci-gli: Use PCI AER definitions, not hard-coded values
>   mmc: sdhci-pci-gli: Use pci_set_power_state(), not direct PMCSR writes
>
>  drivers/mmc/host/sdhci-pci-gli.c | 46 +++++++++++++-------------------
>  1 file changed, 18 insertions(+), 28 deletions(-)
>

The series applied for next, thanks!

Kind regards
Uffe