ata: pata_macio: drop driver owner assignment

[PATCH] ata: pata_macio: drop driver owner assignment

Posted by Krzysztof Kozlowski 1 year, 10 months ago

PCI core in pci_register_driver() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/ata/pata_macio.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/ata/pata_macio.c b/drivers/ata/pata_macio.c
index 4ac854f6b057..88b2e9817f49 100644
--- a/drivers/ata/pata_macio.c
+++ b/drivers/ata/pata_macio.c
@@ -1371,9 +1371,6 @@ static struct pci_driver pata_macio_pci_driver = {
 	.suspend	= pata_macio_pci_suspend,
 	.resume		= pata_macio_pci_resume,
 #endif
-	.driver = {
-		.owner		= THIS_MODULE,
-	},
 };
 MODULE_DEVICE_TABLE(pci, pata_macio_pci_match);
 
-- 
2.34.1

Re: [PATCH] ata: pata_macio: drop driver owner assignment

Posted by Damien Le Moal 1 year, 10 months ago

On 3/28/24 02:49, Krzysztof Kozlowski wrote:
> PCI core in pci_register_driver() already sets the .owner, so driver
> does not need to.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Applied to for-6.9-fixes. Thanks !

-- 
Damien Le Moal
Western Digital Research

Re: [PATCH] ata: pata_macio: drop driver owner assignment

Posted by Sergey Shtylyov 1 year, 10 months ago

Well, strictly speaking, it's initializer, not assignment...

MBR, Sergey

Re: [PATCH] ata: pata_macio: drop driver owner assignment

Posted by Sergey Shtylyov 1 year, 10 months ago

On 3/27/24 8:49 PM, Krzysztof Kozlowski wrote:

> PCI core in pci_register_driver() already sets the .owner, so driver
> does not need to.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>

[...]

MBR, Sergey