fpga: altera: drop driver owner assignment

[PATCH] fpga: altera: drop driver owner assignment

Posted by Krzysztof Kozlowski 1 year, 10 months ago

Core in spi_register_driver() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/fpga/altera-ps-spi.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/fpga/altera-ps-spi.c b/drivers/fpga/altera-ps-spi.c
index 740980e7cef8..d0ec3539b31f 100644
--- a/drivers/fpga/altera-ps-spi.c
+++ b/drivers/fpga/altera-ps-spi.c
@@ -284,7 +284,6 @@ MODULE_DEVICE_TABLE(spi, altera_ps_spi_ids);
 static struct spi_driver altera_ps_driver = {
 	.driver = {
 		.name = "altera-ps-spi",
-		.owner = THIS_MODULE,
 		.of_match_table = of_ef_match,
 	},
 	.id_table = altera_ps_spi_ids,
-- 
2.34.1

Re: [PATCH] fpga: altera: drop driver owner assignment

Posted by Xu Yilun 1 year, 10 months ago

On Wed, Mar 27, 2024 at 06:49:09PM +0100, Krzysztof Kozlowski wrote:
> Core in spi_register_driver() already sets the .owner, so driver
> does not need to.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Acked-by: Xu Yilun <yilun.xu@intel.com>

Applied to for-next.

> ---
>  drivers/fpga/altera-ps-spi.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/fpga/altera-ps-spi.c b/drivers/fpga/altera-ps-spi.c
> index 740980e7cef8..d0ec3539b31f 100644
> --- a/drivers/fpga/altera-ps-spi.c
> +++ b/drivers/fpga/altera-ps-spi.c
> @@ -284,7 +284,6 @@ MODULE_DEVICE_TABLE(spi, altera_ps_spi_ids);
>  static struct spi_driver altera_ps_driver = {
>  	.driver = {
>  		.name = "altera-ps-spi",
> -		.owner = THIS_MODULE,
>  		.of_match_table = of_ef_match,
>  	},
>  	.id_table = altera_ps_spi_ids,
> -- 
> 2.34.1
> 
>