watchdog: mtx-1: drop driver owner assignment

[PATCH] watchdog: mtx-1: drop driver owner assignment

Posted by Krzysztof Kozlowski 1 year, 10 months ago

Core in platform_driver_register() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/watchdog/mtx-1_wdt.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/watchdog/mtx-1_wdt.c b/drivers/watchdog/mtx-1_wdt.c
index 152e41ecbb14..06756135033d 100644
--- a/drivers/watchdog/mtx-1_wdt.c
+++ b/drivers/watchdog/mtx-1_wdt.c
@@ -236,7 +236,6 @@ static struct platform_driver mtx1_wdt_driver = {
 	.probe = mtx1_wdt_probe,
 	.remove_new = mtx1_wdt_remove,
 	.driver.name = "mtx1-wdt",
-	.driver.owner = THIS_MODULE,
 };
 
 module_platform_driver(mtx1_wdt_driver);
-- 
2.34.1

Re: [PATCH] watchdog: mtx-1: drop driver owner assignment

Posted by Guenter Roeck 1 year, 10 months ago

On Wed, Mar 27, 2024 at 06:46:38PM +0100, Krzysztof Kozlowski wrote:
> Core in platform_driver_register() already sets the .owner, so driver
> does not need to.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/watchdog/mtx-1_wdt.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/watchdog/mtx-1_wdt.c b/drivers/watchdog/mtx-1_wdt.c
> index 152e41ecbb14..06756135033d 100644
> --- a/drivers/watchdog/mtx-1_wdt.c
> +++ b/drivers/watchdog/mtx-1_wdt.c
> @@ -236,7 +236,6 @@ static struct platform_driver mtx1_wdt_driver = {
>  	.probe = mtx1_wdt_probe,
>  	.remove_new = mtx1_wdt_remove,
>  	.driver.name = "mtx1-wdt",
> -	.driver.owner = THIS_MODULE,
>  };
>  
>  module_platform_driver(mtx1_wdt_driver);
> -- 
> 2.34.1
>