[PATCH v2 0/3] staging: pi433: Fix includes, comments & macros.

Shahar Avidar posted 3 patches 1 year, 10 months ago
There is a newer version of this series
drivers/staging/pi433/pi433_if.c | 5 +++--
drivers/staging/pi433/rf69.c     | 1 +
drivers/staging/pi433/rf69.h     | 1 -
3 files changed, 4 insertions(+), 3 deletions(-)
[PATCH v2 0/3] staging: pi433: Fix includes, comments & macros.
Posted by Shahar Avidar 1 year, 10 months ago
This patchset continues with some cleanups:

1. Untangle include hierarchy.
2. Delete a misleading comment.
3. Make use of general macro instead of magic number.

v2->v1:
Undo macro update. Remove its inaccurate comment instead.

Shahar Avidar (3):
  staging: pi433: Use headers in appropriate files.
  staging: pi433: Remove an inaccurate comment.
  staging: pi433: Make use of spi mode macro instead of magic number.

 drivers/staging/pi433/pi433_if.c | 5 +++--
 drivers/staging/pi433/rf69.c     | 1 +
 drivers/staging/pi433/rf69.h     | 1 -
 3 files changed, 4 insertions(+), 3 deletions(-)


base-commit: 26a73b4d30d29f572163f7399e39d56677607b55
-- 
2.34.1
Re: [PATCH v2 0/3] staging: pi433: Fix includes, comments & macros.
Posted by Andy Shevchenko 1 year, 10 months ago
On Wed, Mar 27, 2024 at 08:31:53AM +0200, Shahar Avidar wrote:
> This patchset continues with some cleanups:
> 
> 1. Untangle include hierarchy.
> 2. Delete a misleading comment.
> 3. Make use of general macro instead of magic number.

> v2->v1:
> Undo macro update. Remove its inaccurate comment instead.

It's your responsibility to carry on the given tags for unchanged patches.
I believe I gave a tag to two out of three patches.

-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH v2 0/3] staging: pi433: Fix includes, comments & macros.
Posted by Shahar Avidar 1 year, 10 months ago
On 27/03/2024 15:10, Andy Shevchenko wrote:
> It's your responsibility to carry on the given tags for unchanged patches.
> I believe I gave a tag to two out of three patches.

Sure.
Thank you again for your time.
V3 was just sent with the reviewed-by tag.

-- 
Regards,

Shahar