[v1] ACPI: store owner from modules with acpi_bus_register_driver()

[PATCH 02/19] Input: atlas: - drop owner assignment

Posted by Krzysztof Kozlowski 1 year, 10 months ago

ACPI bus core already sets the .owner, so driver does not need to.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Depends on the first patch.
---
 drivers/input/misc/atlas_btns.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/input/misc/atlas_btns.c b/drivers/input/misc/atlas_btns.c
index 3c9bbd04e143..5b9be2957746 100644
--- a/drivers/input/misc/atlas_btns.c
+++ b/drivers/input/misc/atlas_btns.c
@@ -127,7 +127,6 @@ MODULE_DEVICE_TABLE(acpi, atlas_device_ids);
 static struct acpi_driver atlas_acpi_driver = {
 	.name	= ACPI_ATLAS_NAME,
 	.class	= ACPI_ATLAS_CLASS,
-	.owner	= THIS_MODULE,
 	.ids	= atlas_device_ids,
 	.ops	= {
 		.add	= atlas_acpi_button_add,

-- 
2.34.1

Re: [PATCH 02/19] Input: atlas: - drop owner assignment

Posted by Dmitry Torokhov 1 year, 10 months ago

On Wed, Mar 27, 2024 at 08:43:49AM +0100, Krzysztof Kozlowski wrote:
> ACPI bus core already sets the .owner, so driver does not need to.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

But please fix the stray colon in the subject.

> 
> ---
> 
> Depends on the first patch.
> ---
>  drivers/input/misc/atlas_btns.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/input/misc/atlas_btns.c b/drivers/input/misc/atlas_btns.c
> index 3c9bbd04e143..5b9be2957746 100644
> --- a/drivers/input/misc/atlas_btns.c
> +++ b/drivers/input/misc/atlas_btns.c
> @@ -127,7 +127,6 @@ MODULE_DEVICE_TABLE(acpi, atlas_device_ids);
>  static struct acpi_driver atlas_acpi_driver = {
>  	.name	= ACPI_ATLAS_NAME,
>  	.class	= ACPI_ATLAS_CLASS,
> -	.owner	= THIS_MODULE,
>  	.ids	= atlas_device_ids,
>  	.ops	= {
>  		.add	= atlas_acpi_button_add,
> 
> -- 
> 2.34.1
> 

-- 
Dmitry

Re: [PATCH 02/19] Input: atlas: - drop owner assignment

Posted by Krzysztof Kozlowski 1 year, 10 months ago

On 28/03/2024 18:55, Dmitry Torokhov wrote:
> On Wed, Mar 27, 2024 at 08:43:49AM +0100, Krzysztof Kozlowski wrote:
>> ACPI bus core already sets the .owner, so driver does not need to.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> 
> But please fix the stray colon in the subject.

Ykes, sure. I will send a v2 today or tomorrow with collected tags, so
this could go via Rafael.

Best regards,
Krzysztof