[v5] TPEBS counting mode support

[RFC PATCH v5 0/6] TPEBS counting mode support

Posted by weilin.wang@intel.com 1 year, 10 months ago

From: Weilin Wang <weilin.wang@intel.com>

Changes in v5:
- Update code and add comments for better code quality [Ian]

v4: https://lore.kernel.org/all/20240312234921.812685-1-weilin.wang@intel.com/

Weilin Wang (6):
  perf stat: Parse and find tpebs events when parsing metrics to prepare
    for perf record sampling
  perf stat: Fork and launch perf record when perf stat needs to get
    retire latency value for a metric.
  perf stat: Add retire latency values into the expr_parse_ctx to
    prepare for final metric calculation
  perf stat: Create another thread for sample data processing
  perf stat: Add retire latency print functions to print out at the very
    end of print out
  perf vendor events intel: Add MTL metric json files

 tools/perf/builtin-stat.c                     |  211 +-
 .../arch/x86/meteorlake/metricgroups.json     |  127 +
 .../arch/x86/meteorlake/mtl-metrics.json      | 2551 +++++++++++++++++
 tools/perf/util/data.c                        |    3 +
 tools/perf/util/data.h                        |    5 +
 tools/perf/util/metricgroup.c                 |   88 +-
 tools/perf/util/metricgroup.h                 |   22 +-
 tools/perf/util/stat-display.c                |   65 +
 tools/perf/util/stat-shadow.c                 |   19 +
 tools/perf/util/stat.h                        |    4 +
 10 files changed, 3076 insertions(+), 19 deletions(-)
 create mode 100644 tools/perf/pmu-events/arch/x86/meteorlake/metricgroups.json
 create mode 100644 tools/perf/pmu-events/arch/x86/meteorlake/mtl-metrics.json

--
2.43.0

Re: [RFC PATCH v5 0/6] TPEBS counting mode support

Posted by Ian Rogers 1 year, 10 months ago

On Tue, Mar 26, 2024 at 1:29 PM <weilin.wang@intel.com> wrote:
>
> From: Weilin Wang <weilin.wang@intel.com>
>
> Changes in v5:
> - Update code and add comments for better code quality [Ian]
>
> v4: https://lore.kernel.org/all/20240312234921.812685-1-weilin.wang@intel.com/
>
> Weilin Wang (6):
>   perf stat: Parse and find tpebs events when parsing metrics to prepare
>     for perf record sampling
>   perf stat: Fork and launch perf record when perf stat needs to get
>     retire latency value for a metric.
>   perf stat: Add retire latency values into the expr_parse_ctx to
>     prepare for final metric calculation
>   perf stat: Create another thread for sample data processing
>   perf stat: Add retire latency print functions to print out at the very
>     end of print out
>   perf vendor events intel: Add MTL metric json files
>
>  tools/perf/builtin-stat.c                     |  211 +-
>  .../arch/x86/meteorlake/metricgroups.json     |  127 +
>  .../arch/x86/meteorlake/mtl-metrics.json      | 2551 +++++++++++++++++
>  tools/perf/util/data.c                        |    3 +
>  tools/perf/util/data.h                        |    5 +
>  tools/perf/util/metricgroup.c                 |   88 +-
>  tools/perf/util/metricgroup.h                 |   22 +-
>  tools/perf/util/stat-display.c                |   65 +
>  tools/perf/util/stat-shadow.c                 |   19 +
>  tools/perf/util/stat.h                        |    4 +
>  10 files changed, 3076 insertions(+), 19 deletions(-)
>  create mode 100644 tools/perf/pmu-events/arch/x86/meteorlake/metricgroups.json
>  create mode 100644 tools/perf/pmu-events/arch/x86/meteorlake/mtl-metrics.json

Thanks Weilin,

I'm happy with this series, my Reviewed-by is on all the patches.
Arnaldo/Namhyung, could we land this for the sake of Meteorlake metric
enablement? For the sake of tools, for the series:

Reviewed-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> --
> 2.43.0
>

Re: [RFC PATCH v5 0/6] TPEBS counting mode support

Posted by Namhyung Kim 1 year, 10 months ago

Hello,

On Thu, Mar 28, 2024 at 9:36 AM Ian Rogers <irogers@google.com> wrote:
>
> On Tue, Mar 26, 2024 at 1:29 PM <weilin.wang@intel.com> wrote:
> >
> > From: Weilin Wang <weilin.wang@intel.com>
> >
> > Changes in v5:
> > - Update code and add comments for better code quality [Ian]
> >
> > v4: https://lore.kernel.org/all/20240312234921.812685-1-weilin.wang@intel.com/
> >
> > Weilin Wang (6):
> >   perf stat: Parse and find tpebs events when parsing metrics to prepare
> >     for perf record sampling
> >   perf stat: Fork and launch perf record when perf stat needs to get
> >     retire latency value for a metric.
> >   perf stat: Add retire latency values into the expr_parse_ctx to
> >     prepare for final metric calculation
> >   perf stat: Create another thread for sample data processing
> >   perf stat: Add retire latency print functions to print out at the very
> >     end of print out
> >   perf vendor events intel: Add MTL metric json files
> >
> >  tools/perf/builtin-stat.c                     |  211 +-
> >  .../arch/x86/meteorlake/metricgroups.json     |  127 +
> >  .../arch/x86/meteorlake/mtl-metrics.json      | 2551 +++++++++++++++++
> >  tools/perf/util/data.c                        |    3 +
> >  tools/perf/util/data.h                        |    5 +
> >  tools/perf/util/metricgroup.c                 |   88 +-
> >  tools/perf/util/metricgroup.h                 |   22 +-
> >  tools/perf/util/stat-display.c                |   65 +
> >  tools/perf/util/stat-shadow.c                 |   19 +
> >  tools/perf/util/stat.h                        |    4 +
> >  10 files changed, 3076 insertions(+), 19 deletions(-)
> >  create mode 100644 tools/perf/pmu-events/arch/x86/meteorlake/metricgroups.json
> >  create mode 100644 tools/perf/pmu-events/arch/x86/meteorlake/mtl-metrics.json
>
> Thanks Weilin,
>
> I'm happy with this series, my Reviewed-by is on all the patches.
> Arnaldo/Namhyung, could we land this for the sake of Meteorlake metric
> enablement? For the sake of tools, for the series:
>
> Reviewed-by: Ian Rogers <irogers@google.com>

Let me review this series again.

Thanks,
Namhyung

RE: [RFC PATCH v5 0/6] TPEBS counting mode support

Posted by Wang, Weilin 1 year, 10 months ago


> -----Original Message-----
> From: Namhyung Kim <namhyung@kernel.org>
> Sent: Thursday, March 28, 2024 12:43 PM
> To: Ian Rogers <irogers@google.com>
> Cc: Wang, Weilin <weilin.wang@intel.com>; Arnaldo Carvalho de Melo
> <acme@kernel.org>; Peter Zijlstra <peterz@infradead.org>; Ingo Molnar
> <mingo@redhat.com>; Alexander Shishkin
> <alexander.shishkin@linux.intel.com>; Jiri Olsa <jolsa@kernel.org>; Hunter,
> Adrian <adrian.hunter@intel.com>; Kan Liang <kan.liang@linux.intel.com>;
> linux-perf-users@vger.kernel.org; linux-kernel@vger.kernel.org; Taylor, Perry
> <perry.taylor@intel.com>; Alt, Samantha <samantha.alt@intel.com>; Biggers,
> Caleb <caleb.biggers@intel.com>
> Subject: Re: [RFC PATCH v5 0/6] TPEBS counting mode support
> 
> Hello,
> 
> On Thu, Mar 28, 2024 at 9:36 AM Ian Rogers <irogers@google.com> wrote:
> >
> > On Tue, Mar 26, 2024 at 1:29 PM <weilin.wang@intel.com> wrote:
> > >
> > > From: Weilin Wang <weilin.wang@intel.com>
> > >
> > > Changes in v5:
> > > - Update code and add comments for better code quality [Ian]
> > >
> > > v4: https://lore.kernel.org/all/20240312234921.812685-1-
> weilin.wang@intel.com/
> > >
> > > Weilin Wang (6):
> > >   perf stat: Parse and find tpebs events when parsing metrics to prepare
> > >     for perf record sampling
> > >   perf stat: Fork and launch perf record when perf stat needs to get
> > >     retire latency value for a metric.
> > >   perf stat: Add retire latency values into the expr_parse_ctx to
> > >     prepare for final metric calculation
> > >   perf stat: Create another thread for sample data processing
> > >   perf stat: Add retire latency print functions to print out at the very
> > >     end of print out
> > >   perf vendor events intel: Add MTL metric json files
> > >
> > >  tools/perf/builtin-stat.c                     |  211 +-
> > >  .../arch/x86/meteorlake/metricgroups.json     |  127 +
> > >  .../arch/x86/meteorlake/mtl-metrics.json      | 2551
> +++++++++++++++++
> > >  tools/perf/util/data.c                        |    3 +
> > >  tools/perf/util/data.h                        |    5 +
> > >  tools/perf/util/metricgroup.c                 |   88 +-
> > >  tools/perf/util/metricgroup.h                 |   22 +-
> > >  tools/perf/util/stat-display.c                |   65 +
> > >  tools/perf/util/stat-shadow.c                 |   19 +
> > >  tools/perf/util/stat.h                        |    4 +
> > >  10 files changed, 3076 insertions(+), 19 deletions(-)
> > >  create mode 100644 tools/perf/pmu-
> events/arch/x86/meteorlake/metricgroups.json
> > >  create mode 100644 tools/perf/pmu-events/arch/x86/meteorlake/mtl-
> metrics.json
> >
> > Thanks Weilin,
> >
> > I'm happy with this series, my Reviewed-by is on all the patches.
> > Arnaldo/Namhyung, could we land this for the sake of Meteorlake metric
> > enablement? For the sake of tools, for the series:
> >
> > Reviewed-by: Ian Rogers <irogers@google.com>
> 
> Let me review this series again.

Thanks a lot Ian and Namhyung!

> 
> Thanks,
> Namhyung