driver core: Remove unused platform_notify, platform_notify_remove

[PATCH] driver core: Remove unused platform_notify, platform_notify_remove

Posted by Bjorn Helgaas 1 year, 10 months ago

From: Bjorn Helgaas <bhelgaas@google.com>

The "platform_notify" and "platform_notify_remove" hooks have been unused
since 00ba9357d189 ("ARM: ixp4xx: Drop custom DMA coherency and bouncing").

Remove "platform_notify" and "platform_notify_remove".  No functional
change intended.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/base/core.c    |  8 --------
 include/linux/device.h | 11 -----------
 2 files changed, 19 deletions(-)

diff --git a/drivers/base/core.c b/drivers/base/core.c
index b93f3c5716ae..78dfa74ee18b 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -2331,8 +2331,6 @@ static void fw_devlink_link_device(struct device *dev)
 
 /* Device links support end. */
 
-int (*platform_notify)(struct device *dev) = NULL;
-int (*platform_notify_remove)(struct device *dev) = NULL;
 static struct kobject *dev_kobj;
 
 /* /sys/dev/char */
@@ -2380,16 +2378,10 @@ static void device_platform_notify(struct device *dev)
 	acpi_device_notify(dev);
 
 	software_node_notify(dev);
-
-	if (platform_notify)
-		platform_notify(dev);
 }
 
 static void device_platform_notify_remove(struct device *dev)
 {
-	if (platform_notify_remove)
-		platform_notify_remove(dev);
-
 	software_node_notify_remove(dev);
 
 	acpi_device_notify_remove(dev);
diff --git a/include/linux/device.h b/include/linux/device.h
index 97c4b046c09d..c515ba5756e4 100644
--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -1206,17 +1206,6 @@ int __must_check devm_device_add_groups(struct device *dev,
 int __must_check devm_device_add_group(struct device *dev,
 				       const struct attribute_group *grp);
 
-/*
- * Platform "fixup" functions - allow the platform to have their say
- * about devices and actions that the general device layer doesn't
- * know about.
- */
-/* Notify platform of device discovery */
-extern int (*platform_notify)(struct device *dev);
-
-extern int (*platform_notify_remove)(struct device *dev);
-
-
 /*
  * get_device - atomically increment the reference count for the device.
  *
-- 
2.34.1

Re: [PATCH] driver core: Remove unused platform_notify, platform_notify_remove

Posted by Andy Shevchenko 1 year, 10 months ago

On Mon, Mar 25, 2024 at 05:14:09PM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> The "platform_notify" and "platform_notify_remove" hooks have been unused
> since 00ba9357d189 ("ARM: ixp4xx: Drop custom DMA coherency and bouncing").
> 
> Remove "platform_notify" and "platform_notify_remove".  No functional
> change intended.

Less this invasive callbacks, better to maintain, thank you for the contribution!

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>

Btw, can we start moving Cc list out of the commit messages?

> ---

You can simply put Cc here, and it will have the same effect (and being
archived on lore.kernel.org) while making commit messages less polluted.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] driver core: Remove unused platform_notify, platform_notify_remove

Posted by Rafael J. Wysocki 1 year, 10 months ago

On Mon, Mar 25, 2024 at 11:14 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> The "platform_notify" and "platform_notify_remove" hooks have been unused
> since 00ba9357d189 ("ARM: ixp4xx: Drop custom DMA coherency and bouncing").
>
> Remove "platform_notify" and "platform_notify_remove".  No functional
> change intended.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>

Acked-by: Rafael J. Wysocki <rafael@kernel.org>

> ---
>  drivers/base/core.c    |  8 --------
>  include/linux/device.h | 11 -----------
>  2 files changed, 19 deletions(-)
>
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index b93f3c5716ae..78dfa74ee18b 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -2331,8 +2331,6 @@ static void fw_devlink_link_device(struct device *dev)
>
>  /* Device links support end. */
>
> -int (*platform_notify)(struct device *dev) = NULL;
> -int (*platform_notify_remove)(struct device *dev) = NULL;
>  static struct kobject *dev_kobj;
>
>  /* /sys/dev/char */
> @@ -2380,16 +2378,10 @@ static void device_platform_notify(struct device *dev)
>         acpi_device_notify(dev);
>
>         software_node_notify(dev);
> -
> -       if (platform_notify)
> -               platform_notify(dev);
>  }
>
>  static void device_platform_notify_remove(struct device *dev)
>  {
> -       if (platform_notify_remove)
> -               platform_notify_remove(dev);
> -
>         software_node_notify_remove(dev);
>
>         acpi_device_notify_remove(dev);
> diff --git a/include/linux/device.h b/include/linux/device.h
> index 97c4b046c09d..c515ba5756e4 100644
> --- a/include/linux/device.h
> +++ b/include/linux/device.h
> @@ -1206,17 +1206,6 @@ int __must_check devm_device_add_groups(struct device *dev,
>  int __must_check devm_device_add_group(struct device *dev,
>                                        const struct attribute_group *grp);
>
> -/*
> - * Platform "fixup" functions - allow the platform to have their say
> - * about devices and actions that the general device layer doesn't
> - * know about.
> - */
> -/* Notify platform of device discovery */
> -extern int (*platform_notify)(struct device *dev);
> -
> -extern int (*platform_notify_remove)(struct device *dev);
> -
> -
>  /*
>   * get_device - atomically increment the reference count for the device.
>   *
> --
> 2.34.1
>