[PATCH 5.15 087/317] arm64: dts: qcom: msm8998: drop USB PHY clock index

Sasha Levin posted 317 patches 1 year, 6 months ago
[PATCH 5.15 087/317] arm64: dts: qcom: msm8998: drop USB PHY clock index
Posted by Sasha Levin 1 year, 6 months ago
From: Johan Hovold <johan+linaro@kernel.org>

[ Upstream commit ed9cbbcb8c6a1925db7995214602c6a8983ff870 ]

The QMP USB PHY provides a single clock so drop the redundant clock
index.

Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/20220705114032.22787-7-johan+linaro@kernel.org
Stable-dep-of: fc835b2311d4 ("arm64: dts: qcom: msm8998: declare VLS CLAMP register for USB3 PHY")
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 arch/arm64/boot/dts/qcom/msm8998.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
index 6dbed85fa53e5..e1b744d76251d 100644
--- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
@@ -2013,7 +2013,7 @@ usb1_ssphy: phy@c010200 {
 				      <0xc010600 0x128>,
 				      <0xc010800 0x200>;
 				#phy-cells = <0>;
-				#clock-cells = <1>;
+				#clock-cells = <0>;
 				clocks = <&gcc GCC_USB3_PHY_PIPE_CLK>;
 				clock-names = "pipe0";
 				clock-output-names = "usb3_phy_pipe_clk_src";
-- 
2.43.0
Re: [PATCH 5.15 087/317] arm64: dts: qcom: msm8998: drop USB PHY clock index
Posted by Johan Hovold 1 year, 6 months ago
On Sun, Mar 24, 2024 at 07:31:07PM -0400, Sasha Levin wrote:
> From: Johan Hovold <johan+linaro@kernel.org>
> 
> [ Upstream commit ed9cbbcb8c6a1925db7995214602c6a8983ff870 ]
> 
> The QMP USB PHY provides a single clock so drop the redundant clock
> index.
> 
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Link: https://lore.kernel.org/r/20220705114032.22787-7-johan+linaro@kernel.org
> Stable-dep-of: fc835b2311d4 ("arm64: dts: qcom: msm8998: declare VLS CLAMP register for USB3 PHY")

As I also already pointed out once, this patch does not make sense to
backport and neither does the Stable-dep-of which depends on a new
driver in 6.9.

Please drop from all stable queues, including the other deps that will
break the driver such as:

	b7efebfeb2e8 ("arm64: dts: qcom: msm8998: switch USB QMP PHY to new style of bindings")

Sasha, you can't around picking intrusive patches like this on your own.

The Stable-dep-of did not have a stable tag and should never have been a
candidate for backporting in the first place.

Having to point this out to you twice in two days is quite frustrating
and I'm worried about what breaks next time when I happen to look away.

Johan