kconfig: fix an unselectable choice in MIPS again, and make sure it never happens

[PATCH 0/2] kconfig: fix an unselectable choice in MIPS again, and make sure it never happens

Masahiro Yamada posted 2 patches 1 year, 10 months ago

Download series mbox

arch/mips/Kconfig        | 18 +++++++++---------
scripts/kconfig/conf.c   |  5 -----
scripts/kconfig/lkc.h    |  2 +-
scripts/kconfig/menu.c   | 22 ++++++++++++++++------
scripts/kconfig/parser.y |  2 +-
5 files changed, 27 insertions(+), 22 deletions(-)

Expand all Fold all

[PATCH 0/2] kconfig: fix an unselectable choice in MIPS again, and make sure it never happens

Posted by Masahiro Yamada 1 year, 10 months ago

The reason is already explained here:

https://lore.kernel.org/linux-kbuild/20240127162309.1026549-1-masahiroy@kernel.org/

Commit 5033ad566016 fixed the issue, but the MIPS maintainer
simultaneously applied commit 101bd58fde10, which introduced
another instance of the same mistake.

I will not ask him to pick up this any more.
That would take two development cycles until this choice structure
is banned. Meantime, MIPS would introduce yet another mistake.

I will apply both to my tree.

The second patch makes it an error to stop this whack-a-mole game.



Masahiro Yamada (2):
  MIPS: move unselectable FIT_IMAGE_FDT_EPM5 out of the "System type"
    choice
  kconfig: do not reparent the menu inside a choice block

 arch/mips/Kconfig        | 18 +++++++++---------
 scripts/kconfig/conf.c   |  5 -----
 scripts/kconfig/lkc.h    |  2 +-
 scripts/kconfig/menu.c   | 22 ++++++++++++++++------
 scripts/kconfig/parser.y |  2 +-
 5 files changed, 27 insertions(+), 22 deletions(-)

-- 
2.40.1