1. Patchew
  2. linux
  3. View series

[PATCH] netlink: fix typo

gaoxingwang posted 1 patch 1 year, 10 months ago 
netlink/coalesce.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] netlink: fix typo
Posted by gaoxingwang 1 year, 10 months ago 
Add missing colon in coalesce_reply_cb

Fixes: ec573f209d (netlink: settings: add netlink support for coalesce tx aggr params)
Signed-off-by: gaoxingwang <gaoxingwang1@huawei.com>

Signed-off-by: gaoxingwang <gaoxingwang1@huawei.com>
---
 netlink/coalesce.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/netlink/coalesce.c b/netlink/coalesce.c
index bc34d3d..bb93f9b 100644
--- a/netlink/coalesce.c
+++ b/netlink/coalesce.c
@@ -93,7 +93,7 @@ int coalesce_reply_cb(const struct nlmsghdr *nlhdr, void *data)
 		 tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_BYTES]);
 	show_u32("tx-aggr-max-frames", "tx-aggr-max-frames:\t",
 		 tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_FRAMES]);
-	show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs\t",
+	show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs:\t",
 		 tb[ETHTOOL_A_COALESCE_TX_AGGR_TIME_USECS]);
 	show_cr();
 
-- 
2.27.0
Re: [PATCH] netlink: fix typo
Posted by Jiri Pirko 1 year, 10 months ago 
Fri, Mar 22, 2024 at 08:24:56AM CET, gaoxingwang1@huawei.com wrote:
>Add missing colon in coalesce_reply_cb
>
>Fixes: ec573f209d (netlink: settings: add netlink support for coalesce tx aggr params)
>Signed-off-by: gaoxingwang <gaoxingwang1@huawei.com>
>
>Signed-off-by: gaoxingwang <gaoxingwang1@huawei.com>
>---
> netlink/coalesce.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/netlink/coalesce.c b/netlink/coalesce.c
>index bc34d3d..bb93f9b 100644
>--- a/netlink/coalesce.c
>+++ b/netlink/coalesce.c

Please make clear indication which project/tree you target with your
patch by putting appropriate name in the [patch NAME] brackets



>@@ -93,7 +93,7 @@ int coalesce_reply_cb(const struct nlmsghdr *nlhdr, void *data)
> 		 tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_BYTES]);
> 	show_u32("tx-aggr-max-frames", "tx-aggr-max-frames:\t",
> 		 tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_FRAMES]);
>-	show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs\t",
>+	show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs:\t",
> 		 tb[ETHTOOL_A_COALESCE_TX_AGGR_TIME_USECS]);
> 	show_cr();
> 
>-- 
>2.27.0
>
>
Re: [PATCH] netlink: fix typo
Posted by Michal Kubecek 1 year, 10 months ago 
On Fri, Mar 22, 2024 at 09:13:53AM +0100, Jiri Pirko wrote:
> Please make clear indication which project/tree you target with your
> patch by putting appropriate name in the [patch NAME] brackets

In this case, it should be "[PATCH ethtool]".

Michal
Re: [PATCH] netlink: fix typo
Posted by gaoxingwang 1 year, 10 months ago 
>> Please make clear indication which project/tree you target with your
>> patch by putting appropriate name in the [patch NAME] brackets
>
>In this case, it should be "[PATCH ethtool]".
>
>Michal
Yes, this is a commit for the ethtool project. First time contributing a patch to this project, not familiar with it yet.
Thank you all or your guidance. I'll resubmit the patch later.
[PATCH ethtool-next] netlink: fix typo in coalesce_reply_cb()
Posted by gaoxingwang 1 year, 10 months ago 
Add missing colon in coalesce_reply_cb()

Fixes: ec573f209dfd (netlink: settings: add netlink support for coalesce tx aggr params)
Signed-off-by: Gao Xingwang <gaoxingwang1@huawei.com>
---
 netlink/coalesce.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/netlink/coalesce.c b/netlink/coalesce.c
index bc34d3d..bb93f9b 100644
--- a/netlink/coalesce.c
+++ b/netlink/coalesce.c
@@ -93,7 +93,7 @@ int coalesce_reply_cb(const struct nlmsghdr *nlhdr, void *data)
 		 tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_BYTES]);
 	show_u32("tx-aggr-max-frames", "tx-aggr-max-frames:\t",
 		 tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_FRAMES]);
-	show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs\t",
+	show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs:\t",
 		 tb[ETHTOOL_A_COALESCE_TX_AGGR_TIME_USECS]);
 	show_cr();
 
-- 
2.27.0
Re: [PATCH] netlink: fix typo
Posted by Jiri Pirko 1 year, 10 months ago 
Fri, Mar 22, 2024 at 08:24:56AM CET, gaoxingwang1@huawei.com wrote:
>Add missing colon in coalesce_reply_cb
>
>Fixes: ec573f209d (netlink: settings: add netlink support for coalesce tx aggr params)
>Signed-off-by: gaoxingwang <gaoxingwang1@huawei.com>
>
>Signed-off-by: gaoxingwang <gaoxingwang1@huawei.com>

Also, please make sure your name is properly formatted. "gaoxingwang"
certainly is not.

>---
> netlink/coalesce.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/netlink/coalesce.c b/netlink/coalesce.c
>index bc34d3d..bb93f9b 100644
>--- a/netlink/coalesce.c
>+++ b/netlink/coalesce.c
>@@ -93,7 +93,7 @@ int coalesce_reply_cb(const struct nlmsghdr *nlhdr, void *data)
> 		 tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_BYTES]);
> 	show_u32("tx-aggr-max-frames", "tx-aggr-max-frames:\t",
> 		 tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_FRAMES]);
>-	show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs\t",
>+	show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs:\t",
> 		 tb[ETHTOOL_A_COALESCE_TX_AGGR_TIME_USECS]);
> 	show_cr();
> 
>-- 
>2.27.0
>
>
Re: [PATCH] netlink: fix typo
Posted by Jakub Kicinski 1 year, 10 months ago 
On Fri, 22 Mar 2024 09:14:39 +0100 Jiri Pirko wrote:
> "gaoxingwang" certainly is not.

According to what rules? Honest question, I don't know much about
transliteration of what I guess is a Chinese name.
Re: [PATCH] netlink: fix typo
Posted by Jiri Pirko 1 year, 10 months ago 
Fri, Mar 22, 2024 at 04:07:27PM CET, kuba@kernel.org wrote:
>On Fri, 22 Mar 2024 09:14:39 +0100 Jiri Pirko wrote:
>> "gaoxingwang" certainly is not.
>
>According to what rules? Honest question, I don't know much about
>transliteration of what I guess is a Chinese name.

At least capital letter would be nice :) But "Wang" looks like a surname
and therefore a space would be appropriate too.
[PATCH ethtool-next] netlink: fix typo in coalesce_reply_cb()
Posted by gaoxingwang 1 year, 10 months ago 
Add missing colon in coalesce_reply_cb()

Fixes: ec573f209dfd (netlink: settings: add netlink support for coalesce tx aggr params)
Signed-off-by: Gao Xingwang <gaoxingwang1@huawei.com>
---
 netlink/coalesce.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/netlink/coalesce.c b/netlink/coalesce.c
index bc34d3d..bb93f9b 100644
--- a/netlink/coalesce.c
+++ b/netlink/coalesce.c
@@ -93,7 +93,7 @@ int coalesce_reply_cb(const struct nlmsghdr *nlhdr, void *data)
 		 tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_BYTES]);
 	show_u32("tx-aggr-max-frames", "tx-aggr-max-frames:\t",
 		 tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_FRAMES]);
-	show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs\t",
+	show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs:\t",
 		 tb[ETHTOOL_A_COALESCE_TX_AGGR_TIME_USECS]);
 	show_cr();
 
-- 
2.27.0
Re: [PATCH ethtool-next] netlink: fix typo in coalesce_reply_cb()
Posted by Heng Qi 1 year, 10 months ago 

在 2024/4/2 下午8:16, gaoxingwang 写道:
> Add missing colon in coalesce_reply_cb()
>
> Fixes: ec573f209dfd (netlink: settings: add netlink support for coalesce tx aggr params)
> Signed-off-by: Gao Xingwang <gaoxingwang1@huawei.com>
> ---
>   netlink/coalesce.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/netlink/coalesce.c b/netlink/coalesce.c
> index bc34d3d..bb93f9b 100644
> --- a/netlink/coalesce.c
> +++ b/netlink/coalesce.c
> @@ -93,7 +93,7 @@ int coalesce_reply_cb(const struct nlmsghdr *nlhdr, void *data)
>   		 tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_BYTES]);
>   	show_u32("tx-aggr-max-frames", "tx-aggr-max-frames:\t",
>   		 tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_FRAMES]);
> -	show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs\t",
> +	show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs:\t",
>   		 tb[ETHTOOL_A_COALESCE_TX_AGGR_TIME_USECS]);
>   	show_cr();
>   

Reviewed-by: Heng Qi <hengqi@linux.alibaba.com>
Re: [PATCH] netlink: fix typo
Posted by Jason Xing 1 year, 10 months ago 
On Fri, Mar 22, 2024 at 3:26 PM gaoxingwang <gaoxingwang1@huawei.com> wrote:
>
> Add missing colon in coalesce_reply_cb
>
> Fixes: ec573f209d (netlink: settings: add netlink support for coalesce tx aggr params)

This commit cannot be found in net/net-next tree...

> Signed-off-by: gaoxingwang <gaoxingwang1@huawei.com>
>
> Signed-off-by: gaoxingwang <gaoxingwang1@huawei.com>

nit: two duplicated SoB

> ---
>  netlink/coalesce.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/netlink/coalesce.c b/netlink/coalesce.c
> index bc34d3d..bb93f9b 100644
> --- a/netlink/coalesce.c
> +++ b/netlink/coalesce.c

Where is this file? I suspect you're not using the standard mainline?

> @@ -93,7 +93,7 @@ int coalesce_reply_cb(const struct nlmsghdr *nlhdr, void *data)
>                  tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_BYTES]);
>         show_u32("tx-aggr-max-frames", "tx-aggr-max-frames:\t",
>                  tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_FRAMES]);
> -       show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs\t",
> +       show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs:\t",
>                  tb[ETHTOOL_A_COALESCE_TX_AGGR_TIME_USECS]);
>         show_cr();
>
> --
> 2.27.0
>
>

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.