[PATCH v2 5/5] net: marvell: prestera: unbind sfp port on exit

Elad Nachman posted 5 patches 1 year, 10 months ago
[PATCH v2 5/5] net: marvell: prestera: unbind sfp port on exit
Posted by Elad Nachman 1 year, 10 months ago
From: Elad Nachman <enachman@marvell.com>

Call unbinding of the sfp port when ports are released, This will call
phylink_destroy() to cleanup and destroy the phylink instance, needed
to unregister SFP and free used memory, which will otherwise leak.

Reported-by: Köry Maincent <kory.maincent@bootlin.com>
Closes: https://lore.kernel.org/lkml/20240312164526.4a0e242a@kmaincent-XPS-13-7390/
Fixes: 501ef3066c89 ("net: marvell: prestera: Add driver for Prestera family ASIC devices")
Signed-off-by: Elad Nachman <enachman@marvell.com>
---
 drivers/net/ethernet/marvell/prestera/prestera_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/marvell/prestera/prestera_main.c b/drivers/net/ethernet/marvell/prestera/prestera_main.c
index 87d8fc4162b3..20c0ebb52af8 100644
--- a/drivers/net/ethernet/marvell/prestera/prestera_main.c
+++ b/drivers/net/ethernet/marvell/prestera/prestera_main.c
@@ -756,6 +756,7 @@ static void prestera_port_destroy(struct prestera_port *port)
 	cancel_delayed_work_sync(&port->cached_hw_stats.caching_dw);
 	unregister_netdev(dev);
 	prestera_port_list_del(port);
+	prestera_port_sfp_unbind(port);
 	prestera_devlink_port_unregister(port);
 	free_netdev(dev);
 }
-- 
2.25.1

Re: [PATCH v2 5/5] net: marvell: prestera: unbind sfp port on exit
Posted by Andrew Lunn 1 year, 10 months ago
On Wed, Mar 20, 2024 at 07:20:08PM +0200, Elad Nachman wrote:
> From: Elad Nachman <enachman@marvell.com>
> 
> Call unbinding of the sfp port when ports are released, This will call
> phylink_destroy() to cleanup and destroy the phylink instance, needed
> to unregister SFP and free used memory, which will otherwise leak.
> 
> Reported-by: Köry Maincent <kory.maincent@bootlin.com>
> Closes: https://lore.kernel.org/lkml/20240312164526.4a0e242a@kmaincent-XPS-13-7390/
> Fixes: 501ef3066c89 ("net: marvell: prestera: Add driver for Prestera family ASIC devices")
> Signed-off-by: Elad Nachman <enachman@marvell.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew