Documentation: kunit: correct KUNIT_VERY_SLOW to KUNIT_SPEED_VERY_SLOW

[PATCH] Documentation: kunit: correct KUNIT_VERY_SLOW to KUNIT_SPEED_VERY_SLOW

Posted by Kemeng Shi 1 year, 10 months ago

There is no KUNIT_VERY_SLOW, I guess we mean KUNIT_SPEED_VERY_SLOW.

Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
 Documentation/dev-tools/kunit/running_tips.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/dev-tools/kunit/running_tips.rst b/Documentation/dev-tools/kunit/running_tips.rst
index bd689db6fdd2..482f598d141c 100644
--- a/Documentation/dev-tools/kunit/running_tips.rst
+++ b/Documentation/dev-tools/kunit/running_tips.rst
@@ -294,7 +294,7 @@ macro to define the test case instead of ``KUNIT_CASE(test_name)``.
 .. code-block:: c
 
 	static const struct kunit_attributes example_attr = {
-		.speed = KUNIT_VERY_SLOW,
+		.speed = KUNIT_SPEED_VERY_SLOW,
 	};
 
 	static struct kunit_case example_test_cases[] = {
@@ -311,7 +311,7 @@ suite definition.
 .. code-block:: c
 
 	static const struct kunit_attributes example_attr = {
-		.speed = KUNIT_VERY_SLOW,
+		.speed = KUNIT_SPEED_VERY_SLOW,
 	};
 
 	static struct kunit_suite example_test_suite = {
-- 
2.30.0

Re: [PATCH] Documentation: kunit: correct KUNIT_VERY_SLOW to KUNIT_SPEED_VERY_SLOW

Posted by David Gow 1 year, 10 months ago

On Wed, 20 Mar 2024 at 16:18, Kemeng Shi <shikemeng@huaweicloud.com> wrote:
>
> There is no KUNIT_VERY_SLOW, I guess we mean KUNIT_SPEED_VERY_SLOW.
>
> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
> ---

Nice catch, thanks!

Reviewed-by: David Gow <davidgow@google.com>

Cheers,
-- David

>  Documentation/dev-tools/kunit/running_tips.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/dev-tools/kunit/running_tips.rst b/Documentation/dev-tools/kunit/running_tips.rst
> index bd689db6fdd2..482f598d141c 100644
> --- a/Documentation/dev-tools/kunit/running_tips.rst
> +++ b/Documentation/dev-tools/kunit/running_tips.rst
> @@ -294,7 +294,7 @@ macro to define the test case instead of ``KUNIT_CASE(test_name)``.
>  .. code-block:: c
>
>         static const struct kunit_attributes example_attr = {
> -               .speed = KUNIT_VERY_SLOW,
> +               .speed = KUNIT_SPEED_VERY_SLOW,
>         };
>
>         static struct kunit_case example_test_cases[] = {
> @@ -311,7 +311,7 @@ suite definition.
>  .. code-block:: c
>
>         static const struct kunit_attributes example_attr = {
> -               .speed = KUNIT_VERY_SLOW,
> +               .speed = KUNIT_SPEED_VERY_SLOW,
>         };
>
>         static struct kunit_suite example_test_suite = {
> --
> 2.30.0
>
> --
> You received this message because you are subscribed to the Google Groups "KUnit Development" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to kunit-dev+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/kunit-dev/20240320171424.6536-1-shikemeng%40huaweicloud.com.

Re: [PATCH] Documentation: kunit: correct KUNIT_VERY_SLOW to KUNIT_SPEED_VERY_SLOW

Posted by Jonathan Corbet 1 year, 10 months ago

David Gow <davidgow@google.com> writes:

> On Wed, 20 Mar 2024 at 16:18, Kemeng Shi <shikemeng@huaweicloud.com> wrote:
>>
>> There is no KUNIT_VERY_SLOW, I guess we mean KUNIT_SPEED_VERY_SLOW.
>>
>> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
>> ---
>
> Nice catch, thanks!
>
> Reviewed-by: David Gow <davidgow@google.com>

Let me know if you'd like me to pick this up; otherwise I'm assuming it
will go via the kunit path.

Thanks,

jon