[PATCH] x86/coco: Update comment of CC_ATTR_GUEST_MEM_ENCRYPT to include TDX guest

Kai Huang posted 1 patch 1 year, 10 months ago
include/linux/cc_platform.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] x86/coco: Update comment of CC_ATTR_GUEST_MEM_ENCRYPT to include TDX guest
Posted by Kai Huang 1 year, 10 months ago
TDX guest also reports CC_ATTR_GUEST_STATE_ENCRYPT as true, but the
comment of this attribute does not reflect this.

Update the comment to reflect the fact.

Signed-off-by: Kai Huang <kai.huang@intel.com>
---
 include/linux/cc_platform.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/cc_platform.h b/include/linux/cc_platform.h
index cb0d6cd1c12f..958630592088 100644
--- a/include/linux/cc_platform.h
+++ b/include/linux/cc_platform.h
@@ -48,7 +48,7 @@ enum cc_attr {
 	 * The platform/OS is running as a guest/virtual machine and actively
 	 * using memory encryption.
 	 *
-	 * Examples include SEV and SEV-ES.
+	 * Examples include SEV, SEV-ES and TDX guests.
 	 */
 	CC_ATTR_GUEST_MEM_ENCRYPT,
 

base-commit: eb8ed5b0e9d988a75b10ea811eeb1cffc6aa95c0
-- 
2.34.1
Re: [PATCH] x86/coco: Update comment of CC_ATTR_GUEST_MEM_ENCRYPT to include TDX guest
Posted by Kirill A. Shutemov 1 year, 10 months ago
On Tue, Mar 19, 2024 at 09:37:29PM +0000, Kai Huang wrote:
> TDX guest also reports CC_ATTR_GUEST_STATE_ENCRYPT as true, but the
> comment of this attribute does not reflect this.
> 
> Update the comment to reflect the fact.
> 
> Signed-off-by: Kai Huang <kai.huang@intel.com>

Acked-by: Kiriil A. Shutemov <kirill.shutemov@linux.intel.com>

Alternatively, we can just drop all these "Examples include ...". The same
info can easily can be derived from code.

-- 
  Kiryl Shutsemau / Kirill A. Shutemov
Re: [PATCH] x86/coco: Update comment of CC_ATTR_GUEST_MEM_ENCRYPT to include TDX guest
Posted by Huang, Kai 1 year, 10 months ago
On Wed, 2024-03-20 at 02:22 +0200, Kirill A. Shutemov wrote:
> On Tue, Mar 19, 2024 at 09:37:29PM +0000, Kai Huang wrote:
> > TDX guest also reports CC_ATTR_GUEST_STATE_ENCRYPT as true, but the
> > comment of this attribute does not reflect this.
> > 
> > Update the comment to reflect the fact.
> > 
> > Signed-off-by: Kai Huang <kai.huang@intel.com>
> 
> Acked-by: Kiriil A. Shutemov <kirill.shutemov@linux.intel.com>

Thanks.

> 
> Alternatively, we can just drop all these "Examples include ...". The same
> info can easily can be derived from code.
> 

Both work for me.