[PATCH v2] floppy: remove duplicated code in redo_fd_request()

Yufeng Wang posted 1 patch 1 year, 10 months ago
drivers/block/floppy.c | 1 -
1 file changed, 1 deletion(-)
[PATCH v2] floppy: remove duplicated code in redo_fd_request()
Posted by Yufeng Wang 1 year, 10 months ago
duplicated code in redo_fd_request(),
unlock_fdc() function has the same code "do_floppy = NULL" inside.

Signed-off-by: Yufeng Wang <wangyufeng@kylinos.cn>
Suggested-by: Denis Efremov <efremov@linux.com>
---
v2: The commit title is too long, update a new short commit title.
---
 drivers/block/floppy.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
index 1b399ec8c07d..25c9d85667f1 100644
--- a/drivers/block/floppy.c
+++ b/drivers/block/floppy.c
@@ -2787,7 +2787,6 @@ static void redo_fd_request(void)
 		pending = set_next_request();
 		spin_unlock_irq(&floppy_lock);
 		if (!pending) {
-			do_floppy = NULL;
 			unlock_fdc();
 			return;
 		}
-- 
2.34.1
Re: [PATCH v2] floppy: remove duplicated code in redo_fd_request()
Posted by Jens Axboe 1 year, 10 months ago
On Tue, 19 Mar 2024 09:42:19 +0800, Yufeng Wang wrote:
> duplicated code in redo_fd_request(),
> unlock_fdc() function has the same code "do_floppy = NULL" inside.
> 
> 

Applied, thanks!

[1/1] floppy: remove duplicated code in redo_fd_request()
      commit: 50171b8667733146f139c773d8f00866ceb4cee4

Best regards,
-- 
Jens Axboe