blk-pm: Remove unnecessary ‘0’ values from ret

[PATCH] blk-pm: Remove unnecessary ‘0’ values from ret

Posted by Li zeming 2 years, 3 months ago

ret is assigned first, so it does not need to initialize the assignment.

Signed-off-by: Li zeming <zeming@nfschina.com>
---
 block/blk-pm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/block/blk-pm.c b/block/blk-pm.c
index 42e8420747153..c76d5a3169417 100644
--- a/block/blk-pm.c
+++ b/block/blk-pm.c
@@ -58,10 +58,10 @@ EXPORT_SYMBOL(blk_pm_runtime_init);
  */
 int blk_pre_runtime_suspend(struct request_queue *q)
 {
-	int ret = 0;
+	int ret;
 
 	if (!q->dev)
-		return ret;
+		return 0;
 
 	WARN_ON_ONCE(q->rpm_status != RPM_ACTIVE);
 
-- 
2.18.2

Re: [PATCH] blk-pm: Remove unnecessary ‘0’ values from ret

Posted by Chaitanya Kulkarni 2 years, 3 months ago

On 3/17/24 20:07, Li zeming wrote:
> ret is assigned first, so it does not need to initialize the assignment.
>
> Signed-off-by: Li zeming <zeming@nfschina.com>
> ---
>   block/blk-pm.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/block/blk-pm.c b/block/blk-pm.c
> index 42e8420747153..c76d5a3169417 100644
> --- a/block/blk-pm.c
> +++ b/block/blk-pm.c
> @@ -58,10 +58,10 @@ EXPORT_SYMBOL(blk_pm_runtime_init);
>    */
>   int blk_pre_runtime_suspend(struct request_queue *q)
>   {
> -	int ret = 0;
> +	int ret;
>   
>   	if (!q->dev)
> -		return ret;
> +		return 0;
>   
>   	WARN_ON_ONCE(q->rpm_status != RPM_ACTIVE);
>   

I don't see why we need this patch, existing code is fine ...

-ck