[v1] media: uvc: Probe PLF limits at start-up

[PATCH 0/5] media: uvc: Probe PLF limits at start-up

Ricardo Ribalda posted 5 patches 1 year, 9 months ago

Diff against v2
Download series mbox

There is a newer version of this series

drivers/media/usb/uvc/uvc_ctrl.c   | 173 ++++++++++++++++++++++++-------------
drivers/media/usb/uvc/uvc_driver.c | 122 --------------------------
drivers/media/usb/uvc/uvcvideo.h   |  61 ++++++-------
3 files changed, 143 insertions(+), 213 deletions(-)

Expand all Fold all

[PATCH 0/5] media: uvc: Probe PLF limits at start-up

Posted by Ricardo Ribalda 1 year, 9 months ago

The UVC standard descries the values for the PLF control for its
versions 1.1 and and 1.5, but it does not describe which values MUST be
implemented.

So far, we have been adding "device quirks" to provide proper limits for
the control, but this is failing to scale.

Add a function that during probe-time checks the capability of the
control.

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
Ricardo Ribalda (5):
      media: uvcvideo: Allow custom control mapping
      media: uvcvideo: Refactor Power Line Frequency limit selection
      media: uvcvideo: Probe the PLF characteristics
      media: uvcvideo: Cleanup version-specific mapping
      media: uvcvideo: Remove PLF device quirking

 drivers/media/usb/uvc/uvc_ctrl.c   | 173 ++++++++++++++++++++++++-------------
 drivers/media/usb/uvc/uvc_driver.c | 122 --------------------------
 drivers/media/usb/uvc/uvcvideo.h   |  61 ++++++-------
 3 files changed, 143 insertions(+), 213 deletions(-)
---
base-commit: b14257abe7057def6127f6fb2f14f9adc8acabdb
change-id: 20240313-billion-5b2a45fa86f4

Best regards,
-- 
Ricardo Ribalda <ribalda@chromium.org>

Re: [PATCH 0/5] media: uvc: Probe PLF limits at start-up

Posted by Sergey Senozhatsky 1 year, 9 months ago

On (24/03/18 23:55), Ricardo Ribalda wrote:
> 
> The UVC standard descries the values for the PLF control for its
> versions 1.1 and and 1.5, but it does not describe which values MUST be
> implemented.
> 
> So far, we have been adding "device quirks" to provide proper limits for
> the control, but this is failing to scale.
> 
> Add a function that during probe-time checks the capability of the
> control.
> 
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>

Looks good to me

FWIW
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>