[PATCH] xfs: Fix typo in comment

Thorsten Blum posted 1 patch 1 year, 10 months ago
There is a newer version of this series
fs/xfs/xfs_log_priv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] xfs: Fix typo in comment
Posted by Thorsten Blum 1 year, 10 months ago
s/somethign/something/

Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
---
 fs/xfs/xfs_log_priv.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_log_priv.h b/fs/xfs/xfs_log_priv.h
index e30c06ec20e3..25b6d6cdd545 100644
--- a/fs/xfs/xfs_log_priv.h
+++ b/fs/xfs/xfs_log_priv.h
@@ -683,7 +683,7 @@ xlog_valid_lsn(
  * flags to control the kmalloc() behaviour within kvmalloc(). Hence kmalloc()
  * will do direct reclaim and compaction in the slow path, both of which are
  * horrendously expensive. We just want kmalloc to fail fast and fall back to
- * vmalloc if it can't get somethign straight away from the free lists or
+ * vmalloc if it can't get something straight away from the free lists or
  * buddy allocator. Hence we have to open code kvmalloc outselves here.
  *
  * This assumes that the caller uses memalloc_nofs_save task context here, so
-- 
2.44.0
Re: [PATCH] xfs: Fix typo in comment
Posted by Christoph Hellwig 1 year, 10 months ago
Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>
Re: [PATCH] xfs: Fix typo in comment
Posted by Randy Dunlap 1 year, 10 months ago
s/somethign/something/

Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
---
 fs/xfs/xfs_log_priv.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_log_priv.h b/fs/xfs/xfs_log_priv.h
index e30c06ec20e3..25b6d6cdd545 100644
--- a/fs/xfs/xfs_log_priv.h
+++ b/fs/xfs/xfs_log_priv.h
@@ -683,7 +683,7 @@ xlog_valid_lsn(
  * flags to control the kmalloc() behaviour within kvmalloc(). Hence kmalloc()
  * will do direct reclaim and compaction in the slow path, both of which are
  * horrendously expensive. We just want kmalloc to fail fast and fall back to
- * vmalloc if it can't get somethign straight away from the free lists or
+ * vmalloc if it can't get something straight away from the free lists or
  * buddy allocator. Hence we have to open code kvmalloc outselves here.
  *
  * This assumes that the caller uses memalloc_nofs_save task context here, so



Also s/straight away/straightaway/
or even use "immediately".

thanks.
-- 
#Randy
Re: [PATCH] xfs: Fix typo in comment
Posted by Thorsten Blum 1 year, 10 months ago
On 17. Mar 2024, at 22:53, Randy Dunlap <rdunlap@infradead.org> wrote:
> 
> Also s/straight away/straightaway/

Apparently, both are grammatically correct.

Thorsten
Re: [PATCH] xfs: Fix typo in comment
Posted by Randy Dunlap 1 year, 10 months ago

On 3/17/24 16:34, Thorsten Blum wrote:
> On 17. Mar 2024, at 22:53, Randy Dunlap <rdunlap@infradead.org> wrote:
>>
>> Also s/straight away/straightaway/
> 
> Apparently, both are grammatically correct.

OK :)

-- 
#Randy
[RESEND PATCH] xfs: Fix typo in comment
Posted by Thorsten Blum 1 year, 10 months ago
s/somethign/something/

Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
 fs/xfs/xfs_log_priv.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_log_priv.h b/fs/xfs/xfs_log_priv.h
index e30c06ec20e3..25b6d6cdd545 100644
--- a/fs/xfs/xfs_log_priv.h
+++ b/fs/xfs/xfs_log_priv.h
@@ -683,7 +683,7 @@ xlog_valid_lsn(
  * flags to control the kmalloc() behaviour within kvmalloc(). Hence kmalloc()
  * will do direct reclaim and compaction in the slow path, both of which are
  * horrendously expensive. We just want kmalloc to fail fast and fall back to
- * vmalloc if it can't get somethign straight away from the free lists or
+ * vmalloc if it can't get something straight away from the free lists or
  * buddy allocator. Hence we have to open code kvmalloc outselves here.
  *
  * This assumes that the caller uses memalloc_nofs_save task context here, so
-- 
2.44.0
Re: [PATCH] xfs: Fix typo in comment
Posted by Darrick J. Wong 1 year, 10 months ago
On Sun, Mar 17, 2024 at 04:47:32PM +0100, Thorsten Blum wrote:
> s/somethign/something/
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>

Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  fs/xfs/xfs_log_priv.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_log_priv.h b/fs/xfs/xfs_log_priv.h
> index e30c06ec20e3..25b6d6cdd545 100644
> --- a/fs/xfs/xfs_log_priv.h
> +++ b/fs/xfs/xfs_log_priv.h
> @@ -683,7 +683,7 @@ xlog_valid_lsn(
>   * flags to control the kmalloc() behaviour within kvmalloc(). Hence kmalloc()
>   * will do direct reclaim and compaction in the slow path, both of which are
>   * horrendously expensive. We just want kmalloc to fail fast and fall back to
> - * vmalloc if it can't get somethign straight away from the free lists or
> + * vmalloc if it can't get something straight away from the free lists or
>   * buddy allocator. Hence we have to open code kvmalloc outselves here.
>   *
>   * This assumes that the caller uses memalloc_nofs_save task context here, so
> -- 
> 2.44.0
> 
>