[PATCH] ubsan: Remove unused function

Jiapeng Chong posted 1 patch 1 year, 10 months ago
lib/test_ubsan.c | 5 -----
1 file changed, 5 deletions(-)
[PATCH] ubsan: Remove unused function
Posted by Jiapeng Chong 1 year, 10 months ago
The function are defined in the test_ubsan.c file, but not called
elsewhere, so delete the unused function.

lib/test_ubsan.c:137:28: warning: unused variable 'skip_ubsan_array'.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8541
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 lib/test_ubsan.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/lib/test_ubsan.c b/lib/test_ubsan.c
index 276c12140ee2..be335a93224f 100644
--- a/lib/test_ubsan.c
+++ b/lib/test_ubsan.c
@@ -133,11 +133,6 @@ static const test_ubsan_fp test_ubsan_array[] = {
 	test_ubsan_misaligned_access,
 };
 
-/* Excluded because they Oops the module. */
-static const test_ubsan_fp skip_ubsan_array[] = {
-	test_ubsan_divrem_overflow,
-};
-
 static int __init test_ubsan_init(void)
 {
 	unsigned int i;
-- 
2.20.1.7.g153144c
Re: [PATCH] ubsan: Remove unused function
Posted by Kees Cook 1 year, 10 months ago
On Fri, Mar 15, 2024 at 09:53:47AM +0800, Jiapeng Chong wrote:
> The function are defined in the test_ubsan.c file, but not called
> elsewhere, so delete the unused function.
> 
> lib/test_ubsan.c:137:28: warning: unused variable 'skip_ubsan_array'.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8541
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  lib/test_ubsan.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/lib/test_ubsan.c b/lib/test_ubsan.c
> index 276c12140ee2..be335a93224f 100644
> --- a/lib/test_ubsan.c
> +++ b/lib/test_ubsan.c
> @@ -133,11 +133,6 @@ static const test_ubsan_fp test_ubsan_array[] = {
>  	test_ubsan_misaligned_access,
>  };
>  
> -/* Excluded because they Oops the module. */
> -static const test_ubsan_fp skip_ubsan_array[] = {
> -	test_ubsan_divrem_overflow,
> -};

But then I'll get warnings about test_ubsan_divrem_overflow() being
defined and not used. :)

-Kees

> -
>  static int __init test_ubsan_init(void)
>  {
>  	unsigned int i;
> -- 
> 2.20.1.7.g153144c
> 

-- 
Kees Cook