gpiolib: use dev_err when gpiod_configure_flags failed

[PATCH] gpiolib: use dev_err when gpiod_configure_flags failed

Posted by Peng Fan (OSS) 1 year, 11 months ago

From: Peng Fan <peng.fan@nxp.com>

Using dev_err to show error message will make life easier.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 drivers/gpio/gpiolib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index ce94e37bcbee..37fe9db0bd74 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -4233,7 +4233,7 @@ struct gpio_desc *gpiod_find_and_request(struct device *consumer,
 
 	ret = gpiod_configure_flags(desc, con_id, lookupflags, flags);
 	if (ret < 0) {
-		dev_dbg(consumer, "setup of GPIO %s failed\n", con_id);
+		dev_err(consumer, "setup of GPIO %s failed: %d\n", con_id, ret);
 		gpiod_put(desc);
 		return ERR_PTR(ret);
 	}
-- 
2.37.1

Re: [PATCH] gpiolib: use dev_err when gpiod_configure_flags failed

Posted by Andy Shevchenko 1 year, 10 months ago

On Fri, Mar 15, 2024 at 3:02 AM Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote:
>
> From: Peng Fan <peng.fan@nxp.com>
>
> Using dev_err to show error message will make life easier.

dev_err()

an error

...

It's unclear what the use case is and how this does make life easier.
We need to know more!

-- 
With Best Regards,
Andy Shevchenko