[PATCH 4.19 00/41] 4.19.310-rc1 review

Sasha Levin posted 41 patches 1 year, 9 months ago
Makefile                                 |   4 +-
arch/alpha/kernel/osf_sys.c              |   2 +-
arch/um/Kconfig                          |  13 +
arch/um/Makefile                         |   3 +-
arch/x86/Makefile.um                     |   2 +-
drivers/input/serio/i8042-x86ia64io.h    |   6 +
drivers/net/geneve.c                     |  18 +-
drivers/net/hyperv/netvsc_drv.c          |  96 ++-
drivers/net/loopback.c                   |   6 -
drivers/net/nlmon.c                      |   6 -
drivers/net/usb/lan78xx.c                | 966 +++++++++++++++++------
drivers/net/vsockmon.c                   |  14 +-
fs/btrfs/ref-verify.c                    |   6 +-
include/linux/netdevice.h                |   6 +
include/uapi/linux/resource.h            |   4 +-
kernel/exit.c                            |  12 +-
kernel/sys.c                             |  91 ++-
net/ipv6/route.c                         |  21 +-
net/netfilter/nf_conntrack_h323_asn1.c   |   4 +
net/netrom/af_netrom.c                   |  14 +-
net/netrom/nr_dev.c                      |   2 +-
net/netrom/nr_in.c                       |   6 +-
net/netrom/nr_out.c                      |   2 +-
net/netrom/nr_route.c                    |   8 +-
net/netrom/nr_subr.c                     |   5 +-
net/rds/rdma.c                           |   3 +
net/rds/send.c                           |   6 +-
tools/testing/selftests/vm/map_hugetlb.c |  50 +-
28 files changed, 994 insertions(+), 382 deletions(-)
[PATCH 4.19 00/41] 4.19.310-rc1 review
Posted by Sasha Levin 1 year, 9 months ago
This is the start of the stable review cycle for the 4.19.310 release.
There are 41 patches in this series, all will be posted as a response
to this one.  If anyone has any issues with these being applied, please
let me know.

Responses should be made by Fri Mar 15 05:04:34 PM UTC 2024.
Anything received after that time might be too late.

The whole patch series can be found in one patch at:
        https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/patch/?id=linux-4.19.y&id2=v4.19.309
or in the git tree and branch at:
        git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
and the diffstat can be found below.

Thanks,
Sasha

-------------
Pseudo-Shortlog of commits:

Arnd Bergmann (1):
  y2038: rusage: use __kernel_old_timeval

Christophe Leroy (3):
  tools/selftest/vm: allow choosing mem size and page size in
    map_hugetlb
  selftests/vm: fix display of page size in map_hugetlb
  selftests/vm: fix map_hugetlb length used for testing read and write

Dexuan Cui (1):
  hv_netvsc: Make netvsc/VF binding check both MAC and serial number

Edward Adam Davis (1):
  net/rds: fix WARNING in rds_conn_connect_if_down

Eric Dumazet (2):
  geneve: make sure to pull inner header in geneve_rx()
  net/ipv6: avoid possible UAF in ip6_route_mpath_notify()

Fedor Pchelkin (1):
  btrfs: ref-verify: free ref cache before clearing mount opt

Ingo Molnar (1):
  exit: Fix typo in comment: s/sub-theads/sub-threads

Jason Xing (12):
  netrom: Fix a data-race around sysctl_netrom_default_path_quality
  netrom: Fix a data-race around
    sysctl_netrom_obsolescence_count_initialiser
  netrom: Fix data-races around sysctl_netrom_network_ttl_initialiser
  netrom: Fix a data-race around sysctl_netrom_transport_timeout
  netrom: Fix a data-race around sysctl_netrom_transport_maximum_tries
  netrom: Fix a data-race around
    sysctl_netrom_transport_acknowledge_delay
  netrom: Fix a data-race around sysctl_netrom_transport_busy_delay
  netrom: Fix a data-race around
    sysctl_netrom_transport_requested_window_size
  netrom: Fix a data-race around
    sysctl_netrom_transport_no_activity_timeout
  netrom: Fix a data-race around sysctl_netrom_routing_control
  netrom: Fix a data-race around sysctl_netrom_link_fails_count
  netrom: Fix data-races around sysctl_net_busy_read

Johannes Berg (1):
  um: allow not setting extra rpaths in the linux binary

John Efstathiades (4):
  lan78xx: Fix white space and style issues
  lan78xx: Add missing return code checks
  lan78xx: Fix partial packet errors on suspend/resume
  lan78xx: Fix race conditions in suspend/resume handling

Juhee Kang (1):
  hv_netvsc: use netif_is_bond_master() instead of open code

Lee Jones (1):
  net: usb: lan78xx: Remove lots of set but unused 'ret' variables

Lena Wang (1):
  netfilter: nf_conntrack_h323: Add protection for bmp length out of
    range

Li RongQing (1):
  net: move definition of pcpu_lstats to header file

Nico Pache (1):
  selftests: mm: fix map_hugetlb failure on 64K page size systems

Oleg Nesterov (5):
  getrusage: add the "signal_struct *sig" local variable
  getrusage: move thread_group_cputime_adjusted() outside of
    lock_task_sighand()
  getrusage: use __for_each_thread()
  getrusage: use sig->stats_lock rather than lock_task_sighand()
  exit: wait_task_zombie: kill the no longer necessary
    spin_lock_irq(siglock)

Oleksij Rempel (1):
  net: lan78xx: fix runtime PM count underflow on link stop

Sasha Levin (1):
  Linux 4.19.310-rc1

Shradha Gupta (1):
  hv_netvsc: Register VF in netvsc_probe if NET_DEVICE_REGISTER missed

Werner Sembach (1):
  Input: i8042 - fix strange behavior of touchpad on Clevo NS70PU

 Makefile                                 |   4 +-
 arch/alpha/kernel/osf_sys.c              |   2 +-
 arch/um/Kconfig                          |  13 +
 arch/um/Makefile                         |   3 +-
 arch/x86/Makefile.um                     |   2 +-
 drivers/input/serio/i8042-x86ia64io.h    |   6 +
 drivers/net/geneve.c                     |  18 +-
 drivers/net/hyperv/netvsc_drv.c          |  96 ++-
 drivers/net/loopback.c                   |   6 -
 drivers/net/nlmon.c                      |   6 -
 drivers/net/usb/lan78xx.c                | 966 +++++++++++++++++------
 drivers/net/vsockmon.c                   |  14 +-
 fs/btrfs/ref-verify.c                    |   6 +-
 include/linux/netdevice.h                |   6 +
 include/uapi/linux/resource.h            |   4 +-
 kernel/exit.c                            |  12 +-
 kernel/sys.c                             |  91 ++-
 net/ipv6/route.c                         |  21 +-
 net/netfilter/nf_conntrack_h323_asn1.c   |   4 +
 net/netrom/af_netrom.c                   |  14 +-
 net/netrom/nr_dev.c                      |   2 +-
 net/netrom/nr_in.c                       |   6 +-
 net/netrom/nr_out.c                      |   2 +-
 net/netrom/nr_route.c                    |   8 +-
 net/netrom/nr_subr.c                     |   5 +-
 net/rds/rdma.c                           |   3 +
 net/rds/send.c                           |   6 +-
 tools/testing/selftests/vm/map_hugetlb.c |  50 +-
 28 files changed, 994 insertions(+), 382 deletions(-)

-- 
2.43.0
Re: [PATCH 4.19 00/41] 4.19.310-rc1 review
Posted by Pavel Machek 1 year, 9 months ago
Hi!

> This is the start of the stable review cycle for the 4.19.310 release.
> There are 41 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.

CIP testing did not find any problems here:

https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.19.y

Tested-by: Pavel Machek (CIP) <pavel@denx.de>

5.15, 5.4, 6.6 and 6.7 seem to be ok, too.

Best regards,
                                                                Pavel

-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Re: [PATCH 4.19 00/41] 4.19.310-rc1 review
Posted by Guenter Roeck 1 year, 9 months ago
On 3/13/24 10:03, Sasha Levin wrote:
> 
> This is the start of the stable review cycle for the 4.19.310 release.
> There are 41 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Fri Mar 15 05:04:34 PM UTC 2024.
> Anything received after that time might be too late.
> 
> The whole patch series can be found in one patch at:
>          https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/patch/?id=linux-4.19.y&id2=v4.19.309
> or in the git tree and branch at:
>          git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> and the diffstat can be found below.
> 
> Thanks,
> Sasha
> 
> -------------
> Pseudo-Shortlog of commits:
> 
> Arnd Bergmann (1):
>    y2038: rusage: use __kernel_old_timeval
> 

Guess this wasn't build tested on alpha, making it unbuildable on v4.19.y.

Building alpha:defconfig ... failed
--------------
Error log:
arch/alpha/kernel/osf_sys.c: In function '__do_sys_old_adjtimex':
arch/alpha/kernel/osf_sys.c:1274:43: error: passing argument 2 of 'put_tv_to_tv32' from incompatible pointer type

Guenter
Re: [PATCH 4.19 00/41] 4.19.310-rc1 review
Posted by Guenter Roeck 1 year, 9 months ago
On 3/16/24 13:57, Guenter Roeck wrote:
> On 3/13/24 10:03, Sasha Levin wrote:
>>
>> This is the start of the stable review cycle for the 4.19.310 release.
>> There are 41 patches in this series, all will be posted as a response
>> to this one.  If anyone has any issues with these being applied, please
>> let me know.
>>
>> Responses should be made by Fri Mar 15 05:04:34 PM UTC 2024.
>> Anything received after that time might be too late.
>>
>> The whole patch series can be found in one patch at:
>>          https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/patch/?id=linux-4.19.y&id2=v4.19.309
>> or in the git tree and branch at:
>>          git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
>> and the diffstat can be found below.
>>
>> Thanks,
>> Sasha
>>
>> -------------
>> Pseudo-Shortlog of commits:
>>
>> Arnd Bergmann (1):
>>    y2038: rusage: use __kernel_old_timeval
>>
> 
> Guess this wasn't build tested on alpha, making it unbuildable on v4.19.y.
> 
> Building alpha:defconfig ... failed
> --------------
> Error log:
> arch/alpha/kernel/osf_sys.c: In function '__do_sys_old_adjtimex':
> arch/alpha/kernel/osf_sys.c:1274:43: error: passing argument 2 of 'put_tv_to_tv32' from incompatible pointer type
> 

Following up on this, I now dropped build and boot testing of 'alpha'
targets for v4.19.y.

Guenter

Re: [PATCH 4.19 00/41] 4.19.310-rc1 review
Posted by Greg KH 1 year, 8 months ago
On Tue, Mar 19, 2024 at 07:24:37AM -0700, Guenter Roeck wrote:
> On 3/16/24 13:57, Guenter Roeck wrote:
> > On 3/13/24 10:03, Sasha Levin wrote:
> > > 
> > > This is the start of the stable review cycle for the 4.19.310 release.
> > > There are 41 patches in this series, all will be posted as a response
> > > to this one.  If anyone has any issues with these being applied, please
> > > let me know.
> > > 
> > > Responses should be made by Fri Mar 15 05:04:34 PM UTC 2024.
> > > Anything received after that time might be too late.
> > > 
> > > The whole patch series can be found in one patch at:
> > >          https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/patch/?id=linux-4.19.y&id2=v4.19.309
> > > or in the git tree and branch at:
> > >          git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> > > and the diffstat can be found below.
> > > 
> > > Thanks,
> > > Sasha
> > > 
> > > -------------
> > > Pseudo-Shortlog of commits:
> > > 
> > > Arnd Bergmann (1):
> > >    y2038: rusage: use __kernel_old_timeval
> > > 
> > 
> > Guess this wasn't build tested on alpha, making it unbuildable on v4.19.y.
> > 
> > Building alpha:defconfig ... failed
> > --------------
> > Error log:
> > arch/alpha/kernel/osf_sys.c: In function '__do_sys_old_adjtimex':
> > arch/alpha/kernel/osf_sys.c:1274:43: error: passing argument 2 of 'put_tv_to_tv32' from incompatible pointer type
> > 
> 
> Following up on this, I now dropped build and boot testing of 'alpha'
> targets for v4.19.y.

Ok, let me go unwind this and try to fix this up in the next set of 4.19
stable -rc updates...

thanks,

greg k-h
Re: [PATCH 4.19 00/41] 4.19.310-rc1 review
Posted by Greg KH 1 year, 8 months ago
On Sat, Mar 30, 2024 at 10:19:56AM +0100, Greg KH wrote:
> On Tue, Mar 19, 2024 at 07:24:37AM -0700, Guenter Roeck wrote:
> > On 3/16/24 13:57, Guenter Roeck wrote:
> > > On 3/13/24 10:03, Sasha Levin wrote:
> > > > 
> > > > This is the start of the stable review cycle for the 4.19.310 release.
> > > > There are 41 patches in this series, all will be posted as a response
> > > > to this one.  If anyone has any issues with these being applied, please
> > > > let me know.
> > > > 
> > > > Responses should be made by Fri Mar 15 05:04:34 PM UTC 2024.
> > > > Anything received after that time might be too late.
> > > > 
> > > > The whole patch series can be found in one patch at:
> > > >          https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/patch/?id=linux-4.19.y&id2=v4.19.309
> > > > or in the git tree and branch at:
> > > >          git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> > > > and the diffstat can be found below.
> > > > 
> > > > Thanks,
> > > > Sasha
> > > > 
> > > > -------------
> > > > Pseudo-Shortlog of commits:
> > > > 
> > > > Arnd Bergmann (1):
> > > >    y2038: rusage: use __kernel_old_timeval
> > > > 
> > > 
> > > Guess this wasn't build tested on alpha, making it unbuildable on v4.19.y.
> > > 
> > > Building alpha:defconfig ... failed
> > > --------------
> > > Error log:
> > > arch/alpha/kernel/osf_sys.c: In function '__do_sys_old_adjtimex':
> > > arch/alpha/kernel/osf_sys.c:1274:43: error: passing argument 2 of 'put_tv_to_tv32' from incompatible pointer type
> > > 
> > 
> > Following up on this, I now dropped build and boot testing of 'alpha'
> > targets for v4.19.y.
> 
> Ok, let me go unwind this and try to fix this up in the next set of 4.19
> stable -rc updates...

I tried, and it's just too messy.  Given that alpha really is a dead
architecture, and 4.19.y is only going to be around for a few more
months, and that the 2-3 alpha users out there can move to 5.4 (and
really should not be using 4.19 anyway), I'm just going to leave this
as-is (i.e. broken.)

thanks,

greg k-h
[PATCH 4.19] Revert "y2038: rusage: use __kernel_old_timeval"
Posted by Ben Hutchings 1 year, 7 months ago
This reverts commit d5e38d6b84d6d21a4f8a4f555a0908b6d9ffe224, which
was commit bdd565f817a74b9e30edec108f7cb1dbc762b8a6 upstream.  It
broke the build for alpha and that can't be fixed without backporting
other more intrusive y2038 changes.

This was not a completely clean revert as the affected code in
getrusage() was moved by subsequent changes.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
 arch/alpha/kernel/osf_sys.c   | 2 +-
 include/uapi/linux/resource.h | 4 ++--
 kernel/sys.c                  | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/alpha/kernel/osf_sys.c b/arch/alpha/kernel/osf_sys.c
index d5694f263dd6..cff52d8ffdb1 100644
--- a/arch/alpha/kernel/osf_sys.c
+++ b/arch/alpha/kernel/osf_sys.c
@@ -964,7 +964,7 @@ put_tv32(struct timeval32 __user *o, struct timespec64 *i)
 }
 
 static inline long
-put_tv_to_tv32(struct timeval32 __user *o, struct __kernel_old_timeval *i)
+put_tv_to_tv32(struct timeval32 __user *o, struct timeval *i)
 {
 	return copy_to_user(o, &(struct timeval32){
 				.tv_sec = i->tv_sec,
diff --git a/include/uapi/linux/resource.h b/include/uapi/linux/resource.h
index 74ef57b38f9f..cc00fd079631 100644
--- a/include/uapi/linux/resource.h
+++ b/include/uapi/linux/resource.h
@@ -22,8 +22,8 @@
 #define	RUSAGE_THREAD	1		/* only the calling thread */
 
 struct	rusage {
-	struct __kernel_old_timeval ru_utime;	/* user time used */
-	struct __kernel_old_timeval ru_stime;	/* system time used */
+	struct timeval ru_utime;	/* user time used */
+	struct timeval ru_stime;	/* system time used */
 	__kernel_long_t	ru_maxrss;	/* maximum resident set size */
 	__kernel_long_t	ru_ixrss;	/* integral shared memory size */
 	__kernel_long_t	ru_idrss;	/* integral unshared data size */
diff --git a/kernel/sys.c b/kernel/sys.c
index 62930aac0bad..690ab55449e7 100644
--- a/kernel/sys.c
+++ b/kernel/sys.c
@@ -1795,8 +1795,8 @@ void getrusage(struct task_struct *p, int who, struct rusage *r)
 
 out_children:
 	r->ru_maxrss = maxrss * (PAGE_SIZE / 1024); /* convert pages to KBs */
-	r->ru_utime = ns_to_kernel_old_timeval(utime);
-	r->ru_stime = ns_to_kernel_old_timeval(stime);
+	r->ru_utime = ns_to_timeval(utime);
+	r->ru_stime = ns_to_timeval(stime);
 }
 
 SYSCALL_DEFINE2(getrusage, int, who, struct rusage __user *, ru)
Re: [PATCH 4.19 00/41] 4.19.310-rc1 review
Posted by Naresh Kamboju 1 year, 9 months ago
On Wed, 13 Mar 2024 at 22:34, Sasha Levin <sashal@kernel.org> wrote:
>
>
> This is the start of the stable review cycle for the 4.19.310 release.
> There are 41 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Fri Mar 15 05:04:34 PM UTC 2024.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
>         https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/patch/?id=linux-4.19.y&id2=v4.19.309
> or in the git tree and branch at:
>         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> and the diffstat can be found below.
>
> Thanks,
> Sasha

Results from Linaro’s test farm.
No regressions on arm64, arm, x86_64, and i386.

Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>

## Build
* kernel: 4.19.310-rc1
* git: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc
* git branch: linux-4.19.y
* git commit: f1886f673a708e0b053e08ac007aa8785d7f128d
* git describe: v4.19.309-41-gf1886f673a70
* test details:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-4.19.y/build/v4.19.309-41-gf1886f673a70

## Test Regressions (compared to v4.19.309)

## Metric Regressions (compared to v4.19.309)

## Test Fixes (compared to v4.19.309)

## Metric Fixes (compared to v4.19.309)

## Test result summary
total: 47695, pass: 41616, fail: 867, skip: 5180, xfail: 32

## Build Summary
* arc: 10 total, 10 passed, 0 failed
* arm: 106 total, 99 passed, 7 failed
* arm64: 31 total, 25 passed, 6 failed
* i386: 18 total, 15 passed, 3 failed
* mips: 23 total, 22 passed, 1 failed
* parisc: 4 total, 0 passed, 4 failed
* powerpc: 27 total, 26 passed, 1 failed
* s390: 8 total, 8 passed, 0 failed
* sh: 12 total, 12 passed, 0 failed
* sparc: 8 total, 8 passed, 0 failed
* x86_64: 27 total, 21 passed, 6 failed

## Test suites summary
* boot
* kselftest-android
* kselftest-breakpoints
* kselftest-capabilities
* kselftest-cgroup
* kselftest-clone3
* kselftest-core
* kselftest-cpu-hotplug
* kselftest-cpufreq
* kselftest-drivers-dma-buf
* kselftest-efivarfs
* kselftest-filesystems
* kselftest-filesystems-binderfs
* kselftest-filesystems-epoll
* kselftest-firmware
* kselftest-fpu
* kselftest-ftrace
* kselftest-futex
* kselftest-gpio
* kselftest-ipc
* kselftest-ir
* kselftest-kcmp
* kselftest-kexec
* kselftest-lib
* kselftest-membarrier
* kselftest-memfd
* kselftest-memory-hotplug
* kselftest-mincore
* kselftest-mm
* kselftest-mount
* kselftest-mqueue
* kselftest-net
* kselftest-net-forwarding
* kselftest-net-mptcp
* kselftest-netfilter
* kselftest-nsfs
* kselftest-openat2
* kselftest-pid_namespace
* kselftest-pidfd
* kselftest-proc
* kselftest-pstore
* kselftest-rseq
* kselftest-rtc
* kselftest-seccomp
* kselftest-sigaltstack
* kselftest-size
* kselftest-splice
* kselftest-static_keys
* kselftest-sync
* kselftest-sysctl
* kselftest-tc-testing
* kselftest-timens
* kselftest-user
* kselftest-zram
* kunit
* log-parser-boot
* log-parser-test
* ltp-cap_bounds
* ltp-commands
* ltp-containers
* ltp-controllers
* ltp-crypto
* ltp-cve
* ltp-dio
* ltp-fcntl-locktests
* ltp-filecaps
* ltp-fs
* ltp-fs_bind
* ltp-fs_perms_simple
* ltp-hugetlb
* ltp-io
* ltp-ipc
* ltp-math
* ltp-mm
* ltp-nptl
* ltp-pty
* ltp-sched
* ltp-securebits
* ltp-smoke
* ltp-smoketest
* ltp-syscalls
* ltp-tracing
* rcutorture

--
Linaro LKFT
https://lkft.linaro.org