[PATCH v2 01/15] sched/core: Add clearing of ->dl_server in put_prev_task_balance()

Joel Fernandes (Google) posted 15 patches 1 year, 11 months ago
[PATCH v2 01/15] sched/core: Add clearing of ->dl_server in put_prev_task_balance()
Posted by Joel Fernandes (Google) 1 year, 11 months ago
Paths using put_prev_task_balance() need to do a pick shortly after. Make sure
they also clear the ->dl_server on prev as a part of that.

Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
---
 kernel/sched/core.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 973fd610d089..7f3a2596c1ed 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -5998,6 +5998,14 @@ static void put_prev_task_balance(struct rq *rq, struct task_struct *prev,
 #endif
 
 	put_prev_task(rq, prev);
+
+	/*
+	 * We've updated @prev and no longer need the server link, clear it.
+	 * Must be done before ->pick_next_task() because that can (re)set
+	 * ->dl_server.
+	 */
+	if (prev->dl_server)
+		prev->dl_server = NULL;
 }
 
 /*
@@ -6041,14 +6049,6 @@ __pick_next_task(struct rq *rq, struct task_struct *prev, struct rq_flags *rf)
 restart:
 	put_prev_task_balance(rq, prev, rf);
 
-	/*
-	 * We've updated @prev and no longer need the server link, clear it.
-	 * Must be done before ->pick_next_task() because that can (re)set
-	 * ->dl_server.
-	 */
-	if (prev->dl_server)
-		prev->dl_server = NULL;
-
 	for_each_class(class) {
 		p = class->pick_next_task(rq);
 		if (p)
-- 
2.34.1
Re: [PATCH v2 01/15] sched/core: Add clearing of ->dl_server in put_prev_task_balance()
Posted by Daniel Bristot de Oliveira 1 year, 10 months ago
On 3/13/24 02:24, Joel Fernandes (Google) wrote:
> Paths using put_prev_task_balance() need to do a pick shortly after. Make sure
> they also clear the ->dl_server on prev as a part of that.
> > Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>

Makes sense. Added to the v6.

-- Daniel