Replace bit shift operations with BIT macro, to fix warning
CHECK: Prefer using the BIT macro
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
drivers/staging/rtl8192e/rtllib.h | 62 +++++++++++++++----------------
1 file changed, 31 insertions(+), 31 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 0809af3fd041..5c00d663193f 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -419,19 +419,19 @@ enum _REG_PREAMBLE_MODE {
#define WLAN_AUTH_SHARED_KEY 1
#define WLAN_AUTH_LEAP 128
-#define WLAN_CAPABILITY_ESS (1<<0)
-#define WLAN_CAPABILITY_IBSS (1<<1)
-#define WLAN_CAPABILITY_PRIVACY (1<<4)
-#define WLAN_CAPABILITY_SHORT_PREAMBLE (1<<5)
-#define WLAN_CAPABILITY_SHORT_SLOT_TIME (1<<10)
-
-#define RTLLIB_STATMASK_SIGNAL (1<<0)
-#define RTLLIB_STATMASK_RSSI (1<<1)
-#define RTLLIB_STATMASK_NOISE (1<<2)
+#define WLAN_CAPABILITY_ESS BIT(0)
+#define WLAN_CAPABILITY_IBSS BIT(1)
+#define WLAN_CAPABILITY_PRIVACY BIT(4)
+#define WLAN_CAPABILITY_SHORT_PREAMBLE BIT(5)
+#define WLAN_CAPABILITY_SHORT_SLOT_TIME BIT(10)
+
+#define RTLLIB_STATMASK_SIGNAL BIT(0)
+#define RTLLIB_STATMASK_RSSI BIT(1)
+#define RTLLIB_STATMASK_NOISE BIT(2)
#define RTLLIB_STATMASK_WEMASK 0x7
-#define RTLLIB_CCK_MODULATION (1<<0)
-#define RTLLIB_OFDM_MODULATION (1<<1)
+#define RTLLIB_CCK_MODULATION BIT(0)
+#define RTLLIB_OFDM_MODULATION BIT(1)
#define RTLLIB_CCK_RATE_LEN 4
#define RTLLIB_CCK_RATE_1MB 0x02
@@ -518,11 +518,11 @@ struct rtllib_frag_entry {
struct rtllib_device;
-#define SEC_ACTIVE_KEY (1<<4)
-#define SEC_AUTH_MODE (1<<5)
-#define SEC_UNICAST_GROUP (1<<6)
-#define SEC_LEVEL (1<<7)
-#define SEC_ENABLED (1<<8)
+#define SEC_ACTIVE_KEY BIT(4)
+#define SEC_AUTH_MODE BIT(5)
+#define SEC_UNICAST_GROUP BIT(6)
+#define SEC_LEVEL BIT(7)
+#define SEC_ENABLED BIT(8)
#define SEC_LEVEL_0 0 /* None */
#define SEC_LEVEL_1 1 /* WEP 40 and 104 bit */
@@ -707,17 +707,17 @@ union frameqos {
#define MAX_WPA_IE_LEN 64
#define MAX_WZC_IE_LEN 256
-#define NETWORK_EMPTY_ESSID (1<<0)
-#define NETWORK_HAS_OFDM (1<<1)
-#define NETWORK_HAS_CCK (1<<2)
+#define NETWORK_EMPTY_ESSID BIT(0)
+#define NETWORK_HAS_OFDM BIT(1)
+#define NETWORK_HAS_CCK BIT(2)
/* QoS structure */
-#define NETWORK_HAS_QOS_PARAMETERS (1<<3)
-#define NETWORK_HAS_QOS_INFORMATION (1<<4)
+#define NETWORK_HAS_QOS_PARAMETERS BIT(3)
+#define NETWORK_HAS_QOS_INFORMATION BIT(4)
#define NETWORK_HAS_QOS_MASK (NETWORK_HAS_QOS_PARAMETERS | \
NETWORK_HAS_QOS_INFORMATION)
/* 802.11h */
-#define NETWORK_HAS_ERP_VALUE (1<<10)
+#define NETWORK_HAS_ERP_VALUE BIT(10)
#define QOS_QUEUE_NUM 4
#define QOS_OUI_LEN 3
@@ -1007,8 +1007,8 @@ enum rtl_link_state {
#define DEFAULT_MAX_SCAN_AGE (15 * HZ)
#define DEFAULT_FTS 2346
-#define CFG_RTLLIB_RESERVE_FCS (1<<0)
-#define CFG_RTLLIB_COMPUTE_FCS (1<<1)
+#define CFG_RTLLIB_RESERVE_FCS BIT(0)
+#define CFG_RTLLIB_COMPUTE_FCS BIT(1)
struct tx_pending {
int frag;
@@ -1497,32 +1497,32 @@ struct rtllib_device {
/* Uses the channel change callback directly
* instead of [start/stop] scan callbacks
*/
-#define IEEE_SOFTMAC_SCAN (1<<2)
+#define IEEE_SOFTMAC_SCAN BIT(2)
/* Perform authentication and association handshake */
-#define IEEE_SOFTMAC_ASSOCIATE (1<<3)
+#define IEEE_SOFTMAC_ASSOCIATE BIT(3)
/* Generate probe requests */
-#define IEEE_SOFTMAC_PROBERQ (1<<4)
+#define IEEE_SOFTMAC_PROBERQ BIT(4)
/* Generate response to probe requests */
-#define IEEE_SOFTMAC_PROBERS (1<<5)
+#define IEEE_SOFTMAC_PROBERS BIT(5)
/* The ieee802.11 stack will manage the netif queue
* wake/stop for the driver, taking care of 802.11
* fragmentation. See softmac.c for details.
*/
-#define IEEE_SOFTMAC_TX_QUEUE (1<<7)
+#define IEEE_SOFTMAC_TX_QUEUE BIT(7)
/* Uses only the softmac_data_hard_start_xmit
* even for TX management frames.
*/
-#define IEEE_SOFTMAC_SINGLE_QUEUE (1<<8)
+#define IEEE_SOFTMAC_SINGLE_QUEUE BIT(8)
/* Generate beacons. The stack will enqueue beacons
* to the card
*/
-#define IEEE_SOFTMAC_BEACONS (1<<6)
+#define IEEE_SOFTMAC_BEACONS BIT(6)
static inline void *rtllib_priv(struct net_device *dev)
{
--
2.30.2Hi Tree,
kernel test robot noticed the following build warnings:
[auto build test WARNING on staging/staging-testing]
url: https://github.com/intel-lab-lkp/linux/commits/Tree-Davies/Staging-rtl8192e-Rename-variable-ReturnPoint/20240311-075949
base: staging/staging-testing
patch link: https://lore.kernel.org/r/20240310235552.4217-12-tdavies%40darkphysics.net
patch subject: [PATCH 11/11] Staging: rtl8192e: Implement BIT macro for bit shift ops
config: powerpc-allyesconfig (https://download.01.org/0day-ci/archive/20240311/202403111745.3SiSUhkl-lkp@intel.com/config)
compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project 503c55e17037436dcd45ac69dea8967e67e3f5e8)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240311/202403111745.3SiSUhkl-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403111745.3SiSUhkl-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from drivers/staging/rtl8192e/rtllib_module.c:18:
In file included from include/linux/if_arp.h:22:
In file included from include/linux/skbuff.h:17:
In file included from include/linux/bvec.h:10:
In file included from include/linux/highmem.h:8:
In file included from include/linux/cacheflush.h:5:
In file included from arch/powerpc/include/asm/cacheflush.h:7:
In file included from include/linux/mm.h:2188:
include/linux/vmstat.h:508:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
508 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
509 | item];
| ~~~~
include/linux/vmstat.h:515:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
515 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
516 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
include/linux/vmstat.h:522:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
522 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
include/linux/vmstat.h:527:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
527 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
528 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
include/linux/vmstat.h:536:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
536 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
537 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/staging/rtl8192e/rtllib_module.c:35:
>> drivers/staging/rtl8192e/rtllib.h:422:9: warning: 'WLAN_CAPABILITY_ESS' macro redefined [-Wmacro-redefined]
422 | #define WLAN_CAPABILITY_ESS BIT(0)
| ^
include/linux/ieee80211.h:3218:9: note: previous definition is here
3218 | #define WLAN_CAPABILITY_ESS (1<<0)
| ^
In file included from drivers/staging/rtl8192e/rtllib_module.c:35:
>> drivers/staging/rtl8192e/rtllib.h:423:9: warning: 'WLAN_CAPABILITY_IBSS' macro redefined [-Wmacro-redefined]
423 | #define WLAN_CAPABILITY_IBSS BIT(1)
| ^
include/linux/ieee80211.h:3219:9: note: previous definition is here
3219 | #define WLAN_CAPABILITY_IBSS (1<<1)
| ^
In file included from drivers/staging/rtl8192e/rtllib_module.c:35:
>> drivers/staging/rtl8192e/rtllib.h:424:9: warning: 'WLAN_CAPABILITY_PRIVACY' macro redefined [-Wmacro-redefined]
424 | #define WLAN_CAPABILITY_PRIVACY BIT(4)
| ^
include/linux/ieee80211.h:3231:9: note: previous definition is here
3231 | #define WLAN_CAPABILITY_PRIVACY (1<<4)
| ^
In file included from drivers/staging/rtl8192e/rtllib_module.c:35:
>> drivers/staging/rtl8192e/rtllib.h:425:9: warning: 'WLAN_CAPABILITY_SHORT_PREAMBLE' macro redefined [-Wmacro-redefined]
425 | #define WLAN_CAPABILITY_SHORT_PREAMBLE BIT(5)
| ^
include/linux/ieee80211.h:3232:9: note: previous definition is here
3232 | #define WLAN_CAPABILITY_SHORT_PREAMBLE (1<<5)
| ^
In file included from drivers/staging/rtl8192e/rtllib_module.c:35:
>> drivers/staging/rtl8192e/rtllib.h:426:9: warning: 'WLAN_CAPABILITY_SHORT_SLOT_TIME' macro redefined [-Wmacro-redefined]
426 | #define WLAN_CAPABILITY_SHORT_SLOT_TIME BIT(10)
| ^
include/linux/ieee80211.h:3239:9: note: previous definition is here
3239 | #define WLAN_CAPABILITY_SHORT_SLOT_TIME (1<<10)
| ^
10 warnings generated.
--
In file included from drivers/staging/rtl8192e/rtllib_crypt_tkip.c:15:
In file included from include/linux/skbuff.h:17:
In file included from include/linux/bvec.h:10:
In file included from include/linux/highmem.h:8:
In file included from include/linux/cacheflush.h:5:
In file included from arch/powerpc/include/asm/cacheflush.h:7:
In file included from include/linux/mm.h:2188:
include/linux/vmstat.h:508:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
508 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
509 | item];
| ~~~~
include/linux/vmstat.h:515:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
515 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
516 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
include/linux/vmstat.h:522:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
522 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
include/linux/vmstat.h:527:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
527 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
528 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
include/linux/vmstat.h:536:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
536 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
537 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/staging/rtl8192e/rtllib_crypt_tkip.c:23:
>> drivers/staging/rtl8192e/rtllib.h:422:9: warning: 'WLAN_CAPABILITY_ESS' macro redefined [-Wmacro-redefined]
422 | #define WLAN_CAPABILITY_ESS BIT(0)
| ^
include/linux/ieee80211.h:3218:9: note: previous definition is here
3218 | #define WLAN_CAPABILITY_ESS (1<<0)
| ^
In file included from drivers/staging/rtl8192e/rtllib_crypt_tkip.c:23:
>> drivers/staging/rtl8192e/rtllib.h:423:9: warning: 'WLAN_CAPABILITY_IBSS' macro redefined [-Wmacro-redefined]
423 | #define WLAN_CAPABILITY_IBSS BIT(1)
| ^
include/linux/ieee80211.h:3219:9: note: previous definition is here
3219 | #define WLAN_CAPABILITY_IBSS (1<<1)
| ^
In file included from drivers/staging/rtl8192e/rtllib_crypt_tkip.c:23:
>> drivers/staging/rtl8192e/rtllib.h:424:9: warning: 'WLAN_CAPABILITY_PRIVACY' macro redefined [-Wmacro-redefined]
424 | #define WLAN_CAPABILITY_PRIVACY BIT(4)
| ^
include/linux/ieee80211.h:3231:9: note: previous definition is here
3231 | #define WLAN_CAPABILITY_PRIVACY (1<<4)
| ^
In file included from drivers/staging/rtl8192e/rtllib_crypt_tkip.c:23:
>> drivers/staging/rtl8192e/rtllib.h:425:9: warning: 'WLAN_CAPABILITY_SHORT_PREAMBLE' macro redefined [-Wmacro-redefined]
425 | #define WLAN_CAPABILITY_SHORT_PREAMBLE BIT(5)
| ^
include/linux/ieee80211.h:3232:9: note: previous definition is here
3232 | #define WLAN_CAPABILITY_SHORT_PREAMBLE (1<<5)
| ^
In file included from drivers/staging/rtl8192e/rtllib_crypt_tkip.c:23:
>> drivers/staging/rtl8192e/rtllib.h:426:9: warning: 'WLAN_CAPABILITY_SHORT_SLOT_TIME' macro redefined [-Wmacro-redefined]
426 | #define WLAN_CAPABILITY_SHORT_SLOT_TIME BIT(10)
| ^
include/linux/ieee80211.h:3239:9: note: previous definition is here
3239 | #define WLAN_CAPABILITY_SHORT_SLOT_TIME (1<<10)
| ^
drivers/staging/rtl8192e/rtllib_crypt_tkip.c:641:7: warning: variable 'iv32' set but not used [-Wunused-but-set-variable]
641 | u32 iv32 = tkey->tx_iv32;
| ^
11 warnings generated.
--
In file included from drivers/staging/rtl8192e/rtllib_softmac_wx.c:16:
>> drivers/staging/rtl8192e/rtllib.h:422:9: warning: 'WLAN_CAPABILITY_ESS' macro redefined [-Wmacro-redefined]
422 | #define WLAN_CAPABILITY_ESS BIT(0)
| ^
include/linux/ieee80211.h:3218:9: note: previous definition is here
3218 | #define WLAN_CAPABILITY_ESS (1<<0)
| ^
In file included from drivers/staging/rtl8192e/rtllib_softmac_wx.c:16:
>> drivers/staging/rtl8192e/rtllib.h:423:9: warning: 'WLAN_CAPABILITY_IBSS' macro redefined [-Wmacro-redefined]
423 | #define WLAN_CAPABILITY_IBSS BIT(1)
| ^
include/linux/ieee80211.h:3219:9: note: previous definition is here
3219 | #define WLAN_CAPABILITY_IBSS (1<<1)
| ^
In file included from drivers/staging/rtl8192e/rtllib_softmac_wx.c:16:
>> drivers/staging/rtl8192e/rtllib.h:424:9: warning: 'WLAN_CAPABILITY_PRIVACY' macro redefined [-Wmacro-redefined]
424 | #define WLAN_CAPABILITY_PRIVACY BIT(4)
| ^
include/linux/ieee80211.h:3231:9: note: previous definition is here
3231 | #define WLAN_CAPABILITY_PRIVACY (1<<4)
| ^
In file included from drivers/staging/rtl8192e/rtllib_softmac_wx.c:16:
>> drivers/staging/rtl8192e/rtllib.h:425:9: warning: 'WLAN_CAPABILITY_SHORT_PREAMBLE' macro redefined [-Wmacro-redefined]
425 | #define WLAN_CAPABILITY_SHORT_PREAMBLE BIT(5)
| ^
include/linux/ieee80211.h:3232:9: note: previous definition is here
3232 | #define WLAN_CAPABILITY_SHORT_PREAMBLE (1<<5)
| ^
In file included from drivers/staging/rtl8192e/rtllib_softmac_wx.c:16:
>> drivers/staging/rtl8192e/rtllib.h:426:9: warning: 'WLAN_CAPABILITY_SHORT_SLOT_TIME' macro redefined [-Wmacro-redefined]
426 | #define WLAN_CAPABILITY_SHORT_SLOT_TIME BIT(10)
| ^
include/linux/ieee80211.h:3239:9: note: previous definition is here
3239 | #define WLAN_CAPABILITY_SHORT_SLOT_TIME (1<<10)
| ^
5 warnings generated.
--
In file included from drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c:10:
In file included from drivers/staging/rtl8192e/rtl8192e/rtl_core.h:18:
In file included from include/linux/interrupt.h:11:
In file included from include/linux/hardirq.h:11:
In file included from arch/powerpc/include/asm/hardirq.h:6:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:13:
In file included from arch/powerpc/include/asm/io.h:24:
In file included from include/linux/mm.h:2188:
include/linux/vmstat.h:508:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
508 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
509 | item];
| ~~~~
include/linux/vmstat.h:515:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
515 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
516 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
include/linux/vmstat.h:522:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
522 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
include/linux/vmstat.h:527:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
527 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
528 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
include/linux/vmstat.h:536:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
536 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
537 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c:10:
In file included from drivers/staging/rtl8192e/rtl8192e/rtl_core.h:35:
>> drivers/staging/rtl8192e/rtl8192e/../rtllib.h:422:9: warning: 'WLAN_CAPABILITY_ESS' macro redefined [-Wmacro-redefined]
422 | #define WLAN_CAPABILITY_ESS BIT(0)
| ^
include/linux/ieee80211.h:3218:9: note: previous definition is here
3218 | #define WLAN_CAPABILITY_ESS (1<<0)
| ^
In file included from drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c:10:
In file included from drivers/staging/rtl8192e/rtl8192e/rtl_core.h:35:
>> drivers/staging/rtl8192e/rtl8192e/../rtllib.h:423:9: warning: 'WLAN_CAPABILITY_IBSS' macro redefined [-Wmacro-redefined]
423 | #define WLAN_CAPABILITY_IBSS BIT(1)
| ^
include/linux/ieee80211.h:3219:9: note: previous definition is here
3219 | #define WLAN_CAPABILITY_IBSS (1<<1)
| ^
In file included from drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c:10:
In file included from drivers/staging/rtl8192e/rtl8192e/rtl_core.h:35:
>> drivers/staging/rtl8192e/rtl8192e/../rtllib.h:424:9: warning: 'WLAN_CAPABILITY_PRIVACY' macro redefined [-Wmacro-redefined]
424 | #define WLAN_CAPABILITY_PRIVACY BIT(4)
| ^
include/linux/ieee80211.h:3231:9: note: previous definition is here
3231 | #define WLAN_CAPABILITY_PRIVACY (1<<4)
| ^
In file included from drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c:10:
In file included from drivers/staging/rtl8192e/rtl8192e/rtl_core.h:35:
>> drivers/staging/rtl8192e/rtl8192e/../rtllib.h:425:9: warning: 'WLAN_CAPABILITY_SHORT_PREAMBLE' macro redefined [-Wmacro-redefined]
425 | #define WLAN_CAPABILITY_SHORT_PREAMBLE BIT(5)
| ^
include/linux/ieee80211.h:3232:9: note: previous definition is here
3232 | #define WLAN_CAPABILITY_SHORT_PREAMBLE (1<<5)
| ^
In file included from drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c:10:
In file included from drivers/staging/rtl8192e/rtl8192e/rtl_core.h:35:
>> drivers/staging/rtl8192e/rtl8192e/../rtllib.h:426:9: warning: 'WLAN_CAPABILITY_SHORT_SLOT_TIME' macro redefined [-Wmacro-redefined]
426 | #define WLAN_CAPABILITY_SHORT_SLOT_TIME BIT(10)
| ^
include/linux/ieee80211.h:3239:9: note: previous definition is here
3239 | #define WLAN_CAPABILITY_SHORT_SLOT_TIME (1<<10)
| ^
10 warnings generated.
vim +/WLAN_CAPABILITY_ESS +422 drivers/staging/rtl8192e/rtllib.h
421
> 422 #define WLAN_CAPABILITY_ESS BIT(0)
> 423 #define WLAN_CAPABILITY_IBSS BIT(1)
> 424 #define WLAN_CAPABILITY_PRIVACY BIT(4)
> 425 #define WLAN_CAPABILITY_SHORT_PREAMBLE BIT(5)
> 426 #define WLAN_CAPABILITY_SHORT_SLOT_TIME BIT(10)
427
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Hi Tree,
kernel test robot noticed the following build warnings:
[auto build test WARNING on staging/staging-testing]
url: https://github.com/intel-lab-lkp/linux/commits/Tree-Davies/Staging-rtl8192e-Rename-variable-ReturnPoint/20240311-075949
base: staging/staging-testing
patch link: https://lore.kernel.org/r/20240310235552.4217-12-tdavies%40darkphysics.net
patch subject: [PATCH 11/11] Staging: rtl8192e: Implement BIT macro for bit shift ops
config: arc-allmodconfig (https://download.01.org/0day-ci/archive/20240311/202403111451.mwNy2vqG-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240311/202403111451.mwNy2vqG-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403111451.mwNy2vqG-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from drivers/staging/rtl8192e/rtllib_module.c:35:
>> drivers/staging/rtl8192e/rtllib.h:422: warning: "WLAN_CAPABILITY_ESS" redefined
422 | #define WLAN_CAPABILITY_ESS BIT(0)
|
In file included from include/net/cfg80211.h:23,
from drivers/staging/rtl8192e/rtllib.h:40:
include/linux/ieee80211.h:3218: note: this is the location of the previous definition
3218 | #define WLAN_CAPABILITY_ESS (1<<0)
|
>> drivers/staging/rtl8192e/rtllib.h:423: warning: "WLAN_CAPABILITY_IBSS" redefined
423 | #define WLAN_CAPABILITY_IBSS BIT(1)
|
include/linux/ieee80211.h:3219: note: this is the location of the previous definition
3219 | #define WLAN_CAPABILITY_IBSS (1<<1)
|
>> drivers/staging/rtl8192e/rtllib.h:424: warning: "WLAN_CAPABILITY_PRIVACY" redefined
424 | #define WLAN_CAPABILITY_PRIVACY BIT(4)
|
include/linux/ieee80211.h:3231: note: this is the location of the previous definition
3231 | #define WLAN_CAPABILITY_PRIVACY (1<<4)
|
>> drivers/staging/rtl8192e/rtllib.h:425: warning: "WLAN_CAPABILITY_SHORT_PREAMBLE" redefined
425 | #define WLAN_CAPABILITY_SHORT_PREAMBLE BIT(5)
|
include/linux/ieee80211.h:3232: note: this is the location of the previous definition
3232 | #define WLAN_CAPABILITY_SHORT_PREAMBLE (1<<5)
|
>> drivers/staging/rtl8192e/rtllib.h:426: warning: "WLAN_CAPABILITY_SHORT_SLOT_TIME" redefined
426 | #define WLAN_CAPABILITY_SHORT_SLOT_TIME BIT(10)
|
include/linux/ieee80211.h:3239: note: this is the location of the previous definition
3239 | #define WLAN_CAPABILITY_SHORT_SLOT_TIME (1<<10)
|
--
In file included from drivers/staging/rtl8192e/rtllib_rx.c:36:
>> drivers/staging/rtl8192e/rtllib.h:422: warning: "WLAN_CAPABILITY_ESS" redefined
422 | #define WLAN_CAPABILITY_ESS BIT(0)
|
In file included from include/net/cfg80211.h:23,
from drivers/staging/rtl8192e/rtllib.h:40:
include/linux/ieee80211.h:3218: note: this is the location of the previous definition
3218 | #define WLAN_CAPABILITY_ESS (1<<0)
|
>> drivers/staging/rtl8192e/rtllib.h:423: warning: "WLAN_CAPABILITY_IBSS" redefined
423 | #define WLAN_CAPABILITY_IBSS BIT(1)
|
include/linux/ieee80211.h:3219: note: this is the location of the previous definition
3219 | #define WLAN_CAPABILITY_IBSS (1<<1)
|
>> drivers/staging/rtl8192e/rtllib.h:424: warning: "WLAN_CAPABILITY_PRIVACY" redefined
424 | #define WLAN_CAPABILITY_PRIVACY BIT(4)
|
include/linux/ieee80211.h:3231: note: this is the location of the previous definition
3231 | #define WLAN_CAPABILITY_PRIVACY (1<<4)
|
>> drivers/staging/rtl8192e/rtllib.h:425: warning: "WLAN_CAPABILITY_SHORT_PREAMBLE" redefined
425 | #define WLAN_CAPABILITY_SHORT_PREAMBLE BIT(5)
|
include/linux/ieee80211.h:3232: note: this is the location of the previous definition
3232 | #define WLAN_CAPABILITY_SHORT_PREAMBLE (1<<5)
|
>> drivers/staging/rtl8192e/rtllib.h:426: warning: "WLAN_CAPABILITY_SHORT_SLOT_TIME" redefined
426 | #define WLAN_CAPABILITY_SHORT_SLOT_TIME BIT(10)
|
include/linux/ieee80211.h:3239: note: this is the location of the previous definition
3239 | #define WLAN_CAPABILITY_SHORT_SLOT_TIME (1<<10)
|
during RTL pass: mach
drivers/staging/rtl8192e/rtllib_rx.c: In function 'rtllib_rx_decrypt':
drivers/staging/rtl8192e/rtllib_rx.c:1141:1: internal compiler error: in arc_ifcvt, at config/arc/arc.cc:9703
1141 | }
| ^
0x5b78c1 arc_ifcvt
/tmp/build-crosstools-gcc-13.2.0-binutils-2.41/gcc/gcc-13.2.0/gcc/config/arc/arc.cc:9703
0xe431b4 arc_reorg
/tmp/build-crosstools-gcc-13.2.0-binutils-2.41/gcc/gcc-13.2.0/gcc/config/arc/arc.cc:8552
0xaed299 execute
/tmp/build-crosstools-gcc-13.2.0-binutils-2.41/gcc/gcc-13.2.0/gcc/reorg.cc:3927
Please submit a full bug report, with preprocessed source (by using -freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.
--
In file included from drivers/staging/rtl8192e/rtl819x_BAProc.c:10:
>> drivers/staging/rtl8192e/rtllib.h:422: warning: "WLAN_CAPABILITY_ESS" redefined
422 | #define WLAN_CAPABILITY_ESS BIT(0)
|
In file included from include/net/cfg80211.h:23,
from drivers/staging/rtl8192e/rtllib.h:40:
include/linux/ieee80211.h:3218: note: this is the location of the previous definition
3218 | #define WLAN_CAPABILITY_ESS (1<<0)
|
>> drivers/staging/rtl8192e/rtllib.h:423: warning: "WLAN_CAPABILITY_IBSS" redefined
423 | #define WLAN_CAPABILITY_IBSS BIT(1)
|
include/linux/ieee80211.h:3219: note: this is the location of the previous definition
3219 | #define WLAN_CAPABILITY_IBSS (1<<1)
|
>> drivers/staging/rtl8192e/rtllib.h:424: warning: "WLAN_CAPABILITY_PRIVACY" redefined
424 | #define WLAN_CAPABILITY_PRIVACY BIT(4)
|
include/linux/ieee80211.h:3231: note: this is the location of the previous definition
3231 | #define WLAN_CAPABILITY_PRIVACY (1<<4)
|
>> drivers/staging/rtl8192e/rtllib.h:425: warning: "WLAN_CAPABILITY_SHORT_PREAMBLE" redefined
425 | #define WLAN_CAPABILITY_SHORT_PREAMBLE BIT(5)
|
include/linux/ieee80211.h:3232: note: this is the location of the previous definition
3232 | #define WLAN_CAPABILITY_SHORT_PREAMBLE (1<<5)
|
>> drivers/staging/rtl8192e/rtllib.h:426: warning: "WLAN_CAPABILITY_SHORT_SLOT_TIME" redefined
426 | #define WLAN_CAPABILITY_SHORT_SLOT_TIME BIT(10)
|
include/linux/ieee80211.h:3239: note: this is the location of the previous definition
3239 | #define WLAN_CAPABILITY_SHORT_SLOT_TIME (1<<10)
|
during RTL pass: mach
drivers/staging/rtl8192e/rtl819x_BAProc.c: In function 'rtllib_send_DELBA':
drivers/staging/rtl8192e/rtl819x_BAProc.c:212:1: internal compiler error: in arc_ifcvt, at config/arc/arc.cc:9703
212 | }
| ^
0x5b78c1 arc_ifcvt
/tmp/build-crosstools-gcc-13.2.0-binutils-2.41/gcc/gcc-13.2.0/gcc/config/arc/arc.cc:9703
0xe431b4 arc_reorg
/tmp/build-crosstools-gcc-13.2.0-binutils-2.41/gcc/gcc-13.2.0/gcc/config/arc/arc.cc:8552
0xaed299 execute
/tmp/build-crosstools-gcc-13.2.0-binutils-2.41/gcc/gcc-13.2.0/gcc/reorg.cc:3927
Please submit a full bug report, with preprocessed source (by using -freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.
--
In file included from drivers/staging/rtl8192e/rtllib_crypt_ccmp.c:17:
>> drivers/staging/rtl8192e/rtllib.h:422: warning: "WLAN_CAPABILITY_ESS" redefined
422 | #define WLAN_CAPABILITY_ESS BIT(0)
|
In file included from include/net/cfg80211.h:23,
from drivers/staging/rtl8192e/rtllib.h:40:
include/linux/ieee80211.h:3218: note: this is the location of the previous definition
3218 | #define WLAN_CAPABILITY_ESS (1<<0)
|
>> drivers/staging/rtl8192e/rtllib.h:423: warning: "WLAN_CAPABILITY_IBSS" redefined
423 | #define WLAN_CAPABILITY_IBSS BIT(1)
|
include/linux/ieee80211.h:3219: note: this is the location of the previous definition
3219 | #define WLAN_CAPABILITY_IBSS (1<<1)
|
>> drivers/staging/rtl8192e/rtllib.h:424: warning: "WLAN_CAPABILITY_PRIVACY" redefined
424 | #define WLAN_CAPABILITY_PRIVACY BIT(4)
|
include/linux/ieee80211.h:3231: note: this is the location of the previous definition
3231 | #define WLAN_CAPABILITY_PRIVACY (1<<4)
|
>> drivers/staging/rtl8192e/rtllib.h:425: warning: "WLAN_CAPABILITY_SHORT_PREAMBLE" redefined
425 | #define WLAN_CAPABILITY_SHORT_PREAMBLE BIT(5)
|
include/linux/ieee80211.h:3232: note: this is the location of the previous definition
3232 | #define WLAN_CAPABILITY_SHORT_PREAMBLE (1<<5)
|
>> drivers/staging/rtl8192e/rtllib.h:426: warning: "WLAN_CAPABILITY_SHORT_SLOT_TIME" redefined
426 | #define WLAN_CAPABILITY_SHORT_SLOT_TIME BIT(10)
|
include/linux/ieee80211.h:3239: note: this is the location of the previous definition
3239 | #define WLAN_CAPABILITY_SHORT_SLOT_TIME (1<<10)
|
during RTL pass: mach
drivers/staging/rtl8192e/rtllib_crypt_ccmp.c: In function 'rtllib_ccmp_decrypt':
drivers/staging/rtl8192e/rtllib_crypt_ccmp.c:310:1: internal compiler error: in arc_ifcvt, at config/arc/arc.cc:9703
310 | }
| ^
0x5b78c1 arc_ifcvt
/tmp/build-crosstools-gcc-13.2.0-binutils-2.41/gcc/gcc-13.2.0/gcc/config/arc/arc.cc:9703
0xe431b4 arc_reorg
/tmp/build-crosstools-gcc-13.2.0-binutils-2.41/gcc/gcc-13.2.0/gcc/config/arc/arc.cc:8552
0xaed299 execute
/tmp/build-crosstools-gcc-13.2.0-binutils-2.41/gcc/gcc-13.2.0/gcc/reorg.cc:3927
Please submit a full bug report, with preprocessed source (by using -freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.
--
In file included from drivers/staging/rtl8192e/rtllib_crypt_tkip.c:23:
>> drivers/staging/rtl8192e/rtllib.h:422: warning: "WLAN_CAPABILITY_ESS" redefined
422 | #define WLAN_CAPABILITY_ESS BIT(0)
|
In file included from include/net/cfg80211.h:23,
from drivers/staging/rtl8192e/rtllib.h:40:
include/linux/ieee80211.h:3218: note: this is the location of the previous definition
3218 | #define WLAN_CAPABILITY_ESS (1<<0)
|
>> drivers/staging/rtl8192e/rtllib.h:423: warning: "WLAN_CAPABILITY_IBSS" redefined
423 | #define WLAN_CAPABILITY_IBSS BIT(1)
|
include/linux/ieee80211.h:3219: note: this is the location of the previous definition
3219 | #define WLAN_CAPABILITY_IBSS (1<<1)
|
>> drivers/staging/rtl8192e/rtllib.h:424: warning: "WLAN_CAPABILITY_PRIVACY" redefined
424 | #define WLAN_CAPABILITY_PRIVACY BIT(4)
|
include/linux/ieee80211.h:3231: note: this is the location of the previous definition
3231 | #define WLAN_CAPABILITY_PRIVACY (1<<4)
|
>> drivers/staging/rtl8192e/rtllib.h:425: warning: "WLAN_CAPABILITY_SHORT_PREAMBLE" redefined
425 | #define WLAN_CAPABILITY_SHORT_PREAMBLE BIT(5)
|
include/linux/ieee80211.h:3232: note: this is the location of the previous definition
3232 | #define WLAN_CAPABILITY_SHORT_PREAMBLE (1<<5)
|
>> drivers/staging/rtl8192e/rtllib.h:426: warning: "WLAN_CAPABILITY_SHORT_SLOT_TIME" redefined
426 | #define WLAN_CAPABILITY_SHORT_SLOT_TIME BIT(10)
|
include/linux/ieee80211.h:3239: note: this is the location of the previous definition
3239 | #define WLAN_CAPABILITY_SHORT_SLOT_TIME (1<<10)
|
during RTL pass: mach
drivers/staging/rtl8192e/rtllib_crypt_tkip.c: In function 'rtllib_tkip_decrypt':
drivers/staging/rtl8192e/rtllib_crypt_tkip.c:437:1: internal compiler error: in arc_ifcvt, at config/arc/arc.cc:9703
437 | }
| ^
0x5b78c1 arc_ifcvt
/tmp/build-crosstools-gcc-13.2.0-binutils-2.41/gcc/gcc-13.2.0/gcc/config/arc/arc.cc:9703
0xe431b4 arc_reorg
/tmp/build-crosstools-gcc-13.2.0-binutils-2.41/gcc/gcc-13.2.0/gcc/config/arc/arc.cc:8552
0xaed299 execute
/tmp/build-crosstools-gcc-13.2.0-binutils-2.41/gcc/gcc-13.2.0/gcc/reorg.cc:3927
Please submit a full bug report, with preprocessed source (by using -freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.
--
In file included from drivers/staging/rtl8192e/rtl8192e/rtl_core.h:35,
from drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c:10:
>> drivers/staging/rtl8192e/rtl8192e/../rtllib.h:422: warning: "WLAN_CAPABILITY_ESS" redefined
422 | #define WLAN_CAPABILITY_ESS BIT(0)
|
In file included from include/net/cfg80211.h:23,
from drivers/staging/rtl8192e/rtl8192e/../rtllib.h:40:
include/linux/ieee80211.h:3218: note: this is the location of the previous definition
3218 | #define WLAN_CAPABILITY_ESS (1<<0)
|
>> drivers/staging/rtl8192e/rtl8192e/../rtllib.h:423: warning: "WLAN_CAPABILITY_IBSS" redefined
423 | #define WLAN_CAPABILITY_IBSS BIT(1)
|
include/linux/ieee80211.h:3219: note: this is the location of the previous definition
3219 | #define WLAN_CAPABILITY_IBSS (1<<1)
|
>> drivers/staging/rtl8192e/rtl8192e/../rtllib.h:424: warning: "WLAN_CAPABILITY_PRIVACY" redefined
424 | #define WLAN_CAPABILITY_PRIVACY BIT(4)
|
include/linux/ieee80211.h:3231: note: this is the location of the previous definition
3231 | #define WLAN_CAPABILITY_PRIVACY (1<<4)
|
>> drivers/staging/rtl8192e/rtl8192e/../rtllib.h:425: warning: "WLAN_CAPABILITY_SHORT_PREAMBLE" redefined
425 | #define WLAN_CAPABILITY_SHORT_PREAMBLE BIT(5)
|
include/linux/ieee80211.h:3232: note: this is the location of the previous definition
3232 | #define WLAN_CAPABILITY_SHORT_PREAMBLE (1<<5)
|
>> drivers/staging/rtl8192e/rtl8192e/../rtllib.h:426: warning: "WLAN_CAPABILITY_SHORT_SLOT_TIME" redefined
426 | #define WLAN_CAPABILITY_SHORT_SLOT_TIME BIT(10)
|
include/linux/ieee80211.h:3239: note: this is the location of the previous definition
3239 | #define WLAN_CAPABILITY_SHORT_SLOT_TIME (1<<10)
|
vim +/WLAN_CAPABILITY_ESS +422 drivers/staging/rtl8192e/rtllib.h
421
> 422 #define WLAN_CAPABILITY_ESS BIT(0)
> 423 #define WLAN_CAPABILITY_IBSS BIT(1)
> 424 #define WLAN_CAPABILITY_PRIVACY BIT(4)
> 425 #define WLAN_CAPABILITY_SHORT_PREAMBLE BIT(5)
> 426 #define WLAN_CAPABILITY_SHORT_SLOT_TIME BIT(10)
427
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
© 2016 - 2026 Red Hat, Inc.